Re: [PATCH ab/simplify-perl-makefile] perl: treat PERLLIB_EXTRA as an extra path again (Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules)

2018-01-02 Thread Ævar Arnfjörð Bjarmason
On Tue, Jan 02 2018, Jonathan Nieder jotted: > Subject: perl: treat PERLLIB_EXTRA as an extra path again > > PERLLIB_EXTRA was introduced in v1.9-rc0~88^2 (2013-11-15) as a way > for packagers to add additional directories such as the location of > Subversion's perl bindings to Git's perl path.

[PATCH ab/simplify-perl-makefile] perl: treat PERLLIB_EXTRA as an extra path again (Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules)

2018-01-02 Thread Jonathan Nieder
Subject: perl: treat PERLLIB_EXTRA as an extra path again PERLLIB_EXTRA was introduced in v1.9-rc0~88^2 (2013-11-15) as a way for packagers to add additional directories such as the location of Subversion's perl bindings to Git's perl path. Since 20d2a30f (Makefile: replace perl/Makefile.PL with

Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules

2018-01-02 Thread Jonathan Nieder
Hi, Ævar Arnfjörð Bjarmason wrote: > +++ b/Makefile [...] > -PERL_DEFINES = $(PERL_PATH_SQ):$(PERLLIB_EXTRA_SQ) > -$(SCRIPT_PERL_GEN): % : %.perl perl/perl.mak GIT-PERL-DEFINES > GIT-VERSION-FILE > +PERL_DEFINES = $(PERL_PATH_SQ):$(PERLLIB_EXTRA_SQ):$(perllibdir_SQ) > +$(SCRIPT_PERL_GEN): % :

Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-28 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> Here is the difference as I see between what we already have and >> this update, and a proposed summary. >> ... > > When I read this back on the 22nd I missed that you were waiting on my > feedback on this. Just saw What's Cooking now. Yes,

Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-27 Thread Ævar Arnfjörð Bjarmason
On Fri, Dec 22 2017, Junio C. Hamano jotted: > Ævar Arnfjörð Bjarmason writes: > >> Signed-off-by: Ævar Arnfjörð Bjarmason >> --- > > Thanks, but I thought the patch was already in 'next' for a week or > more and it's time to refine incrementally. > > Here

Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-22 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Signed-off-by: Ævar Arnfjörð Bjarmason > --- Thanks, but I thought the patch was already in 'next' for a week or more and it's time to refine incrementally. Here is the difference as I see between what we already have and

Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-20 Thread Alex Riesen
Ævar Arnfjörð Bjarmason, Wed, Dec 20, 2017 19:24:19 +0100: > diff --git a/INSTALL b/INSTALL > index ffb071e9f0..808e07b659 100644 > --- a/INSTALL > +++ b/INSTALL > @@ -84,9 +84,24 @@ Issues of note: > > GIT_EXEC_PATH=`pwd` > PATH=`pwd`:$PATH > - GITPERLLIB=`pwd`/perl/blib/lib > +

Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-20 Thread Todd Zullinger
Ævar Arnfjörð Bjarmason wrote: > On Wed, Dec 20, 2017 at 6:41 PM, Todd Zullinger wrote: >> /usr/share/perl5/vendor_perl/Git >> /usr/share/perl5/vendor_perl/Git.pm >> /usr/share/perl5/vendor_perl/Git/Error.pm >> [...] >> /usr/share/perl5/vendor_perl/build >>

[PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-20 Thread Ævar Arnfjörð Bjarmason
Replace the perl/Makefile.PL and the fallback perl/Makefile used under NO_PERL_MAKEMAKER=NoThanks with a much simpler implementation heavily inspired by how the i18n infrastructure's build process works[1]. The reason for having the Makefile.PL in the first place is that it was initially[2]