Re: [PATCHv2 0/7] Fix and generalize version sort reordering

2016-12-20 Thread Jeff King
On Tue, Dec 20, 2016 at 09:50:42AM +0100, SZEDER Gábor wrote: > > It just seems like the whole thing would conceptually easier if we > > pre-parsed the versions into a sequence of elements, then the comparison > > between any two elements would just walk that sequence. The benefit > > there is

Re: [PATCHv2 0/7] Fix and generalize version sort reordering

2016-12-20 Thread SZEDER Gábor
On Wed, Dec 14, 2016 at 6:08 PM, Jeff King wrote: > On Thu, Dec 08, 2016 at 03:23:54PM +0100, SZEDER Gábor wrote: > >> > With my patches it looks like this: >> > >> > $ git -c versionsort.prereleasesuffix=-pre \ >> > -c versionsort.prereleasesuffix=-prerelease \ >> >

Re: [PATCHv2 0/7] Fix and generalize version sort reordering

2016-12-14 Thread Junio C Hamano
Jeff King writes: > On Thu, Dec 08, 2016 at 03:23:54PM +0100, SZEDER Gábor wrote: > >> > With my patches it looks like this: >> > >> > $ git -c versionsort.prereleasesuffix=-pre \ >> > -c versionsort.prereleasesuffix=-prerelease \ >> > tag -l

Re: [PATCHv2 0/7] Fix and generalize version sort reordering

2016-12-14 Thread Jeff King
On Thu, Dec 08, 2016 at 03:23:54PM +0100, SZEDER Gábor wrote: > > With my patches it looks like this: > > > > $ git -c versionsort.prereleasesuffix=-pre \ > > -c versionsort.prereleasesuffix=-prerelease \ > > tag -l --sort=version:refname > > v1.0.0-prerelease1 > >

[PATCHv2 0/7] Fix and generalize version sort reordering

2016-12-08 Thread SZEDER Gábor
> After having slept on this a couple of times After having slept on it a few (erm...) more times... > I think the longest > matching prerelease suffix should determine the sorting order. > > A release tag usually consists of an optional prefix, e.g. 'v' or > 'snapshot-', followed by the actual