On Tue, Feb 20, 2018 at 11:55 AM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> The step to take an object store would just add expressiveness
>> to the code, which may help in understanding what part of the code is
>> related to what other part of the
Stefan Beller writes:
> The step to take an object store would just add expressiveness
> to the code, which may help in understanding what part of the code is
> related to what other part of the code, so it may be a readability gain
> on its own?
It certainly would allow you
On Tue, Feb 20, 2018 at 11:03 AM, Junio C Hamano wrote:
> Jonathan Nieder writes:
>
>> For what it's worth, I think I prefer v1. I put some comments on why
>> on patch 0 of v1 and would be interested in your thoughts on them
>> (e.g. as a reply to that).
On Tue, Feb 20, 2018 at 11:00 AM, Brandon Williams wrote:
> On 02/20, Stefan Beller wrote:
>> On Fri, Feb 16, 2018 at 2:34 PM, Jonathan Nieder wrote:
>> > Hi,
>> >
>> > Stefan Beller wrote:
>> >
>> >> v2:
>> >> * duplicated the 'ignore_env' bit into the
Jonathan Nieder writes:
> For what it's worth, I think I prefer v1. I put some comments on why
> on patch 0 of v1 and would be interested in your thoughts on them
> (e.g. as a reply to that). I also think that even if we want to
> switch to a style that passes around
On 02/20, Stefan Beller wrote:
> On Fri, Feb 16, 2018 at 2:34 PM, Jonathan Nieder wrote:
> > Hi,
> >
> > Stefan Beller wrote:
> >
> >> v2:
> >> * duplicated the 'ignore_env' bit into the object store as well
> >> * the #define trick no longer works as we do not have a
On Fri, Feb 16, 2018 at 2:34 PM, Jonathan Nieder wrote:
> Hi,
>
> Stefan Beller wrote:
>
>> v2:
>> * duplicated the 'ignore_env' bit into the object store as well
>> * the #define trick no longer works as we do not have a "the_objectstore"
>> global,
>> which means there is
Hi,
Stefan Beller wrote:
> v2:
> * duplicated the 'ignore_env' bit into the object store as well
> * the #define trick no longer works as we do not have a "the_objectstore"
> global,
> which means there is just one patch per function that is converted.
> As this follows the same structure
v2:
* duplicated the 'ignore_env' bit into the object store as well
* the #define trick no longer works as we do not have a "the_objectstore"
global,
which means there is just one patch per function that is converted.
As this follows the same structure of the previous series, I am still
9 matches
Mail list logo