Re: [RFC/PATCH] drop vcs-svn experiment

2018-10-03 Thread Jonathan Nieder
Jeff King wrote: > On Fri, Aug 17, 2018 at 10:26:05PM -0700, Jonathan Nieder wrote: >> - testsvn:: is a demo and at a minimum we ought not to install it >>with "make install" >> >> - keeping this in-tree for the benefit of just one user is excessive, >>so removing it is probably the

Re: [RFC/PATCH] drop vcs-svn experiment

2018-10-03 Thread Jeff King
On Fri, Aug 17, 2018 at 10:26:05PM -0700, Jonathan Nieder wrote: > > Of course, I could be completely wrong about people using this. Maybe > > svn-fe builds are just completely broken on my system, and maybe people > > really do use testsvn::. But if so, they certainly aren't talking about > > it

Re: [RFC/PATCH] drop vcs-svn experiment

2018-08-18 Thread Jeff King
On Fri, Aug 17, 2018 at 10:26:05PM -0700, Jonathan Nieder wrote: > > We also ship contrib/svn-fe, which builds on the vcs-svn > > work. However, it does not seem to build out of the box for > > me, as the link step misses some required libraries for > > using libgit.a. > > What libraries do you

Re: [RFC/PATCH] drop vcs-svn experiment

2018-08-17 Thread Jonathan Nieder
Hi, Jeff King wrote: > The code in vcs-svn was started in 2010 as an attempt to > build a remote-helper for interacting with svn repositories > (as opposed to git-svn). However, we never got as far as > shipping a mature remote helper, and the last substantive > commit was e99d012a6bc in 2012.

Re: [RFC/PATCH] drop vcs-svn experiment

2018-08-17 Thread Todd Zullinger
Hi Jeff, Jeff King wrote: > .gitignore | 1 - > Makefile | 22 -- > contrib/svn-fe/.gitignore | 4 - > contrib/svn-fe/Makefile| 105 --- > contrib/svn-fe/svn-fe.c| 18 -- > contrib/svn-fe/svn-fe.txt | 71 - >

[RFC/PATCH] drop vcs-svn experiment

2018-08-17 Thread Jeff King
The code in vcs-svn was started in 2010 as an attempt to build a remote-helper for interacting with svn repositories (as opposed to git-svn). However, we never got as far as shipping a mature remote helper, and the last substantive commit was e99d012a6bc in 2012. We do have a git-remote-testsvn,