Re: [RFC] 'unsigned long' to 'size_t' conversion

2017-12-06 Thread Jeff King
On Wed, Dec 06, 2017 at 10:08:23AM -0500, Derrick Stolee wrote: > There are several places in Git where we refer to the size of an object by > an 'unsigned long' instead of a 'size_t'. In 64-bit Linux, 'unsigned long' > is 8 bytes, but in 64-bit Windows it is 4 bytes. > > The main issue with

Re: [RFC] 'unsigned long' to 'size_t' conversion

2017-12-06 Thread Brandon Williams
On 12/06, Derrick Stolee wrote: > There are several places in Git where we refer to the size of an > object by an 'unsigned long' instead of a 'size_t'. In 64-bit Linux, > 'unsigned long' is 8 bytes, but in 64-bit Windows it is 4 bytes. > > The main issue with this conversion is that large

Re: [RFC] 'unsigned long' to 'size_t' conversion

2017-12-06 Thread Thomas Braun
Am 06.12.2017 um 16:08 schrieb Derrick Stolee: Hi Derrick, > If there are small, isolated chunks that can be done safely, then this > may be a good target for a first patch. Here are some pointers to past discussions: -

[RFC] 'unsigned long' to 'size_t' conversion

2017-12-06 Thread Derrick Stolee
There are several places in Git where we refer to the size of an object by an 'unsigned long' instead of a 'size_t'. In 64-bit Linux, 'unsigned long' is 8 bytes, but in 64-bit Windows it is 4 bytes. The main issue with this conversion is that large objects fail to load (they seem to hash and