Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

2018-06-13 Thread Luis Marsano
On Tue, Jun 12, 2018 at 11:08 PM Todd Zullinger wrote: > As far as removing the autodie dep, is there anything more > to that than dropping the 'use autodie' line? It looks like > doing so leaves us no worse than we were before, but I > haven't written any perl in a long time. Erasing that line

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

2018-06-12 Thread Todd Zullinger
Hi, Ævar Arnfjörð Bjarmason wrote: > > On Sun, Jun 10 2018, Todd Zullinger wrote: > >>> I added 'use autodie;' without realizing it had external dependencies. >>> According to the documentation >>> http://perldoc.perl.org/autodie.html >>> it's a pragma since perl 5.10.1 >>> Removing 'use

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

2018-06-10 Thread Ævar Arnfjörð Bjarmason
On Sun, Jun 10 2018, Todd Zullinger wrote: >> I added 'use autodie;' without realizing it had external dependencies. >> According to the documentation >> http://perldoc.perl.org/autodie.html >> it's a pragma since perl 5.10.1 >> Removing 'use autodie;' should be fine: it's not critical. > > I

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

2018-06-09 Thread Todd Zullinger
Hi Luis, Luis Marsano wrote: > Thanks for looking into this and addressing these issues. And thank you for digging further. :) > On Thu, Jun 7, 2018 at 1:20 AM Todd Zullinger wrote: >> I noticed failures from the contrib/credential/netrc tests >> while building 2.18.0 release candidates. I

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

2018-06-09 Thread Luis Marsano
Thanks for looking into this and addressing these issues. On Thu, Jun 7, 2018 at 1:20 AM Todd Zullinger wrote: > > Hi, > > I noticed failures from the contrib/credential/netrc tests > while building 2.18.0 release candidates. I was surprised > to see the tests being run when called with a

[RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

2018-06-06 Thread Todd Zullinger
Hi, I noticed failures from the contrib/credential/netrc tests while building 2.18.0 release candidates. I was surprised to see the tests being run when called with a simple 'make' command. The first patch in the series adds an empty 'all::' make target to match most of our other Makefiles and