On Tue, May 09, 2017 at 10:49:19AM +0900, Junio C Hamano wrote:
> Jeff King writes:
>
> > The specific helpers have less visibility, which is good. The public
> > functions a() and b() were already public, so no change. But now the
> > common helper is public, too, even though
Jeff King writes:
> The specific helpers have less visibility, which is good. The public
> functions a() and b() were already public, so no change. But now the
> common helper is public, too, even though nobody except a() and b() care
> about it.
>
> So it's a tradeoff. And the
On Mon, May 8, 2017 at 2:55 PM, Jeff King wrote:
> On Mon, May 08, 2017 at 10:02:58AM +0900, Junio C Hamano wrote:
>
>> Stefan Beller writes:
>>
>> > I guess it is ok for now and in this series, but we may want
>> > to split up diff.[ch] in the future into
On Mon, May 08, 2017 at 10:02:58AM +0900, Junio C Hamano wrote:
> Stefan Beller writes:
>
> > I guess it is ok for now and in this series, but we may want
> > to split up diff.[ch] in the future into multiple finer grained files.
>
> For what end? Such a split would
Stefan Beller writes:
> I guess it is ok for now and in this series, but we may want
> to split up diff.[ch] in the future into multiple finer grained files.
For what end? Such a split would require more symbols internal to
diff.[ch] to become external, which is a big
On Fri, May 5, 2017 at 10:44 AM, Junio C Hamano wrote:
> Jeff Smith writes:
>
>> Signed-off-by: Jeff Smith
>> ---
>> builtin.h | 2 --
>> builtin/blame.c| 28
>> builtin/cat-file.c | 1 +
>>
Jeff Smith writes:
> Signed-off-by: Jeff Smith
> ---
> builtin.h | 2 --
> builtin/blame.c| 28
> builtin/cat-file.c | 1 +
> diff.c | 23 +++
> diff.h | 7 +++
>
Signed-off-by: Jeff Smith
---
builtin.h | 2 --
builtin/blame.c| 28
builtin/cat-file.c | 1 +
diff.c | 23 +++
diff.h | 7 +++
5 files changed, 31 insertions(+), 30 deletions(-)
8 matches
Mail list logo