Re: [RFC PATCH 02/10] Move textconv_object to be with other textconv methods

2017-05-08 Thread Jeff King
On Tue, May 09, 2017 at 10:49:19AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > The specific helpers have less visibility, which is good. The public > > functions a() and b() were already public, so no change. But now the > > common helper is public, too, even though

Re: [RFC PATCH 02/10] Move textconv_object to be with other textconv methods

2017-05-08 Thread Junio C Hamano
Jeff King writes: > The specific helpers have less visibility, which is good. The public > functions a() and b() were already public, so no change. But now the > common helper is public, too, even though nobody except a() and b() care > about it. > > So it's a tradeoff. And the

Re: [RFC PATCH 02/10] Move textconv_object to be with other textconv methods

2017-05-08 Thread Stefan Beller
On Mon, May 8, 2017 at 2:55 PM, Jeff King wrote: > On Mon, May 08, 2017 at 10:02:58AM +0900, Junio C Hamano wrote: > >> Stefan Beller writes: >> >> > I guess it is ok for now and in this series, but we may want >> > to split up diff.[ch] in the future into

Re: [RFC PATCH 02/10] Move textconv_object to be with other textconv methods

2017-05-08 Thread Jeff King
On Mon, May 08, 2017 at 10:02:58AM +0900, Junio C Hamano wrote: > Stefan Beller writes: > > > I guess it is ok for now and in this series, but we may want > > to split up diff.[ch] in the future into multiple finer grained files. > > For what end? Such a split would

Re: [RFC PATCH 02/10] Move textconv_object to be with other textconv methods

2017-05-07 Thread Junio C Hamano
Stefan Beller writes: > I guess it is ok for now and in this series, but we may want > to split up diff.[ch] in the future into multiple finer grained files. For what end? Such a split would require more symbols internal to diff.[ch] to become external, which is a big

Re: [RFC PATCH 02/10] Move textconv_object to be with other textconv methods

2017-05-05 Thread Stefan Beller
On Fri, May 5, 2017 at 10:44 AM, Junio C Hamano wrote: > Jeff Smith writes: > >> Signed-off-by: Jeff Smith >> --- >> builtin.h | 2 -- >> builtin/blame.c| 28 >> builtin/cat-file.c | 1 + >>

Re: [RFC PATCH 02/10] Move textconv_object to be with other textconv methods

2017-05-05 Thread Junio C Hamano
Jeff Smith writes: > Signed-off-by: Jeff Smith > --- > builtin.h | 2 -- > builtin/blame.c| 28 > builtin/cat-file.c | 1 + > diff.c | 23 +++ > diff.h | 7 +++ >

[RFC PATCH 02/10] Move textconv_object to be with other textconv methods

2017-05-04 Thread Jeff Smith
Signed-off-by: Jeff Smith --- builtin.h | 2 -- builtin/blame.c| 28 builtin/cat-file.c | 1 + diff.c | 23 +++ diff.h | 7 +++ 5 files changed, 31 insertions(+), 30 deletions(-)