[RFH] renaming strcmp/strncmp-icase

2014-09-08 Thread Junio C Hamano
There are these two functions in dir.c that has only a handful of callers outside: int strcmp_icase(const char *a, const char *b); int strncmp_icase(const char *a, const char *b, size_t count); How many of you would think these are about comparing two strings in a case-insensitive way?

Re: [RFH] renaming strcmp/strncmp-icase

2014-09-08 Thread Torsten Bögershausen
On 2014-09-08 20.52, Junio C Hamano wrote: There are these two functions in dir.c that has only a handful of callers outside: int strcmp_icase(const char *a, const char *b); int strncmp_icase(const char *a, const char *b, size_t count); How many of you would think these are about

Re: [RFH] renaming strcmp/strncmp-icase

2014-09-08 Thread Junio C Hamano
Torsten Bögershausen tbo...@web.de writes: And then we have this in name-hash.c: (Which may explain the icase suffix ?) static int same_name(const struct cache_entry *ce, const char *name, int namelen, int icase) As this file-scope static function takes the icase as an explicit argument, I

Re: [RFH] renaming strcmp/strncmp-icase

2014-09-08 Thread René Scharfe
Am 08.09.2014 um 20:52 schrieb Junio C Hamano: There are these two functions in dir.c that has only a handful of callers outside: int strcmp_icase(const char *a, const char *b); int strncmp_icase(const char *a, const char *b, size_t count); How many of you would think these are about