BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed

I was trying to send a new version of a patch to a gerrit server from a new computer, so I made a change with a ChangeId in the description and tried to review it: strainu@emily:~/core git branch archivebot strainu@emily:~/core git checkout archivebot M pywikibot/page.py Switched to branch

Re: BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed

Hi, Strainu wrote: strainu@emily:~/core git review -f Creating a git remote called gerrit that maps to: ssh://stra...@gerrit.wikimedia.org:29418/pywikibot/core.git Your change was committed before the commit hook was installed. Amending the commit to add a gerrit change id. At

Re: BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed

2014/1/17 Jonathan Nieder jrnie...@gmail.com: Hi, Strainu wrote: strainu@emily:~/core git review -f Creating a git remote called gerrit that maps to: ssh://stra...@gerrit.wikimedia.org:29418/pywikibot/core.git Your change was committed before the commit hook was installed.

Re: [OpenStack-Infra] BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed

Perhaps I haven't been clear enough: the commit already had a change ID, added manually, so with or without the hook it would have been attached to the correct review. In this case, the hook will actually do nothing, making the current wording of the message confusing IMO. My suggestion was [1]