Re: Git Test Coverage Report (Friday, Nov 2)

2018-11-04 Thread Junio C Hamano
Michał Górny writes: > I've just did a little research and came to the following results: Wonderful. > 1. modifying the 'C. O. Mitter' key would require changes to 4 tests, > > 2. modifying the 'Eris Discordia' key would require changes to 2 tests >(both in 7510). > > Do you think 2. would

Re: Git Test Coverage Report (Friday, Nov 2)

2018-11-03 Thread Michał Górny
On Sat, 2018-11-03 at 19:03 +0900, Junio C Hamano wrote: > Michał Górny writes: > > > As for how involved... we'd just have to use a key that has split > > signing subkey. Would it be fine to add the subkey to the existing key? > > It would imply updating keyids/fingerprints everywhere. > >

Re: Git Test Coverage Report (Friday, Nov 2)

2018-11-03 Thread SZEDER Gábor
On Fri, Nov 02, 2018 at 10:16:48PM -0400, Derrick Stolee wrote: > Here is the coverage report for today. Some builds were timing out, so I > removed the tests with number 9000 or more from the build [1]. Hopefully > this is a temporary measure. I think it's the Azure CI patch series, see:

Re: Git Test Coverage Report (Friday, Nov 2)

2018-11-03 Thread Junio C Hamano
Michał Górny writes: > As for how involved... we'd just have to use a key that has split > signing subkey. Would it be fine to add the subkey to the existing key? > It would imply updating keyids/fingerprints everywhere. Yes, that "everywhere" is exactly what I meant by "how involved", and

Re: Git Test Coverage Report (Friday, Nov 2)

2018-11-03 Thread Michał Górny
On Sat, 2018-11-03 at 12:38 +0900, Junio C Hamano wrote: > Derrick Stolee writes: > > > Uncovered code in 'next' not in 'master' > > > > > > pretty.c > > 4de9394dcb 1264) if (c->signature_check.primary_key_fingerprint) > > 4de9394dcb 1265)

Re: Git Test Coverage Report (Friday, Nov 2)

2018-11-02 Thread Junio C Hamano
Derrick Stolee writes: > Uncovered code in 'next' not in 'master' > > > pretty.c > 4de9394dcb 1264) if (c->signature_check.primary_key_fingerprint) > 4de9394dcb 1265) strbuf_addstr(sb, > c->signature_check.primary_key_fingerprint); > 4de9394dcb 1266)

Git Test Coverage Report (Friday, Nov 2)

2018-11-02 Thread Derrick Stolee
Here is the coverage report for today. Some builds were timing out, so I removed the tests with number 9000 or more from the build [1]. Hopefully this is a temporary measure. Thanks, -Stolee [1] https://dev.azure.com/git/git/_build/results?buildId=250&_a=summary=logs --- pu: