Re: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-19 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> Is there anything I'm supposed to do differently now to make our test >> suite run? If yes then a clear and short hint in the patch description >> would me more than approriate. > > This is a bug in my patch, I can reproduce it on CO7. Will

Re: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-15 Thread Ævar Arnfjörð Bjarmason
On Fri, Dec 15, 2017 at 11:35 AM, Michael J Gruber wrote: > Ævar Arnfjörð Bjarmason venit, vidit, dixit 12.12.2017 23:26: >> >> On Tue, Dec 12 2017, Randall S. Becker jotted: >> >>> -Original Message- >>> On December 10, 2017 4:14 PM, Ævar Arnfjörð Bjarmason wrote: >>>

Re: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-15 Thread Todd Zullinger
Hi Michael, Michael J Gruber wrote: > This patch (currently in origin/next) makes a ton of tests from our test > suite fail for me on pretty standard systems (Fedora 27, CentOS 7.4.1708). > > Is there anything I'm supposed to do differently now to make our test > suite run? If yes then a clear

Re: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-15 Thread Michael J Gruber
Ævar Arnfjörð Bjarmason venit, vidit, dixit 12.12.2017 23:26: > > On Tue, Dec 12 2017, Randall S. Becker jotted: > >> -Original Message- >> On December 10, 2017 4:14 PM, Ævar Arnfjörð Bjarmason wrote: >> Subject: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules >> >>>

Re: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-12 Thread Ævar Arnfjörð Bjarmason
On Tue, Dec 12 2017, Randall S. Becker jotted: > -Original Message- > On December 10, 2017 4:14 PM, Ævar Arnfjörð Bjarmason wrote: > Subject: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules > >>Replace the perl/Makefile.PL and the fallback perl/Makefile used under

RE: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-12 Thread Randall S. Becker
-Original Message- On December 10, 2017 4:14 PM, Ævar Arnfjörð Bjarmason wrote: Subject: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules >Replace the perl/Makefile.PL and the fallback perl/Makefile used under >NO_PERL_MAKEMAKER=NoThanks with a much simpler

Re: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules

2017-12-11 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > I don't know what I was thinking when I wrote this, but this logic > should be fully robust, and I've confirmed that all tests pass > with/without an Error.pm installed globally. Thanks. Will queue and drop the revert from 'pu'.