Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-22 Thread Johannes Schindelin
Hi Junio, On 2015-06-21 22:35, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: On 2015-06-21 19:15, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: That's brilliant. Just to make sure I am reading you correctly, you mean the current

RE: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-21 Thread Johannes Schindelin
Hi Randall, On 2015-06-21 07:09, Randall S. Becker wrote: On June 21, 2015 12:56 AM, Michael Haggerty wrote: As for thinking of a shorter name for the option: assuming the blob integrity checks can be turned on and off independently as described above, then I think it is reasonable to

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-21 Thread Johannes Schindelin
Hi Michael, On 2015-06-21 06:55, Michael Haggerty wrote: On 06/19/2015 10:53 PM, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: Can you think of a name for the option that is as short as `--quick` but means the same as `--connectivity-only`? No I can't. I

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-21 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: But now that I'm writing this, a silly question occurs to me: Do we need an overall option like this at all? If I demote all blob-integrity checks to ignore via the mechanism that you have added, then shouldn't fsck automatically detect that it

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-21 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Of course, that assumes that you can tell an object is a blob without unpacking. If a tree entry mentions an object to be a blob by having 100644 as its mode, unless you unpack the object pointed at by that tree entry to make sure it is a blob, you

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-21 Thread Johannes Schindelin
Hi Junio, On 2015-06-21 19:15, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: But now that I'm writing this, a silly question occurs to me: Do we need an overall option like this at all? If I demote all blob-integrity checks to ignore via the mechanism that you have

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-21 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: On 2015-06-21 19:15, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: That's brilliant. Just to make sure I am reading you correctly, you mean the current overall structure: [...] The way I read Michael's mail,

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-20 Thread Michael Haggerty
On 06/19/2015 10:53 PM, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: Can you think of a name for the option that is as short as `--quick` but means the same as `--connectivity-only`? No I can't. I think `--connectivity-only` is a very good name that is

RE: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-20 Thread Randall S. Becker
On June 21, 2015 12:56 AM, Michael Haggerty wrote: On 06/19/2015 10:53 PM, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: Can you think of a name for the option that is as short as `--quick` but means the same as `--connectivity-only`? No I can't. I

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-19 Thread Scott Schmit
On Fri, Jun 19, 2015 at 01:53:01PM -0700, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: Can you think of a name for the option that is as short as `--quick` but means the same as `--connectivity-only`? No I can't. I think `--connectivity-only` is a very

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-19 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: This option avoids unpacking each and all objects, and just verifies the connectivity. That sounds like marketing ;-) Wow this does not unpack unnecessarily, wait, it needs to unpack and parse 3 out of 4 kinds of objects? Jokes aside,

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-19 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: Can you think of a name for the option that is as short as `--quick` but means the same as `--connectivity-only`? No I can't. I think `--connectivity-only` is a very good name that is unfortunately a mouthful, I agree that we need a name

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-19 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: Jokes aside, given that you should regularly repack your repository anyway, I do not think it is such a big downside that this mode misses a corrupt objects, and the 1 out of 4 kinds of objects, i.e. blobs, occupy major part of the

Re: [PATCH v6 17/19] fsck: Introduce `git fsck --quick`

2015-06-19 Thread Junio C Hamano
Scott Schmit i.g...@comcast.net writes: On Fri, Jun 19, 2015 at 01:53:01PM -0700, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: Can you think of a name for the option that is as short as `--quick` but means the same as `--connectivity-only`? No I can't.