Eric Sunshine sunsh...@sunshineco.com writes:
A bit cleaner:
#ifndef(MAX_IO_SIZE)
# define MAX_IO_SIZE_DEFAULT (8*1024*1024)
# if defined(SSIZE_MAX) (SSIZE_MAX MAX_IO_SIZE_DEFAULT)
# define MAX_IO_SIZE SSIZE_MAX
# else
# define MAX_IO_SIZE MAX_IO_SIZE_DEFAULT
# endif
#endif
OK,
Junio C Hamano gitster at pobox.com writes:
snip
OK, then let's do this.
Yep, that'd do, thanks.
bye, Jojo
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Joachim Schmitz jojo at schmitz-digital.de writes:
Junio C Hamano gitster at pobox.com writes:
snip
OK, then let's do this.
Except for the type taht
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo
Joachim Schmitz j...@schmitz-digital.de writes:
Joachim Schmitz jojo at schmitz-digital.de writes:
Junio C Hamano gitster at pobox.com writes:
snip
OK, then let's do this.
Except for the type taht
Also #ifndef part X-
Here is what I queued for the day.
-- 8 --
Subject:
Sorry to be a pain, but i think this sententence neede mending
+ * to override this, if the definition of SSIZE_MAX platform is broken.
Bye, Jojo
Junio C Hamano gitster at pobox.com writes:
snip
something like this:
/* allow overwriting from e.g. Makefile */
#if !defined(MAX_IO_SIZE)
# define MAX_IO_SIZE (8*1024*1024)
#endif
/* for plattforms that have SSIZE and have it smaller */
#if defined(SSIZE_MAX (SSIZE_MAX
On Sun, Feb 8, 2015 at 7:05 AM, Joachim Schmitz j...@schmitz-digital.de wrote:
Junio C Hamano gitster at pobox.com writes:
(1) if Makefile gives one, use it without second-guessing with SSIZE_MAX.
(2) if SSIZE_MAX is defined, and if it is smaller than our internal
default, use it.
(3) all
Joachim Schmitz jojo at schmitz-digital.de writes:
Torsten Bögershausen tboegi at web.de writes:
On 2015-02-07 17.45, Joachim Schmitz wrote:
snip
b) never ever should read() be asked to read more than SSIZE_MAX, this
should be true for every platform on the planet? You may want to
On 2015-02-07 12:30PM Torsten Bögershausen wrote:
On 2015-02-07 17.45, Joachim Schmitz wrote:
Hi there
While investigating the problem with hung git-upload-pack we think to
have found a bug in wrapper.c:
#define MAX_IO_SIZE (8*1024*1024)
This is then used in xread() to split read()s
On 2015-02-07 13:07PM Randall S. Becker wrote:
On 2015-02-07 12:30PM Torsten Bögershausen wrote:
On 2015-02-07 17.45, Joachim Schmitz wrote:
Hi there
While investigating the problem with hung git-upload-pack we think to
have found a bug in wrapper.c:
#define MAX_IO_SIZE (8*1024*1024)
Randall S. Becker rsbecker at nexbridge.com writes:
On 2015-02-07 13:07PM Randall S. Becker wrote:
On 2015-02-07 12:30PM Torsten Bögershausen wrote:
On 2015-02-07 17.45, Joachim Schmitz wrote:
spip
Although I do agree with Jojo, that MAX_IO_SIZE seems to be a platform
constant and should
Joachim Schmitz jojo at schmitz-digital.de writes:
because xpread() returns something 0.
something 0 of course (presumably -1)...
bye, Jojo
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 2015-02-07 17.45, Joachim Schmitz wrote:
Hi there
While investigating the problem with hung git-upload-pack we think to have
found a bug in wrapper.c:
#define MAX_IO_SIZE (8*1024*1024)
This is then used in xread() to split read()s into suitable chunks.
So far so good, but read() is
Torsten Bögershausen tboegi at web.de writes:
On 2015-02-07 17.45, Joachim Schmitz wrote:
snip
How about changing wrapper.c like this:
#ifndef MAX_IO_SIZE
#define MAX_IO_SIZE (8*1024*1024)
#endif
-
and to change config.mak.uname like this:
ifeq
Joachim Schmitz jojo at schmitz-digital.de writes:
snip
and as a (rather strange)
consequence mmap() (from compat/mmap.c) fails with EACCESS (why
EACCESS?),
because xpread() returns something 0.
Seems mmap() should either set errno to EINVAL or not set it at all an
just 'forward'
On 2015-02-07 18.29, Joachim Schmitz wrote:
Torsten Bögershausen tboegi at web.de writes:
On 2015-02-07 17.45, Joachim Schmitz wrote:
snip
How about changing wrapper.c like this:
#ifndef MAX_IO_SIZE
#define MAX_IO_SIZE (8*1024*1024)
#endif
-
and to change
Junio C Hamano gitster at pobox.com writes:
On Sat, Feb 7, 2015 at 12:32 PM, Torsten Bögershausen tboegi at
web.de wrote:
I don't know every platform of the planet well enough to be helpful
here,
especially the ones which don't follow all the specifications.
In other words: As long
On Feb 7 2015 at 9:14 PM Junio C Hamano wrote:
On Sat, Feb 7, 2015 at 2:31 PM, Joachim Schmitz j...@schmitz-digital.de
wrote:
Junio C Hamano gitster at pobox.com writes:
Yup, I agree that is a sensible way to go.
(1) if Makefile overrides the size, use it; otherwise
(2) if SSIZE_MAX is
On Sat, Feb 7, 2015 at 12:32 PM, Torsten Bögershausen tbo...@web.de wrote:
I don't know every platform of the planet well enough to be helpful here,
especially the ones which don't follow all the specifications.
In other words: As long as we can not guarantee that SSIZE_MAX is defined,
(and
On Sat, Feb 7, 2015 at 2:31 PM, Joachim Schmitz j...@schmitz-digital.de wrote:
Junio C Hamano gitster at pobox.com writes:
Yup, I agree that is a sensible way to go.
(1) if Makefile overrides the size, use it; otherwise
(2) if SSIZE_MAX is defined, and it is smaller than our internal
20 matches
Mail list logo
