Re: Why git-revert doesn't invoke the pre-commit and the commit-msg hooks?

2018-02-21 Thread Gustavo Chaves
2018-02-20 15:00 GMT-03:00 Junio C Hamano : > It would make more sense (if we were to add > an option to run any hook we currently do not run to the command) to > run pre-revert/revert-msg hooks instead, and then people who happen > to want to do the same thing in these hooks

Re: Why git-revert doesn't invoke the pre-commit and the commit-msg hooks?

2018-02-20 Thread Junio C Hamano
Phillip Wood writes: > ... I'm worried though that > someone out there is scripting with a non-interactive editor which may > break if we start verifying the message ... This is a very valid concern. Making sure that 'revert' pays attention to the --verify option

Re: Why git-revert doesn't invoke the pre-commit and the commit-msg hooks?

2018-02-20 Thread Phillip Wood
Hi Gustavo On 19/02/18 14:50, Gustavo Chaves wrote: > > I asked this question on StackOverflow and got an answer: > https://stackoverflow.com/q/48852925/114983 > > The problem is that git-revert invokes git-commit with the -n flag, > explicitly avoiding the pre-commit and the commit-msg hooks.

Re: Why git-revert doesn't invoke the pre-commit and the commit-msg hooks?

2018-02-19 Thread Gustavo Chaves
I asked this question on StackOverflow and got an answer: https://stackoverflow.com/q/48852925/114983 The problem is that git-revert invokes git-commit with the -n flag, explicitly avoiding the pre-commit and the commit-msg hooks. This was originally introduced on commit 9fa4db544e2e, by Junio

Why git-revert doesn't invoke the pre-commit and the commit-msg hooks?

2018-02-13 Thread Gustavo Chaves
Using strace I noticed that git-revert invokes only two hooks: - prepare-commit-msg - post-commit But git-commit invoke these four: - pre-commit - prepare-commit-msg - commit-msg - post-commit Since git-revert produces a commit, why doesn't it invoke the same hooks as git-commit? I couldn't