Re: git 2.16.0 segfaults on clone of specific repo

On Fri, Jan 19, 2018 at 7:23 PM, brian m. carlson wrote: > On Fri, Jan 19, 2018 at 07:15:45PM -0500, Eric Sunshine wrote: >> Are you planning on submitting the test as a proper patch as follow-up >> to [1]? I couldn't quite decide in which test script it should

Re: git 2.16.0 segfaults on clone of specific repo

On Fri, Jan 19, 2018 at 07:15:45PM -0500, Eric Sunshine wrote: > Oh, I agree. My original question of its practical value was based > upon my belief that the full test suite is very rarely run on MacOS > (partly because there are so few Git developers on MacOS and partly > because it runs so

Re: git 2.16.0 segfaults on clone of specific repo

On Fri, Jan 19, 2018 at 12:25 PM, Todd Zullinger wrote: > Eric Sunshine wrote: >> Nice detective work. This particular manifestation is caught by the >> following test which fails without brian's patch on MacOS (and >> presumably Windows) and succeeds with it. On Linux and BSD, it

Re: git 2.16.0 segfaults on clone of specific repo

On Fri, Jan 19, 2018 at 5:31 PM, brian m. carlson wrote: > On Fri, Jan 19, 2018 at 02:40:02AM -0500, Eric Sunshine wrote: >> Nice detective work. This particular manifestation is caught by the >> following test which fails without brian's patch on MacOS (and >>

Re: git 2.16.0 segfaults on clone of specific repo

On Fri, Jan 19, 2018 at 02:40:02AM -0500, Eric Sunshine wrote: > Nice detective work. This particular manifestation is caught by the > following test which fails without brian's patch on MacOS (and > presumably Windows) and succeeds with it. On Linux and BSD, it will of > course succeed always, so

Re: git 2.16.0 segfaults on clone of specific repo

Eric Sunshine wrote: > Nice detective work. This particular manifestation is caught by the > following test which fails without brian's patch on MacOS (and > presumably Windows) and succeeds with it. On Linux and BSD, it will of > course succeed always, so I'm not sure how much practical value it

Re: git 2.16.0 segfaults on clone of specific repo

On Fri, Jan 19, 2018 at 3:22 AM, Duy Nguyen wrote: > On Fri, Jan 19, 2018 at 2:40 PM, Eric Sunshine > wrote: >> On Fri, Jan 19, 2018 at 12:31:58PM +0700, Duy Nguyen wrote: >>> On Linux, after I hacked all over the place to force ce_match_stat() >>> to

Re: git 2.16.0 segfaults on clone of specific repo

On Fri, Jan 19, 2018 at 2:40 PM, Eric Sunshine wrote: > On Fri, Jan 19, 2018 at 12:31:58PM +0700, Duy Nguyen wrote: >> On Fri, Jan 19, 2018 at 10:40 AM, brian m. carlson >> > I'm still extremely puzzled as to why this doesn't fail on Linux. If >> > it's failing in this

Re: git 2.16.0 segfaults on clone of specific repo

On Fri, Jan 19, 2018 at 12:31:58PM +0700, Duy Nguyen wrote: > On Fri, Jan 19, 2018 at 10:40 AM, brian m. carlson > > I'm still extremely puzzled as to why this doesn't fail on Linux. If > > it's failing in this case, it should very, very clearly fail all the > > time we access an empty blob or an

Re: git 2.16.0 segfaults on clone of specific repo

On Fri, Jan 19, 2018 at 10:40 AM, brian m. carlson wrote: > On Thu, Jan 18, 2018 at 10:06:10PM -0500, Eric Sunshine wrote: >> > I have a guess about what the problem might be. Can you try this patch >> > and see if it fixes things? >> >> That does fix the crash.

Re: git 2.16.0 segfaults on clone of specific repo

On Thu, Jan 18, 2018 at 10:06:10PM -0500, Eric Sunshine wrote: > > I have a guess about what the problem might be. Can you try this patch > > and see if it fixes things? > > That does fix the crash. Thanks for the quick diagnosis. > > Can the commit message go into more detail as to why this

RE: git 2.16.0 segfaults on clone of specific repo

On January 18, 2018 10:06 PM, Eric Sunshine wrote: > On Thu, Jan 18, 2018 at 9:47 PM, brian m. carlson > wrote: > > On Thu, Jan 18, 2018 at 07:15:56PM -0500, Eric Sunshine wrote: > >> On Thu, Jan 18, 2018 at 3:55 PM, Александр Булаев > >>

Re: git 2.16.0 segfaults on clone of specific repo

On Thu, Jan 18, 2018 at 9:47 PM, brian m. carlson wrote: > On Thu, Jan 18, 2018 at 07:15:56PM -0500, Eric Sunshine wrote: >> On Thu, Jan 18, 2018 at 3:55 PM, Александр Булаев >> wrote: >> > I found that git 2.16.0 segfaults on clone of

Re: git 2.16.0 segfaults on clone of specific repo

On Thu, Jan 18, 2018 at 07:15:56PM -0500, Eric Sunshine wrote: > [+cc:brian] > > On Thu, Jan 18, 2018 at 3:55 PM, Александр Булаев > wrote: > > I found that git 2.16.0 segfaults on clone of vim-colorschemes repo. > > > > (lldb) run > > Process 25643 launched:

Re: git 2.16.0 segfaults on clone of specific repo

[+cc:brian] On Thu, Jan 18, 2018 at 3:55 PM, Александр Булаев wrote: > I found that git 2.16.0 segfaults on clone of vim-colorschemes repo. > > (lldb) run > Process 25643 launched: '/usr/local/bin/git' (x86_64) > Cloning into 'vim-colorschemes'... > remote: Counting

RE: git 2.16.0 segfaults on clone of specific repo

On January 18, 2018 3:56 PM, Aleks wrote: > I found that git 2.16.0 segfaults on clone of vim-colorschemes repo. Just tested on NonStop NSE and works fine here. Just an FYI now that we're on 2.16.0. Cheers, Randall -- Brief whoami: NonStop developer since approximately

git 2.16.0 segfaults on clone of specific repo

I found that git 2.16.0 segfaults on clone of vim-colorschemes repo. See the log below. alexbool@alexbool-osx ~/Documents> lldb -- git clone https://github.com/flazz/vim-colorschemes.git (lldb) target create "git" Current executable set to 'git' (x86_64). (lldb) settings set -- target.run-args