Re: ref-filter: how to improve the code

On Thu, Mar 01, 2018 at 02:17:09PM +0300, Оля Тележная wrote: > >> I tried to replace all die("...") with `return error("...")` and > >> finally exit(), but actual problem is that we print "error:..." > >> instead of "fatal:...", and it looks funny. > > > > If you do that, then

Re: ref-filter: how to improve the code

2018-02-28 16:25 GMT+03:00 Jeff King : > On Sun, Feb 25, 2018 at 09:28:25PM +0300, Оля Тележная wrote: > >> I am trying to remove cat-file formatting part and reuse same >> functionality from ref-filter. >> I have a problem that cat-file sometimes needs to continue running >> even

Re: ref-filter: how to improve the code

On Sun, Feb 25, 2018 at 09:28:25PM +0300, Оля Тележная wrote: > I am trying to remove cat-file formatting part and reuse same > functionality from ref-filter. > I have a problem that cat-file sometimes needs to continue running > even if the request is broken, while in ref-filter we invoke die()

ref-filter: how to improve the code

Hi everyone, I am trying to remove cat-file formatting part and reuse same functionality from ref-filter. I have a problem that cat-file sometimes needs to continue running even if the request is broken, while in ref-filter we invoke die() in many places everywhere during formatting process. I