Gitweb:     
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e03ba84adb62fbc6049325a5bc00ef6932fa5e39
Commit:     e03ba84adb62fbc6049325a5bc00ef6932fa5e39
Parent:     67b4af297033f5f65999885542f95ba7b562848a
Author:     Pablo Neira Ayuso <[EMAIL PROTECTED]>
AuthorDate: Sat Dec 1 00:03:52 2007 +1100
Committer:  Herbert Xu <[EMAIL PROTECTED]>
CommitDate: Sat Dec 1 00:03:52 2007 +1100

    [TEXTSEARCH]: Do not allow zero length patterns in the textsearch 
infrastructure
    
    If a zero length pattern is passed then return EINVAL.
    Avoids infinite loops (bm) or invalid memory accesses (kmp).
    
    Signed-off-by: Pablo Neira Ayuso <[EMAIL PROTECTED]>
    Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
    Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
---
 lib/textsearch.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/textsearch.c b/lib/textsearch.c
index 88c98a2..be8bda3 100644
--- a/lib/textsearch.c
+++ b/lib/textsearch.c
@@ -7,7 +7,7 @@
  *             2 of the License, or (at your option) any later version.
  *
  * Authors:    Thomas Graf <[EMAIL PROTECTED]>
- *             Pablo Neira Ayuso <[EMAIL PROTECTED]>
+ *             Pablo Neira Ayuso <[EMAIL PROTECTED]>
  *
  * ==========================================================================
  *
@@ -250,7 +250,8 @@ unsigned int textsearch_find_continuous(struct ts_config 
*conf,
  *       the various search algorithms.
  *
  * Returns a new textsearch configuration according to the specified
- *         parameters or a ERR_PTR().
+ * parameters or a ERR_PTR(). If a zero length pattern is passed, this
+ * function returns EINVAL.
  */
 struct ts_config *textsearch_prepare(const char *algo, const void *pattern,
                                     unsigned int len, gfp_t gfp_mask, int 
flags)
@@ -259,6 +260,9 @@ struct ts_config *textsearch_prepare(const char *algo, 
const void *pattern,
        struct ts_config *conf;
        struct ts_ops *ops;
        
+       if (len == 0)
+               return ERR_PTR(-EINVAL);
+
        ops = lookup_ts_algo(algo);
 #ifdef CONFIG_KMOD
        /*
-
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to