BUG: On some Linux systems, "Stage To Commit" hotkey in git-gui stages one file only, even if multiple files are selected

2018-02-07 Thread Birger Skogeng Pedersen
In git-gui, multiple files from the "Unstaged Changes" widget can be selected. Once multiple files are selected, they can be staged by clicking (toolbar) "Commit"->"Stage To Commit". All the files that were selected then gets staged for the commit. The "Stage To Commit" hotkey (CTRL+T) behaves

git-gui, BUG: minimize/maximize buttons missing when repo is opened in gui

2018-02-20 Thread Birger Skogeng Pedersen
System: Ubuntu 17.10 Gnome When opening git-gui from a directory which is a repository, minimize and maximize buttons are showing and functional in git-gui. However, if I open git-gui in a non-repo directory, git-gui opens a dialog where I can "Create New Repository", "Clone Existing

git-gui, feature request: add hotkeys to focus different widgets

2018-02-20 Thread Birger Skogeng Pedersen
in git-gui, all without using the mouse. I propose that CTRL+(number) could be used as hotkeys to change the focus between the four widgets I've mentioned. Best regards, Birger Skogeng Pedersen

Re: [PATCH] git-gui: Add hotkeys to change focus between ui widgets

2018-02-23 Thread Birger Skogeng Pedersen
Hi, I've discovered a bug, I'll be sending a new version soon. br Birger On Fri, Feb 23, 2018 at 11:22 AM, Birger Skogeng Pedersen <birge...@gmail.com> wrote: > The user cannot change focus between the list of files, the diff view > and the commit message widgets without usi

[PATCH] git-gui: Add hotkeys to change focus between ui widgets

2018-02-23 Thread Birger Skogeng Pedersen
quot;, the diff view or the commit message dialog widgets, respectively. This enables the user to select/unselect files, view the diff and create a commit in git-gui using keyboard-only. Signed-off-by: Birger Skogeng Pedersen <birge...@gmail.com> --- git-gui/git-gui.sh | 34

git-gui: CTRL/CMD + numpad ENTER does not invoke same command as "regular" ENTER

2018-03-01 Thread Birger Skogeng Pedersen
In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However, using the numpad ENTER does not invoke the same command. I propose that both numpad ENTER and "regular" ENTER should invoke the same command.

[PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit

2018-03-01 Thread Birger Skogeng Pedersen
--- git-gui/git-gui.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh index 91c00e648..6de74ce63 100755 --- a/git-gui/git-gui.sh +++ b/git-gui/git-gui.sh @@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break} bind .

Re: [PATCH] git-gui: Add hotkeys to change focus between ui widgets

2018-03-06 Thread Birger Skogeng Pedersen
ohannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Birger, > > On Wed, 28 Feb 2018, Birger Skogeng Pedersen wrote: > >> The user cannot change focus between the list of files, the diff view >> and the commit message widgets without using the mouse (clicking either of >

Re: [FEATURE] git-gui: Staging path(s) should re-select a new path in "Unstaged Changes"

2018-03-05 Thread Birger Skogeng Pedersen
My apologies. Seems there was some error causing this, I see now that paths are automatically re-selected by default. Can't reproduce the error. Please disregard this thread. Birger

[FEATURE] git-gui: Staging path(s) should re-select a new path in "Unstaged Changes"

2018-02-28 Thread Birger Skogeng Pedersen
When a path is selected in "Unstaged Changes", it can be staged (obviously). When it is staged, the path goes to the "Staged Changes" list, and no (new) path is selected. I propose that this action should re-select a new path, from the list of paths in "Unstaged Changes". Steps to reproduce (in

[PATCH] git-gui: Add hotkeys to change focus between ui widgets

2018-02-28 Thread Birger Skogeng Pedersen
quot;, the diff view or the commit message dialog widgets, respectively. This enables the user to select/unselect files, view the diff and create a commit in git-gui using keyboard-only. Signed-off-by: Birger Skogeng Pedersen <birge...@gmail.com> --- git-gui/git-gui.sh | 37 +++

Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit

2018-03-02 Thread Birger Skogeng Pedersen
Sorry about that. Version 2 coming right up. On Thu, Mar 1, 2018 at 7:31 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen > <birge...@gmail.com> wrote: >> --- > > Please sign-off on your patch. See D

[PATCH v2] git-gui: bind CTRL/CMD+numpad ENTER to do_commit

2018-03-02 Thread Birger Skogeng Pedersen
CTRL/CMD+ENTER is bound to do_commit, but this did not apply for the (numpad ENTER) key. To enable CTRL/CMD+ENTER and CTRL/CMD+(numpad ENTER) to yield the same behaviour, CTRL/CMD+(numpad enter) has also been bound to do_commit. Signed-off-by: Birger Skogeng Pedersen <birge...@gmail.com> --