Re: [PATCH v2 0/9] add --gpg-sign to rebase and pull
On Fri, 24 Jan 2014, brian m. carlson wrote: This series was posted to the list some time back, but it fell through the cracks. This is a re-send of Nicolas Vigier's work with an additional patch that adds --gpg-sign to pull as well. I added my sign-off to his patches because SubmittingPatches (section (c)) seems to imply that I should, although I can rebase it out if it's a problem. Thanks! An improvement I was thinking to do on this series but had not time to do yet is to make the '--no-gpg-sign' option disable gpg signing when the commit.gpgsign config option is set to true. This would fix the problem mentioned about commit.gpgsign in What's cooking in git.git that the variable cannot be overriden from the command line of some of the commands that create commits. Nicolas -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/9] add --gpg-sign to rebase and pull
Nicolas Vigier bo...@mars-attacks.org writes: On Fri, 24 Jan 2014, brian m. carlson wrote: This series was posted to the list some time back, but it fell through the cracks. This is a re-send of Nicolas Vigier's work with an additional patch that adds --gpg-sign to pull as well. I added my sign-off to his patches because SubmittingPatches (section (c)) seems to imply that I should, although I can rebase it out if it's a problem. Thanks! An improvement I was thinking to do on this series but had not time to do yet is to make the '--no-gpg-sign' option disable gpg signing when the commit.gpgsign config option is set to true. By the way, a configuration variable that has no way of getting overriden per invocation should not exist without a very good reason (core.bare is an example of a exception with a good reason---the bareness of the repository does not change per command invocation). An escape hatch --no-gpg-sign is a must-have requirement, not a nice-to-have improvement. Thanks for not forgetting. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 0/9] add --gpg-sign to rebase and pull
This series was posted to the list some time back, but it fell through the cracks. This is a re-send of Nicolas Vigier's work with an additional patch that adds --gpg-sign to pull as well. I added my sign-off to his patches because SubmittingPatches (section (c)) seems to imply that I should, although I can rebase it out if it's a problem. I've been running with this patch set for some time now, and haven't found any issues, although I wouldn't recommend doing large rebases without a gpg-agent running. I'm happy to fix any issues that come up in order to move this series as expeditiously as possible, but seeing as I'm in San Francisco at the moment, re-rolls might be delayed through the next few days. Nicolas Vigier (8): cherry-pick, revert: add the --gpg-sign option git-sh-setup.sh: add variable to use the stuck-long mode am: parse options in stuck-long mode am: add the --gpg-sign option rebase: remove useless arguments check rebase: don't try to match -M option rebase: parse options in stuck-long mode rebase: add the --gpg-sign option brian m. carlson (1): pull: add the --gpg-sign option. Documentation/git-am.txt | 6 +++- Documentation/git-cherry-pick.txt | 7 - Documentation/git-rebase.txt | 4 +++ Documentation/git-revert.txt | 6 +++- builtin/revert.c | 2 ++ contrib/examples/git-checkout.sh | 1 + contrib/examples/git-clean.sh | 1 + contrib/examples/git-clone.sh | 1 + contrib/examples/git-merge.sh | 1 + contrib/examples/git-repack.sh| 1 + contrib/git-resurrect.sh | 1 + git-am.sh | 26 ++-- git-instaweb.sh | 1 + git-pull.sh | 13 +++- git-quiltimport.sh| 1 + git-rebase--am.sh | 8 +++-- git-rebase--interactive.sh| 32 git-rebase--merge.sh | 2 +- git-rebase.sh | 62 +-- git-request-pull.sh | 1 + git-sh-setup.sh | 2 ++ sequencer.c | 11 +++ sequencer.h | 2 ++ 23 files changed, 134 insertions(+), 58 deletions(-) -- 1.9.rc0.1002.gd081c64.dirty -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
