Re: [PATCH v3 2/2] Replace non-ASCII apostrophes to ASCII single quotes in gitsubmodules.txt

[Junio C Hamano]

marmot1123  writes:

> Before this patch, there are several non-ASCII apostrophes in
> gitsubmodules.txt, and misconverged at the 
> https://git-scm.com/docs/gitsubmodules/ .
> To make codes consistent, these non-ASCII apostrophes are replaced
> with ASCII single quotes.  This patch also makes the document readable
> on the website.
>
> Signed-off-by: Motoki Seki 
> ---

Interesting.  I didn't know the AsciiDoc renderer used there
mishandled these non-ASCII ticks.  Thanks for writing it down in the
log message.

When we say "there are ..." in a proposed commit log message
(i.e. in the present tense), it is the norm to talk about the
current state of affairs, so "Before this patch," is redundant.  I'd
drop it myself while queuing, and possibly applying other typofixes.

Thanks.


>  Documentation/gitsubmodules.txt | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt
> index 0d59ab4cdfb1c..030c974c25606 100644
> --- a/Documentation/gitsubmodules.txt
> +++ b/Documentation/gitsubmodules.txt
> @@ -132,27 +132,27 @@ using older versions of Git.
>  +
>  It is possible to construct these old form repositories manually.
>  +
> -When deinitialized or deleted (see below), the submodule’s Git
> +When deinitialized or deleted (see below), the submodule's Git
>  directory is automatically moved to `$GIT_DIR/modules//`
>  of the superproject.
>  
>   * Deinitialized submodule: A `gitlink`, and a `.gitmodules` entry,
> -but no submodule working directory. The submodule’s git directory
> +but no submodule working directory. The submodule's git directory
>  may be there as after deinitializing the git directory is kept around.
>  The directory which is supposed to be the working directory is empty instead.
>  +
>  A submodule can be deinitialized by running `git submodule deinit`.
>  Besides emptying the working directory, this command only modifies
> -the superproject’s `$GIT_DIR/config` file, so the superproject’s history
> +the superproject's `$GIT_DIR/config` file, so the superproject's history
>  is not affected. This can be undone using `git submodule init`.
>  
>   * Deleted submodule: A submodule can be deleted by running
>  `git rm  && git commit`. This can be undone
>  using `git revert`.
>  +
> -The deletion removes the superproject’s tracking data, which are
> +The deletion removes the superproject's tracking data, which are
>  both the `gitlink` entry and the section in the `.gitmodules` file.
> -The submodule’s working directory is removed from the file
> +The submodule's working directory is removed from the file
>  system, but the Git directory is kept around as it to make it
>  possible to checkout past commits without requiring fetching
>  from another repository.
>
> --
> https://github.com/git/git/pull/459

[PATCH v3 2/2] Replace non-ASCII apostrophes to ASCII single quotes in gitsubmodules.txt

[marmot1123]

Before this patch, there are several non-ASCII apostrophes in
gitsubmodules.txt, and misconverged at the 
https://git-scm.com/docs/gitsubmodules/ .
To make codes consistent, these non-ASCII apostrophes are replaced
with ASCII single quotes.  This patch also makes the document readable
on the website.

Signed-off-by: Motoki Seki 
---
 Documentation/gitsubmodules.txt | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/gitsubmodules.txt b/Documentation/gitsubmodules.txt
index 0d59ab4cdfb1c..030c974c25606 100644
--- a/Documentation/gitsubmodules.txt
+++ b/Documentation/gitsubmodules.txt
@@ -132,27 +132,27 @@ using older versions of Git.
 +
 It is possible to construct these old form repositories manually.
 +
-When deinitialized or deleted (see below), the submodule’s Git
+When deinitialized or deleted (see below), the submodule's Git
 directory is automatically moved to `$GIT_DIR/modules//`
 of the superproject.
 
  * Deinitialized submodule: A `gitlink`, and a `.gitmodules` entry,
-but no submodule working directory. The submodule’s git directory
+but no submodule working directory. The submodule's git directory
 may be there as after deinitializing the git directory is kept around.
 The directory which is supposed to be the working directory is empty instead.
 +
 A submodule can be deinitialized by running `git submodule deinit`.
 Besides emptying the working directory, this command only modifies
-the superproject’s `$GIT_DIR/config` file, so the superproject’s history
+the superproject's `$GIT_DIR/config` file, so the superproject's history
 is not affected. This can be undone using `git submodule init`.
 
  * Deleted submodule: A submodule can be deleted by running
 `git rm  && git commit`. This can be undone
 using `git revert`.
 +
-The deletion removes the superproject’s tracking data, which are
+The deletion removes the superproject's tracking data, which are
 both the `gitlink` entry and the section in the `.gitmodules` file.
-The submodule’s working directory is removed from the file
+The submodule's working directory is removed from the file
 system, but the Git directory is kept around as it to make it
 possible to checkout past commits without requiring fetching
 from another repository.

--
https://github.com/git/git/pull/459