Re: [PATCH] Fix misconversion of gitsubmodule.txt

2018-02-20 Thread brian m. carlson 
On Tue, Feb 20, 2018 at 08:51:46AM +, marmot1123 wrote:
> In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions 
> `submodule’s`.
> It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.

While I agree consistency is good, does this have any effect on the
output?  I think AsciiDoc (and Asciidoctor) produce the non-ASCII
format for output, so this should be a no-op for all known output
formats.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204


signature.asc
Description: PGP signature

Re: [PATCH] Fix misconversion of gitsubmodule.txt

2018-02-20 Thread Eric Sunshine 
On Tue, Feb 20, 2018 at 3:51 AM, marmot1123  wrote:
> In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions 
> `submodule’s`.
> It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.

Thanks for the contribution. Please sign-off your patch; see
Documentation/SubmittingPatches.