Re: [PATCH 1/1] git-p4: add unshelve command

On 13 May 2018 at 14:52, Merland Romain wrote: > Hello Luke, > > Very interseting > This is indeed an option we are waiting since the introduction of option > --shelve for git p4 submit > What I like most in your approach is the preservation of link to p4/master > inducing

Re: [PATCH 1/1] git-p4: add unshelve command

On Fri, Feb 23, 2018 at 6:22 PM, Luke Diamand wrote: > On 22 February 2018 at 22:28, Luke Diamand wrote: >> On 22 February 2018 at 21:39, Miguel Torroja >> wrote: >>> Hi Luke, >>> >>> I really like the idea of creating a branch

Re: [PATCH 1/1] git-p4: add unshelve command

On 22 February 2018 at 22:28, Luke Diamand wrote: > On 22 February 2018 at 21:39, Miguel Torroja wrote: >> Hi Luke, >> >> I really like the idea of creating a branch based on a shelved CL (We >> particularly use shelves all the time), I tested your

Re: [PATCH 1/1] git-p4: add unshelve command

On 22 February 2018 at 21:39, Miguel Torroja wrote: > Hi Luke, > > I really like the idea of creating a branch based on a shelved CL (We > particularly use shelves all the time), I tested your change and I > have some comments. > > - I have some concerns about having

Re: [PATCH 1/1] git-p4: add unshelve command

Hi Luke, I really like the idea of creating a branch based on a shelved CL (We particularly use shelves all the time), I tested your change and I have some comments. - I have some concerns about having the same "[git-p4...change = .]" as if it were a real submitted CL. One use case I