Re: [PATCH v2] Fix misconversion of gitsubmodule.txt

2018-02-20 Thread Junio C Hamano
Todd Zullinger writes: > If replacing the non-ASCI apostrophes is the goal, aren't > there a number of others in the same file worth cleaning up > at the same time? > > $ grep '’' Documentation/gitsubmodules.txt > the submodule’s working directory pointing to (i). > superproject

Re: [PATCH v2] Fix misconversion of gitsubmodule.txt

2018-02-20 Thread Stefan Beller
On Tue, Feb 20, 2018 at 11:36 AM, Kaartic Sivaraam wrote: > Hi, > > On Wednesday 21 February 2018 12:20 AM, Stefan Beller wrote: >> Kaartic was the last to touch that file, >> (as found via git log origin/master -- Documentation/gitsubmodules.txt), >> sorry I did not

Re: [PATCH v2] Fix misconversion of gitsubmodule.txt

2018-02-20 Thread Todd Zullinger
Hi, marmot1123 wrote: > In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions > `submodule’s`. > It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes. If replacing the non-ASCI apostrophes is the goal, aren't there a number of others in the same file worth cleaning up

Re: [PATCH v2] Fix misconversion of gitsubmodule.txt

2018-02-20 Thread Kaartic Sivaraam
Hi, On Wednesday 21 February 2018 12:20 AM, Stefan Beller wrote: > Kaartic was the last to touch that file, > (as found via git log origin/master -- Documentation/gitsubmodules.txt), > sorry I did not find this in the review. > "Non-ASCII characters" made me dig into to this a little deeper as

Re: [PATCH v2] Fix misconversion of gitsubmodule.txt

2018-02-20 Thread Stefan Beller
Kaartic was the last to touch that file, (as found via git log origin/master -- Documentation/gitsubmodules.txt), sorry I did not find this in the review. Thanks for the patch! Stefan On Tue, Feb 20, 2018 at 3:48 AM, marmot1123 wrote: > In the 2nd and 4th paragraph of