franz1981 commented on a change in pull request #2793: ARTEMIS-2452 group-name
ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314213953
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ha/ColocatedHAManager.java
##########
@@ -163,6 +174,23 @@ private synchronized boolean
activateSharedStoreBackup(String journalDirectory,
return true;
}
+ private TopologyMember validateBackupGroupName(SimpleString nodeID) {
+ // Older versions of artemis don't send the nodeID in
BackupRequestMessage:
+ // in this case we cannot trust the request, making the requesting server
Review comment:
It was working fine because you haven't had any other member of topology
with a group name and been lucky, I believe :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
