[GitHub] [activemq-artemis] jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface

2019-08-15 Thread GitBox
jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-521689923 I think what you wrote looks good. I wouldn't go as far as saying that using a `ThreadLocal` is a *good* idea, but

[GitHub] [activemq-artemis] jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface

2019-08-13 Thread GitBox
jbertram commented on issue #2792: NO-JIRA: Javadoc for ActiveMQServerMessagePlugin interface URL: https://github.com/apache/activemq-artemis/pull/2792#issuecomment-520923490 I think this would be better in the User Guide rather than the JavaDoc for this class.