[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit

2019-08-15 Thread GitBox
cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-521632602 Hey I found that the provider sends transfer frames on a sender link as settled even when the link sender settled mode is Unsettled. This is against

[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit

2019-08-06 Thread GitBox
cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-518693552 > +1 from me more tests the better, just needs a jira, and squash commits Same +1 for me.

[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit

2019-07-29 Thread GitBox
cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-516028082 Improving integration tests is a great idea. For the changes to fix issue 1. I noticed that the closed callback for sessions does not remove the