[GitHub] [hive] jcamachor commented on issue #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on issue #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#issuecomment-540389710 @kgyrtkirk , I pushed a new commit containing only the range change and addressing your comments ; I will upload a follow-up for the timestamp column stats propagation in a new

[GitHub] [hive] ramesh0201 opened a new pull request #808: Decimal64 divsion

2019-10-09 Thread GitBox
ramesh0201 opened a new pull request #808: Decimal64 divsion URL: https://github.com/apache/hive/pull/808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hive] vineetgarg02 commented on a change in pull request #749: HIVE-21344

2019-10-09 Thread GitBox
vineetgarg02 commented on a change in pull request #749: HIVE-21344 URL: https://github.com/apache/hive/pull/749#discussion_r333172647 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java ## @@ -159,15 +165,36 @@ public void run()

[GitHub] [hive] vineetgarg02 commented on a change in pull request #749: HIVE-21344

2019-10-09 Thread GitBox
vineetgarg02 commented on a change in pull request #749: HIVE-21344 URL: https://github.com/apache/hive/pull/749#discussion_r33393 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -1612,6 +1612,150 @@ public Table apply(org.apache.hadoop.hiv

[GitHub] [hive] sankarh commented on a change in pull request #791: HIVE-21924

2019-10-09 Thread GitBox
sankarh commented on a change in pull request #791: HIVE-21924 URL: https://github.com/apache/hive/pull/791#discussion_r333131008 ## File path: ql/src/test/queries/clientpositive/file_with_header_footer_aggregation.q ## @@ -0,0 +1,94 @@ +set hive.mapred.mode=nonstrict; + +

[GitHub] [hive] mustafaiman commented on a change in pull request #791: HIVE-21924

2019-10-09 Thread GitBox
mustafaiman commented on a change in pull request #791: HIVE-21924 URL: https://github.com/apache/hive/pull/791#discussion_r333113836 ## File path: ql/src/test/queries/clientpositive/file_with_header_footer_aggregation.q ## @@ -0,0 +1,94 @@ +set hive.mapred.mode=nonstrict;

[GitHub] [hive] sankarh commented on a change in pull request #791: HIVE-21924

2019-10-09 Thread GitBox
sankarh commented on a change in pull request #791: HIVE-21924 URL: https://github.com/apache/hive/pull/791#discussion_r333102646 ## File path: ql/src/test/queries/clientpositive/file_with_header_footer_aggregation.q ## @@ -0,0 +1,94 @@ +set hive.mapred.mode=nonstrict; + +

[GitHub] [hive] sankarh commented on a change in pull request #791: HIVE-21924

2019-10-09 Thread GitBox
sankarh commented on a change in pull request #791: HIVE-21924 URL: https://github.com/apache/hive/pull/791#discussion_r333102183 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/SkippingTextInputFormat.java ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [hive] sankarh commented on a change in pull request #791: HIVE-21924

2019-10-09 Thread GitBox
sankarh commented on a change in pull request #791: HIVE-21924 URL: https://github.com/apache/hive/pull/791#discussion_r333101701 ## File path: ql/src/test/queries/clientpositive/file_with_header_footer_aggregation.q ## @@ -0,0 +1,94 @@ +set hive.mapred.mode=nonstrict; + +

[GitHub] [hive] xhumanoid opened a new pull request #807: HIVE-19261: Avro SerDe's InstanceCache should not be synchronized on retrieve

2019-10-09 Thread GitBox
xhumanoid opened a new pull request #807: HIVE-19261: Avro SerDe's InstanceCache should not be synchronized on retrieve URL: https://github.com/apache/hive/pull/807 Remove synchronization on cache retrieve have big performance impact will be great to have in branch-3 also --

[GitHub] [hive] sankarh commented on a change in pull request #791: HIVE-21924

2019-10-09 Thread GitBox
sankarh commented on a change in pull request #791: HIVE-21924 URL: https://github.com/apache/hive/pull/791#discussion_r333100958 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/SkippingTextInputFormat.java ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [hive] sankarh commented on a change in pull request #791: HIVE-21924

2019-10-09 Thread GitBox
sankarh commented on a change in pull request #791: HIVE-21924 URL: https://github.com/apache/hive/pull/791#discussion_r333100647 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/SkippingTextInputFormat.java ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [hive] sankarh commented on a change in pull request #791: HIVE-21924

2019-10-09 Thread GitBox
sankarh commented on a change in pull request #791: HIVE-21924 URL: https://github.com/apache/hive/pull/791#discussion_r333100168 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/SkippingTextInputFormat.java ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [hive] ashutosh-bapat opened a new pull request #806: HIVE-22313 : Some of the HMS auth LDAP hive config names do not start with "hive."

2019-10-09 Thread GitBox
ashutosh-bapat opened a new pull request #806: HIVE-22313 : Some of the HMS auth LDAP hive config names do not start with "hive." URL: https://github.com/apache/hive/pull/806 @maheshk114 , can you please review the change? Th

[GitHub] [hive] jcamachor commented on a change in pull request #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on a change in pull request #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#discussion_r333070056 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java ## @@ -967,13 +979,23 @@ private lo

[GitHub] [hive] dlavati opened a new pull request #805: HIVE-22308 Add missing support of Azure Blobstore schemes

2019-10-09 Thread GitBox
dlavati opened a new pull request #805: HIVE-22308 Add missing support of Azure Blobstore schemes URL: https://github.com/apache/hive/pull/805 Change-Id: I5e2fe35e5cb3118fe49c2ac3eb27bd185ea7de2a This is an automated message

[GitHub] [hive] jcamachor commented on a change in pull request #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on a change in pull request #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#discussion_r333032465 ## File path: ql/src/test/results/clientpositive/llap/subquery_select.q.out ## @@ -3918,14 +3918,14 @@ STAGE PLANS: Statist

[GitHub] [hive] jcamachor commented on a change in pull request #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on a change in pull request #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#discussion_r333003637 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -856,8 +856,15 @@ public static ColStatistics getColStatistic

[GitHub] [hive] miklosgergely closed pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception

2019-10-09 Thread GitBox
miklosgergely closed pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception URL: https://github.com/apache/hive/pull/784 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hive] jcamachor commented on a change in pull request #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on a change in pull request #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#discussion_r332980654 ## File path: ql/src/test/results/clientpositive/llap/retry_failure_stat_changes.q.out ## @@ -139,25 +139,25 @@ Stage-0 PARTITION_

[GitHub] [hive] jcamachor commented on a change in pull request #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on a change in pull request #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#discussion_r332994124 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/TimestampColumnStatsAggregator.java

[GitHub] [hive] jcamachor commented on a change in pull request #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on a change in pull request #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#discussion_r332991505 ## File path: standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift ## @@ -562,14 +562,27 @@ struct DateColumnStatsData

[GitHub] [hive] jcamachor commented on a change in pull request #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on a change in pull request #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#discussion_r332979645 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -856,8 +856,15 @@ public static ColStatistics getColStatistic

[GitHub] [hive] jcamachor commented on a change in pull request #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on a change in pull request #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#discussion_r332980654 ## File path: ql/src/test/results/clientpositive/llap/retry_failure_stat_changes.q.out ## @@ -139,25 +139,25 @@ Stage-0 PARTITION_

[GitHub] [hive] jcamachor commented on a change in pull request #787: HIVE-22239

2019-10-09 Thread GitBox
jcamachor commented on a change in pull request #787: HIVE-22239 URL: https://github.com/apache/hive/pull/787#discussion_r332979645 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -856,8 +856,15 @@ public static ColStatistics getColStatistic

[GitHub] [hive] asfgit closed pull request #804: HIVE-22305: Add the kudu-handler to the packaging module

2019-10-09 Thread GitBox
asfgit closed pull request #804: HIVE-22305: Add the kudu-handler to the packaging module URL: https://github.com/apache/hive/pull/804 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [hive] kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception

2019-10-09 Thread GitBox
kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception URL: https://github.com/apache/hive/pull/784#discussion_r332941305 ## File path: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java ###

[GitHub] [hive] kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception

2019-10-09 Thread GitBox
kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception URL: https://github.com/apache/hive/pull/784#discussion_r332935605 ## File path: ql/src/java/org/apache/hadoop/hive/ql/DriverState.java ## @@ -86,16 +86,35

[GitHub] [hive] kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception

2019-10-09 Thread GitBox
kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception URL: https://github.com/apache/hive/pull/784#discussion_r332941127 ## File path: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java ###

[GitHub] [hive] kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception

2019-10-09 Thread GitBox
kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception URL: https://github.com/apache/hive/pull/784#discussion_r332941943 ## File path: ql/src/java/org/apache/hadoop/hive/ql/DriverUtils.java ## @@ -51,10 +51,11

[GitHub] [hive] kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception

2019-10-09 Thread GitBox
kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception URL: https://github.com/apache/hive/pull/784#discussion_r332942091 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java ##

[GitHub] [hive] kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception

2019-10-09 Thread GitBox
kgyrtkirk commented on a change in pull request #784: HIVE-22235 CommandProcessorResponse should not be an exception URL: https://github.com/apache/hive/pull/784#discussion_r332942002 ## File path: ql/src/java/org/apache/hadoop/hive/ql/DriverUtils.java ## @@ -51,10 +51,11