[GitHub] [hive] dddddai edited a comment on pull request #1246: HIVE-23839: Use LongAdder instead of AtomicLong

dai edited a comment on pull request #1246: URL: https://github.com/apache/hive/pull/1246#issuecomment-657601071 @belugabehr Thank you for pointing that out. If we need to use methods like `compareAndSet(a,b)` and `incrementAndGet()` (the return value is not ignored), then AtomicLon

[GitHub] [hive] dengzhhu653 commented on a change in pull request #1197: HIVE-23793: Review of QueryInfo Class

dengzhhu653 commented on a change in pull request #1197: URL: https://github.com/apache/hive/pull/1197#discussion_r454735696 ## File path: ql/src/java/org/apache/hadoop/hive/ql/QueryInfo.java ## @@ -70,36 +80,57 @@ public String getExecutionEngine() { return executionEngin

[GitHub] [hive] vineetgarg02 merged pull request #1231: HIVE-23822 Sorted dynamic partition optimization could remove auto stat task

vineetgarg02 merged pull request #1231: URL: https://github.com/apache/hive/pull/1231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hive] dengzhhu653 commented on pull request #1205: HIVE-23800: Add hooks when HiveServer2 stops due to OutOfMemoryError

dengzhhu653 commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-658484942 > when I was using some of these hooks earlier: they are too specific to some purpose. > right now the proposed callback is a {{Runnable}} ... which means you will have to c

[GitHub] [hive] github-actions[bot] commented on pull request #1020: HIVE-23477: [LLAP] mmap allocation interruptions fails to notify other threads

github-actions[bot] commented on pull request #1020: URL: https://github.com/apache/hive/pull/1020#issuecomment-658479205 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach o

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1231: HIVE-23822 Sorted dynamic partition optimization could remove auto stat task

vineetgarg02 commented on a change in pull request #1231: URL: https://github.com/apache/hive/pull/1231#discussion_r454645150 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java ## @@ -409,26 +409,54 @@ private boolean removeRSInsert

[GitHub] [hive] vineetgarg02 merged pull request #1234: HIVE-23807 Wrong results with vectorization enabled

vineetgarg02 merged pull request #1234: URL: https://github.com/apache/hive/pull/1234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hive] xiaomengzhang closed pull request #1213: HIVE-23765: Use ORC file format by default when creating transactiona…

xiaomengzhang closed pull request #1213: URL: https://github.com/apache/hive/pull/1213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] belugabehr commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

belugabehr commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454618095 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hive] pvary commented on a change in pull request #1251: HIVE-23840: Use LLAP to get orc metadata

pvary commented on a change in pull request #1251: URL: https://github.com/apache/hive/pull/1251#discussion_r454603042 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -1562,20 +1580,31 @@ public int compareTo(CompressedOwid

[GitHub] [hive] pvary commented on a change in pull request #1251: HIVE-23840: Use LLAP to get orc metadata

pvary commented on a change in pull request #1251: URL: https://github.com/apache/hive/pull/1251#discussion_r454602904 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -129,6 +137,16 @@ */ private SearchArgument delet

[GitHub] [hive] pvary commented on a change in pull request #1251: HIVE-23840: Use LLAP to get orc metadata

pvary commented on a change in pull request #1251: URL: https://github.com/apache/hive/pull/1251#discussion_r454602727 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -232,6 +250,17 @@ private VectorizedOrcAcidRowBatchReade

[GitHub] [hive] belugabehr commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

belugabehr commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454590457 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hive] belugabehr commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

belugabehr commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454589888 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hive] belugabehr commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

belugabehr commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454589304 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hive] HunterL commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

HunterL commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454588109 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [hive] HunterL commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

HunterL commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454580133 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [hive] HunterL commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

HunterL commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454580408 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [hive] HunterL commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

HunterL commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454553580 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [hive] HunterL commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

HunterL commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454551180 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [hive] belugabehr commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

belugabehr commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454541905 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hive] belugabehr commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

belugabehr commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454541362 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hive] belugabehr commented on a change in pull request #1169: HIVE-20447: Add JSON Output Format to beeline

belugabehr commented on a change in pull request #1169: URL: https://github.com/apache/hive/pull/1169#discussion_r454539338 ## File path: beeline/src/java/org/apache/hive/beeline/JSONOutputFormat.java ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hive] vihangk1 commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

vihangk1 commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r453805922 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3580,7 +3596,17 @@ public boolean dropPartition(String dbName, String tableNa

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1231: HIVE-23822 Sorted dynamic partition optimization could remove auto stat task

vineetgarg02 commented on a change in pull request #1231: URL: https://github.com/apache/hive/pull/1231#discussion_r454511428 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java ## @@ -409,26 +409,54 @@ private boolean removeRSInsert

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1231: HIVE-23822 Sorted dynamic partition optimization could remove auto stat task

vineetgarg02 commented on a change in pull request #1231: URL: https://github.com/apache/hive/pull/1231#discussion_r454511428 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java ## @@ -409,26 +409,54 @@ private boolean removeRSInsert

[GitHub] [hive] jcamachor commented on a change in pull request #1231: HIVE-23822 Sorted dynamic partition optimization could remove auto stat task

jcamachor commented on a change in pull request #1231: URL: https://github.com/apache/hive/pull/1231#discussion_r454464296 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java ## @@ -409,26 +409,54 @@ private boolean removeRSInsertedB

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1231: HIVE-23822 Sorted dynamic partition optimization could remove auto stat task

vineetgarg02 commented on a change in pull request #1231: URL: https://github.com/apache/hive/pull/1231#discussion_r454462383 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java ## @@ -409,26 +409,54 @@ private boolean removeRSInsert

[GitHub] [hive] belugabehr commented on pull request #1088: HIVE-23673: Maven Standard Directories for accumulo-handler

belugabehr commented on pull request #1088: URL: https://github.com/apache/hive/pull/1088#issuecomment-658227935 @nrg4878 Can you please take a look at this? Trivial change but lots of files affected since it's just moving them into a new directory. Thanks. -

[GitHub] [hive] deniskuzZ merged pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

deniskuzZ merged pull request #1087: URL: https://github.com/apache/hive/pull/1087 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] szlta commented on a change in pull request #1251: HIVE-23840: Use LLAP to get orc metadata

szlta commented on a change in pull request #1251: URL: https://github.com/apache/hive/pull/1251#discussion_r454393621 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -129,6 +137,16 @@ */ private SearchArgument delet

[GitHub] [hive] belugabehr closed pull request #1118: HIVE-23363: Upgrade DataNucleus dependency to 5.2

belugabehr closed pull request #1118: URL: https://github.com/apache/hive/pull/1118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] belugabehr commented on pull request #1118: HIVE-23363: Upgrade DataNucleus dependency to 5.2

belugabehr commented on pull request #1118: URL: https://github.com/apache/hive/pull/1118#issuecomment-658213248 Complete and merged through manual patch process https://issues.apache.org/jira/browse/HIVE-23363 This i

[GitHub] [hive] belugabehr commented on a change in pull request #1197: HIVE-23793: Review of QueryInfo Class

belugabehr commented on a change in pull request #1197: URL: https://github.com/apache/hive/pull/1197#discussion_r454391934 ## File path: ql/src/java/org/apache/hadoop/hive/ql/QueryInfo.java ## @@ -17,48 +17,58 @@ */ package org.apache.hadoop.hive.ql; +import java.util.con

[GitHub] [hive] szlta commented on a change in pull request #1251: HIVE-23840: Use LLAP to get orc metadata

szlta commented on a change in pull request #1251: URL: https://github.com/apache/hive/pull/1251#discussion_r454390429 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ## @@ -232,6 +250,17 @@ private VectorizedOrcAcidRowBatchReade

[GitHub] [hive] belugabehr closed pull request #1197: HIVE-23793: Review of QueryInfo Class

belugabehr closed pull request #1197: URL: https://github.com/apache/hive/pull/1197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1250: HIVE-23843: Improve key evictions in VectorGroupByOperator

kgyrtkirk commented on a change in pull request #1250: URL: https://github.com/apache/hive/pull/1250#discussion_r454349711 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java ## @@ -358,6 +360,34 @@ public void close(boolean aborted) thro

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1250: HIVE-23843: Improve key evictions in VectorGroupByOperator

kgyrtkirk commented on a change in pull request #1250: URL: https://github.com/apache/hive/pull/1250#discussion_r454341433 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java ## @@ -358,6 +360,34 @@ public void close(boolean aborted) thro

[GitHub] [hive] deniskuzZ merged pull request #1243: HIVE-23832: Compaction cleaner fails to clean up deltas when using bl…

deniskuzZ merged pull request #1243: URL: https://github.com/apache/hive/pull/1243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] pvary opened a new pull request #1251: HIVE-23840: Use LLAP to get orc metadata

pvary opened a new pull request #1251: URL: https://github.com/apache/hive/pull/1251 Started to use new LLAP getOrcTailFromCache Refactored stuff to use the tail instead of the reader related things Added some unit tests for the new smaller components

[GitHub] [hive] shameersss1 edited a comment on pull request #1195: HIVE-23737: Reuse dagDelete Feature Of Tez Custom Shuffle Handler Instead Of LLAP's dagDelete

shameersss1 edited a comment on pull request #1195: URL: https://github.com/apache/hive/pull/1195#issuecomment-657450269 @t3rmin4t0r @prasanthj @b-slim Could you please take a review the PR? This is an automated message fro

[GitHub] [hive] pvary merged pull request #1238: HIVE-23824

pvary merged pull request #1238: URL: https://github.com/apache/hive/pull/1238 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s