[GitHub] [hive] shameersss1 commented on a change in pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-09-09 Thread GitBox
shameersss1 commented on a change in pull request #1271: URL: https://github.com/apache/hive/pull/1271#discussion_r485393494 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MsckPartitionExpressionProxy.java ## @@ -1,114 +0,0 @

[GitHub] [hive] shameersss1 commented on a change in pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-09-09 Thread GitBox
shameersss1 commented on a change in pull request #1271: URL: https://github.com/apache/hive/pull/1271#discussion_r485393860 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MsckPartitionExpressionProxy.java ## @@ -1,114 +0,0 @

[GitHub] [hive] pvargacl commented on pull request #1474: Revert "HIVE-23725: ValidTxnManager snapshot outdating causing partia…

2020-09-09 Thread GitBox
pvargacl commented on pull request #1474: URL: https://github.com/apache/hive/pull/1474#issuecomment-689367884 LGTM +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hive] deniskuzZ commented on pull request #1220: HIVE-23413: Create a new config to skip all locks

2020-09-09 Thread GitBox
deniskuzZ commented on pull request #1220: URL: https://github.com/apache/hive/pull/1220#issuecomment-689372016 Checked, however I'm not sure if it is a good idea to give the end user the option to completely disable the locking. They could end up shooting themselves in the foot. F

[GitHub] [hive] aasha commented on a change in pull request #1477: HIVE-24131 Use original src location always when data copy runs on ta…

2020-09-09 Thread GitBox
aasha commented on a change in pull request #1477: URL: https://github.com/apache/hive/pull/1477#discussion_r485347419 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java ## @@ -73,21 +73,16 @@ public CopyUtils(String distCpDoAsUser, HiveConf hiveConf,

[GitHub] [hive] kgyrtkirk commented on pull request #1432: HIVE-24072 HiveAggregateJoinTransposeRule may try to create an invalid transformation

2020-09-09 Thread GitBox
kgyrtkirk commented on pull request #1432: URL: https://github.com/apache/hive/pull/1432#issuecomment-689416076 > I assume the test that would hit this problem is part of [HIVE-24084](https://issues.apache.org/jira/browse/HIVE-24084)? Otherwise, it would be useful to add a test case here.

[GitHub] [hive] kgyrtkirk merged pull request #1432: HIVE-24072 HiveAggregateJoinTransposeRule may try to create an invalid transformation

2020-09-09 Thread GitBox
kgyrtkirk merged pull request #1432: URL: https://github.com/apache/hive/pull/1432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] aasha opened a new pull request #1480: HIVE-24134 : Revert removal of HiveStrictManagedMigration code

2020-09-09 Thread GitBox
aasha opened a new pull request #1480: URL: https://github.com/apache/hive/pull/1480 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this

[GitHub] [hive] pvary commented on pull request #1220: HIVE-23413: Create a new config to skip all locks

2020-09-09 Thread GitBox
pvary commented on pull request #1220: URL: https://github.com/apache/hive/pull/1220#issuecomment-689452296 > Checked, however I'm not sure if it is a good idea to give the end user the option to completely disable the locking. They could end up shooting themselves in the foot. Admi

[GitHub] [hive] deniskuzZ merged pull request #1474: Revert "HIVE-23725: ValidTxnManager snapshot outdating causing partia…

2020-09-09 Thread GitBox
deniskuzZ merged pull request #1474: URL: https://github.com/apache/hive/pull/1474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] szlta merged pull request #1480: HIVE-24134 : Revert removal of HiveStrictManagedMigration code

2020-09-09 Thread GitBox
szlta merged pull request #1480: URL: https://github.com/apache/hive/pull/1480 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [hive] shameersss1 commented on a change in pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-09-09 Thread GitBox
shameersss1 commented on a change in pull request #1271: URL: https://github.com/apache/hive/pull/1271#discussion_r456500229 ## File path: ql/src/test/org/apache/hadoop/hive/ql/exec/TestPartitionManagement.java ## @@ -15,7 +15,7 @@ * See the License for the specific language

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-09-09 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-689608550 @kgyrtkirk I have changed the approach, Please take a look at the new implementation. This is an automated mes

[GitHub] [hive] mustafaiman opened a new pull request #1481: HIVE-24139: VectorGroupByOperator is not flushing hash table entries …

2020-09-09 Thread GitBox
mustafaiman opened a new pull request #1481: URL: https://github.com/apache/hive/pull/1481 …as needed Change-Id: Idf25882ac6bef0db63ce08f67e8abcbc9fc60712 ### What changes were proposed in this pull request? ### Why are the changes needed?

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1471: HIVE-23454 : Querying hive table which has Materialized view fails with HiveAccessControlException

2020-09-09 Thread GitBox
vineetgarg02 commented on a change in pull request #1471: URL: https://github.com/apache/hive/pull/1471#discussion_r485929257 ## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewUtils.java ## @@ -347,6 +355,38 @@ public static

[GitHub] [hive] vineetgarg02 commented on pull request #1471: HIVE-23454 : Querying hive table which has Materialized view fails with HiveAccessControlException

2020-09-09 Thread GitBox
vineetgarg02 commented on pull request #1471: URL: https://github.com/apache/hive/pull/1471#issuecomment-689828973 > We should probably create a follow-up JIRA to check authorization before triggering the rewriting algorithm. If the compilation overhead to check every MV that is applicable

[GitHub] [hive] sunchao commented on pull request #1398: HIVE-24035: Add Jenkinsfile for branch-2.3

2020-09-09 Thread GitBox
sunchao commented on pull request #1398: URL: https://github.com/apache/hive/pull/1398#issuecomment-689837266 @kgyrtkirk can you review this PR? I think this is ready now - I've tried a few times already and it can successfully run most test cases with a few hundreds failed ones, which is

[GitHub] [hive] jcamachor merged pull request #1399: HIVE-24036: Kryo Exception while serializing plan for getSplits UDF call

2020-09-09 Thread GitBox
jcamachor merged pull request #1399: URL: https://github.com/apache/hive/pull/1399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] nrg4878 closed pull request #1473: HIVE-23387 (Same as PR 1435 + fix for tests)

2020-09-09 Thread GitBox
nrg4878 closed pull request #1473: URL: https://github.com/apache/hive/pull/1473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] nrg4878 closed pull request #1435: Hive 23387 (same as PR 1116)

2020-09-09 Thread GitBox
nrg4878 closed pull request #1435: URL: https://github.com/apache/hive/pull/1435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the