[GitHub] [hive] mustafaiman commented on a change in pull request #1701: HIVE-24415: HiveSplitGenerator blocks Tez dispatcher

mustafaiman commented on a change in pull request #1701: URL: https://github.com/apache/hive/pull/1701#discussion_r551767994 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java ## @@ -385,7 +387,11 @@ public HiveSplitGenerator(InputInitializerC

[GitHub] [hive] kasakrisz commented on a change in pull request #1810: HIVE-24565: Implement standard trim function

kasakrisz commented on a change in pull request #1810: URL: https://github.com/apache/hive/pull/1810#discussion_r551761602 ## File path: ql/src/test/queries/clientpositive/udf_trim.q ## @@ -1,2 +1,20 @@ DESCRIBE FUNCTION trim; DESCRIBE FUNCTION EXTENDED trim; + +SELECT '"' ||

[GitHub] [hive] mustafaiman commented on a change in pull request #1701: HIVE-24415: HiveSplitGenerator blocks Tez dispatcher

mustafaiman commented on a change in pull request #1701: URL: https://github.com/apache/hive/pull/1701#discussion_r551753955 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java ## @@ -100,37 +99,19 @@ private int sourceInfoCount = 0;

[GitHub] [hive] kasakrisz commented on a change in pull request #1772: HIVE-24519: Optimize MV: Materialized views should not rebuild when tables are not modified

kasakrisz commented on a change in pull request #1772: URL: https://github.com/apache/hive/pull/1772#discussion_r551752970 ## File path: ql/src/test/results/clientpositive/llap/materialized_view_rebuild_2.q.out ## @@ -0,0 +1,171 @@ +PREHOOK: query: create table t1(col0 int) st

[GitHub] [hive] mustafaiman commented on a change in pull request #1822: HIVE-24575: VectorGroupByOperator reusing keys can lead to wrong results

mustafaiman commented on a change in pull request #1822: URL: https://github.com/apache/hive/pull/1822#discussion_r551748072 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/wrapper/VectorHashKeyWrapperGeneral.java ## @@ -348,8 +348,8 @@ public void copyKey(KeyW

[GitHub] [hive] fsilent closed pull request #1816: HIVE-24570 Hive on spark tmp file should be delete when driver process finished

fsilent closed pull request #1816: URL: https://github.com/apache/hive/pull/1816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] sunchao commented on pull request #1806: HIVE-21737: Upgrade Avro to version 1.10.1

sunchao commented on pull request #1806: URL: https://github.com/apache/hive/pull/1806#issuecomment-754410212 I think we just need to verify that the combination of Hive 2.3.8/Parquet 1.11.1/Avro 1.10.1 works for Spark before sending out a vote. @heuermh have you got a chance to try it out

[GitHub] [hive] wangyum commented on pull request #1806: HIVE-21737: Upgrade Avro to version 1.10.1

wangyum commented on pull request #1806: URL: https://github.com/apache/hive/pull/1806#issuecomment-754407859 Any update? Spark community has created 3.1.0 RC1: https://github.com/apache/spark/releases/tag/v3.1.0-rc1 This is

[GitHub] [hive] nareshpr opened a new pull request #1825: HIVE-24523: Vectorized read path for LazySimpleSerde does not honor the SERDEPROPERTIES for timestamp

nareshpr opened a new pull request #1825: URL: https://github.com/apache/hive/pull/1825 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] github-actions[bot] commented on pull request #1638: HIVE-22307: Upgrade Hadoop version to 3.1.3

github-actions[bot] commented on pull request #1638: URL: https://github.com/apache/hive/pull/1638#issuecomment-754321290 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach o

[GitHub] [hive] belugabehr merged pull request #1807: HIVE-24560: Move Logging and Column Name,Type Parsing to AbstractSerd…

belugabehr merged pull request #1807: URL: https://github.com/apache/hive/pull/1807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] ramesh0201 commented on a change in pull request #1701: HIVE-24415: HiveSplitGenerator blocks Tez dispatcher

ramesh0201 commented on a change in pull request #1701: URL: https://github.com/apache/hive/pull/1701#discussion_r551551287 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java ## @@ -385,7 +387,11 @@ public HiveSplitGenerator(InputInitializerCo

[GitHub] [hive] ramesh0201 commented on a change in pull request #1701: HIVE-24415: HiveSplitGenerator blocks Tez dispatcher

ramesh0201 commented on a change in pull request #1701: URL: https://github.com/apache/hive/pull/1701#discussion_r551546406 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java ## @@ -100,37 +99,19 @@ private int sourceInfoCount = 0;

[GitHub] [hive] pgaref commented on pull request #1823: HIVE-23553: Upgrade ORC version to 1.6.6

pgaref commented on pull request #1823: URL: https://github.com/apache/hive/pull/1823#issuecomment-754115075 > its better to not use intermediate artifacts; snapshots doesnt play well with reproducible builds - if you just want to do a pre-flight check for the next orc version that could b

[GitHub] [hive] ashutoshc commented on pull request #1746: HIVE-24491 : setting custom job name is ineffective if the tez session pool is configured or in case of session reuse.

ashutoshc commented on pull request #1746: URL: https://github.com/apache/hive/pull/1746#issuecomment-754087949 +1 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [hive] kasakrisz merged pull request #1782: HIVE-24434: Filter out materialized views for rewriting if plan pattern is not allowed

kasakrisz merged pull request #1782: URL: https://github.com/apache/hive/pull/1782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] yongzhi merged pull request #1802: HIVE-24552: Possible HMS connections leak or accumulation in loadDyna…

yongzhi merged pull request #1802: URL: https://github.com/apache/hive/pull/1802 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] marton-bod commented on a change in pull request #1797: HIVE-24541: add config option for default storage handler class

marton-bod commented on a change in pull request #1797: URL: https://github.com/apache/hive/pull/1797#discussion_r551357048 ## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ## @@ -1991,6 +1991,10 @@ private static void populateLlapDaemonVarsSet(Set llapD

[GitHub] [hive] marton-bod commented on a change in pull request #1797: HIVE-24541: add config option for default storage handler class

marton-bod commented on a change in pull request #1797: URL: https://github.com/apache/hive/pull/1797#discussion_r551356985 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java ## @@ -69,6 +69,12 @@ public boolean fillStorageFormat(ASTNode child) throws

[GitHub] [hive] zzccctv closed pull request #1819: HIVE-24571: Redundant code in SemanticAnalyzer.java file

zzccctv closed pull request #1819: URL: https://github.com/apache/hive/pull/1819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] pvary commented on a change in pull request #1797: HIVE-24541: add config option for default storage handler class

pvary commented on a change in pull request #1797: URL: https://github.com/apache/hive/pull/1797#discussion_r551331191 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java ## @@ -69,6 +69,12 @@ public boolean fillStorageFormat(ASTNode child) throws Sema

[GitHub] [hive] pvary commented on a change in pull request #1797: HIVE-24541: add config option for default storage handler class

pvary commented on a change in pull request #1797: URL: https://github.com/apache/hive/pull/1797#discussion_r551330709 ## File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ## @@ -1991,6 +1991,10 @@ private static void populateLlapDaemonVarsSet(Set llapDaemon

[GitHub] [hive] mustafaiman opened a new pull request #1824: HIVE-24510: Vectorize compute_bit_vector

mustafaiman opened a new pull request #1824: URL: https://github.com/apache/hive/pull/1824 I organized this pull request in 3 commits for ease of review. First commit adds a test that prints hex(compute_bit_vector(col)) for some tables. So we can use that as the source of truth for testi

[GitHub] [hive] mustafaiman closed pull request #1764: HIVE-24510: Vectorize compute_bit_vector

mustafaiman closed pull request #1764: URL: https://github.com/apache/hive/pull/1764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] kgyrtkirk merged pull request #1770: HIVE-24571: Redundant code in SemanticAnalyzer.java file

kgyrtkirk merged pull request #1770: URL: https://github.com/apache/hive/pull/1770 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hive] kgyrtkirk commented on pull request #1823: HIVE-23553: Upgrade ORC version to 1.6.6

kgyrtkirk commented on pull request #1823: URL: https://github.com/apache/hive/pull/1823#issuecomment-753947139 its better to not use intermediate artifacts; snapshots doesnt play well with reproducible builds - if you just want to do a pre-flight check for the next orc version that could

[GitHub] [hive] pvargacl commented on a change in pull request #1795: HIVE-24550: Cleanup only transaction information for the current DriverContext

pvargacl commented on a change in pull request #1795: URL: https://github.com/apache/hive/pull/1795#discussion_r551277198 ## File path: ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java ## @@ -527,11 +527,15 @@ void release() { release(!hiveLocks.isEmpty()); }

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1810: [WIP] HIVE-24565: Implement standard trim function

kgyrtkirk commented on a change in pull request #1810: URL: https://github.com/apache/hive/pull/1810#discussion_r551257267 ## File path: ql/src/test/queries/clientpositive/udf_trim.q ## @@ -1,2 +1,20 @@ DESCRIBE FUNCTION trim; DESCRIBE FUNCTION EXTENDED trim; + +SELECT '"' ||

[GitHub] [hive] pvary commented on a change in pull request #1795: HIVE-24550: Cleanup only transaction information for the current DriverContext

pvary commented on a change in pull request #1795: URL: https://github.com/apache/hive/pull/1795#discussion_r551258899 ## File path: ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java ## @@ -527,11 +527,15 @@ void release() { release(!hiveLocks.isEmpty()); }

[GitHub] [hive] pvargacl commented on pull request #1795: HIVE-24550: Cleanup only transaction information for the current DriverContext

pvargacl commented on pull request #1795: URL: https://github.com/apache/hive/pull/1795#issuecomment-753899542 @pvary could you check if you like this quick solution? This is an automated message from the Apache Git Service.

[GitHub] [hive] klcopp merged pull request #1779: HIVE-24535: Cleanup AcidUtils.Directory and remove unnecessary filesystem listing

klcopp merged pull request #1779: URL: https://github.com/apache/hive/pull/1779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] klcopp commented on a change in pull request #1779: HIVE-24535: Cleanup AcidUtils.Directory and remove unnecessary filesystem listing

klcopp commented on a change in pull request #1779: URL: https://github.com/apache/hive/pull/1779#discussion_r551234416 ## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ## @@ -1316,7 +1282,7 @@ private Directory getAcidState() throws IOException {

[GitHub] [hive] kasakrisz commented on a change in pull request #1772: HIVE-24519: Optimize MV: Materialized views should not rebuild when tables are not modified

kasakrisz commented on a change in pull request #1772: URL: https://github.com/apache/hive/pull/1772#discussion_r551220628 ## File path: ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java ## @@ -120,6 +120,8 @@ new Privilege[]{Privilege.DROP}), ALTER_MATERI

[GitHub] [hive] kasakrisz commented on a change in pull request #1772: HIVE-24519: Optimize MV: Materialized views should not rebuild when tables are not modified

kasakrisz commented on a change in pull request #1772: URL: https://github.com/apache/hive/pull/1772#discussion_r551170582 ## File path: ql/src/test/results/clientpositive/llap/materialized_view_rebuild_2.q.out ## @@ -0,0 +1,171 @@ +PREHOOK: query: create table t1(col0 int) st