[GitHub] [hive] lcspinter merged pull request #3226: HIVE-26157: Change Iceberg storage handler authz URI to metadata location

2022-05-12 Thread GitBox
lcspinter merged PR #3226: URL: https://github.com/apache/hive/pull/3226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

[GitHub] [hive] ashish-kumar-sharma commented on pull request #3148: HIVE-26082: Upgrade DataNucleus dependency to 5.2.8

2022-05-12 Thread GitBox
ashish-kumar-sharma commented on PR #3148: URL: https://github.com/apache/hive/pull/3148#issuecomment-1125657111 @nrg4878 Could you please point me to metastore microbenchmarks tool. So that I can generate the performance number? -- This is an automated message from the Apache Git Servi

[GitHub] [hive] zhangbutao commented on pull request #3276: HIVE-26046: MySQL's bit datatype is default to void datatype in hive

2022-05-12 Thread GitBox
zhangbutao commented on PR #3276: URL: https://github.com/apache/hive/pull/3276#issuecomment-1125617331 @zabetak thx. I'll run a full test and try to fix this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hive] rbalamohan commented on pull request #2950: HIVE-25872: Skip tracking of alterDatabase events for replication specific properties

2022-05-12 Thread GitBox
rbalamohan commented on PR #2950: URL: https://github.com/apache/hive/pull/2950#issuecomment-1125581061 LGTM. +1 pending tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [hive] dengzhhu653 merged pull request #2378: HIVE-25230: Add position and occurrence to INSTR()

2022-05-12 Thread GitBox
dengzhhu653 merged PR #2378: URL: https://github.com/apache/hive/pull/2378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

[GitHub] [hive] rbalamohan commented on a diff in pull request #2950: HIVE-25872: Skip tracking of alterDatabase events for replication specific properties

2022-05-12 Thread GitBox
rbalamohan commented on code in PR #2950: URL: https://github.com/apache/hive/pull/2950#discussion_r871907679 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java: ## @@ -284,6 +285,19 @@ public static boolean checkIfD

[GitHub] [hive] rbalamohan commented on a diff in pull request #2950: HIVE-25872: Skip tracking of alterDatabase events for replication specific properties

2022-05-12 Thread GitBox
rbalamohan commented on code in PR #2950: URL: https://github.com/apache/hive/pull/2950#discussion_r871907679 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java: ## @@ -284,6 +285,19 @@ public static boolean checkIfD

[GitHub] [hive] sourabh912 commented on pull request #3233: HIVE-26071: JWT authentication mechanism for Thrift over HTTP in HiveMetastore

2022-05-12 Thread GitBox
sourabh912 commented on PR #3233: URL: https://github.com/apache/hive/pull/3233#issuecomment-1125314717 Thanks @nrg4878 @dengzhhu653 @saihemanth-cloudera @hsnusonic for the review and @yongzhi for the merge. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [hive] yongzhi merged pull request #3233: HIVE-26071: JWT authentication mechanism for Thrift over HTTP in HiveMetastore

2022-05-12 Thread GitBox
yongzhi merged PR #3233: URL: https://github.com/apache/hive/pull/3233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

[GitHub] [hive] wecharyu opened a new pull request, #3288: HIVE-26227: Add support of catalog related statements for Hive ql

2022-05-12 Thread GitBox
wecharyu opened a new pull request, #3288: URL: https://github.com/apache/hive/pull/3288 ### What changes were proposed in this pull request? Implement the ddl statements related to catalog, the statements can refer to [HIVE-26227](https://issues.apache.org/jira/browse/HIVE-26227).

[GitHub] [hive] zabetak commented on pull request #2490: HIVE-25335: Unreasonable setting reduce number, when join big size ta…

2022-05-12 Thread GitBox
zabetak commented on PR #2490: URL: https://github.com/apache/hive/pull/2490#issuecomment-1125059076 @zhengchenyu I don't think it's possible to reopen a closed PR. You can create a new one instead. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [hive] zabetak commented on pull request #3276: HIVE-26046: MySQL's bit datatype is default to void datatype in hive

2022-05-12 Thread GitBox
zabetak commented on PR #3276: URL: https://github.com/apache/hive/pull/3276#issuecomment-1125046939 @zhangbutao Instead of running the test individually try to run the whole split (`mvn -Pitests -Pqsplits test -Dtest=org.apache.hadoop.hive.cli.split6.TestMiniLlapLocalCliDriver`) locally.

[GitHub] [hive] pvary commented on pull request #3287: HIVE-26228: Implement Iceberg table rollback feature

2022-05-12 Thread GitBox
pvary commented on PR #3287: URL: https://github.com/apache/hive/pull/3287#issuecomment-1125031319 @lcspinter: Could we use a timestamp in the same format as we receive it back from the metadata table query, like `select * from default.table_to_rollback.history`? -- This is an automated

[GitHub] [hive] pvary merged pull request #3269: HIVE-26202: Refactor Iceberg Writers

2022-05-12 Thread GitBox
pvary merged PR #3269: URL: https://github.com/apache/hive/pull/3269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

[GitHub] [hive] lcspinter opened a new pull request, #3287: HIVE-26228: Implement Iceberg table rollback feature

2022-05-12 Thread GitBox
lcspinter opened a new pull request, #3287: URL: https://github.com/apache/hive/pull/3287 ### What changes were proposed in this pull request? Provide syntax support for iceberg table's rollback operation ### Why are the changes needed? Iceberg API already has a r

[GitHub] [hive] ayushtkn commented on a diff in pull request #3279: HIVE-24484: Upgrade Hadoop to 3.3.2.

2022-05-12 Thread GitBox
ayushtkn commented on code in PR #3279: URL: https://github.com/apache/hive/pull/3279#discussion_r871357800 ## standalone-metastore/pom.xml: ## @@ -227,6 +227,10 @@ hadoop-mapreduce-client-core ${hadoop.version} + +org.jline +

[GitHub] [hive] ayushtkn commented on a diff in pull request #3279: HIVE-24484: Upgrade Hadoop to 3.3.2.

2022-05-12 Thread GitBox
ayushtkn commented on code in PR #3279: URL: https://github.com/apache/hive/pull/3279#discussion_r871355730 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ## @@ -9361,7 +9362,8 @@ public NotificationEventsCountResponse g

[GitHub] [hive] ayushtkn commented on a diff in pull request #3279: HIVE-24484: Upgrade Hadoop to 3.3.2.

2022-05-12 Thread GitBox
ayushtkn commented on code in PR #3279: URL: https://github.com/apache/hive/pull/3279#discussion_r871355509 ## ql/src/java/org/apache/hadoop/hive/ql/io/RecordReaderWrapper.java: ## @@ -69,7 +70,14 @@ static RecordReader create(InputFormat inputFormat, HiveInputFormat.HiveInputS

[GitHub] [hive] kgyrtkirk commented on a diff in pull request #3279: HIVE-24484: Upgrade Hadoop to 3.3.2.

2022-05-12 Thread GitBox
kgyrtkirk commented on code in PR #3279: URL: https://github.com/apache/hive/pull/3279#discussion_r871272145 ## common/pom.xml: ## @@ -195,6 +194,11 @@ tez-api ${tez.version} + + org.fusesource.jansi + jansi + 2.3.4 Review Comment: move

[GitHub] [hive] ayushtkn commented on pull request #3279: HIVE-24484: Upgrade Hadoop to 3.3.2.

2022-05-12 Thread GitBox
ayushtkn commented on PR #3279: URL: https://github.com/apache/hive/pull/3279#issuecomment-1124857444 My Last run here had 4 errors, of which I think I have fixed 3 more. The one remaining is some XML parsing error, which I think might get auto resolved or may be an after affect. @kg

[GitHub] [hive] pvary commented on a diff in pull request #3269: HIVE-26202: Refactor Iceberg Writers

2022-05-12 Thread GitBox
pvary commented on code in PR #3269: URL: https://github.com/apache/hive/pull/3269#discussion_r871017909 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java: ## @@ -571,6 +571,15 @@ public static boolean isUpdate(Configuration conf,

[GitHub] [hive] hmangla98 opened a new pull request, #3282: HIVE-26225: Delete operations in ObjectStore.cleanWriteNotificationEvents should be performed in different transactions

2022-05-12 Thread GitBox
hmangla98 opened a new pull request, #3282: URL: https://github.com/apache/hive/pull/3282 We need to improve the ObjectStore.cleanWriteNotificationEvents in the same way as it was done for notification log table in: https://issues.apache.org/jira/browse/HIVE-24432 -- This is an automat

[GitHub] [hive] ayushtkn opened a new pull request, #3283: HIVE-26223: Integrate ESRI GeoSpatial UDFs.

2022-05-12 Thread GitBox
ayushtkn opened a new pull request, #3283: URL: https://github.com/apache/hive/pull/3283 Adds GeoSpatial UDFs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe