[GitHub] [hive] sonarcloud[bot] commented on pull request #3963: HIVE-26599: Registering Tables metric during second cycle of optimise…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3963: URL: https://github.com/apache/hive/pull/3963#issuecomment-1396566117 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3965: HIVE-26950: Iceberg: (CTLT) Create external table like V2 table is not preserving table properties.

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3965: URL: https://github.com/apache/hive/pull/3965#issuecomment-1396537991 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] dengzhhu653 commented on pull request #3448: HIVE-26400: Provide docker images for Hive

2023-01-18 Thread GitBox
dengzhhu653 commented on PR #3448: URL: https://github.com/apache/hive/pull/3448#issuecomment-1396511930 > I had some comments earlier, if you can confirm you addressed those @dengzhhu653 , I'll take a second look and approve, it's time to merge this I believe please create an umbrella tick

[GitHub] [hive] tarak271 commented on a diff in pull request #3959: HIVE-26952 - set the value of metastore.storage.schema.reader.impl t…

2023-01-18 Thread GitBox
tarak271 commented on code in PR #3959: URL: https://github.com/apache/hive/pull/3959#discussion_r1080851725 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java: ## @@ -67,6 +67,9 @@ public class MetastoreConf { stat

[GitHub] [hive] ayushtkn opened a new pull request, #3965: HIVE-26950: Iceberg: (CTLT) Create external table like V2 table is not preserving table properties.

2023-01-18 Thread GitBox
ayushtkn opened a new pull request, #3965: URL: https://github.com/apache/hive/pull/3965 ### What changes were proposed in this pull request? Two changes: - Preserve the format version for the iceberg table - Add auto translation logic for iceberg CTLT tables as well(if table

[GitHub] [hive] pudidic commented on pull request #3951: HIVE-26942 : Prevent updation of "repl.target.last.id" when RESUME action initiated

2023-01-18 Thread GitBox
pudidic commented on PR #3951: URL: https://github.com/apache/hive/pull/3951#issuecomment-1396452258 There are several tests failing. Please check them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] pudidic merged pull request #3780: HIVE-26598: Fix unsetting of db params for optimized bootstrap when r…

2023-01-18 Thread GitBox
pudidic merged PR #3780: URL: https://github.com/apache/hive/pull/3780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

[GitHub] [hive] pudidic commented on pull request #3780: HIVE-26598: Fix unsetting of db params for optimized bootstrap when r…

2023-01-18 Thread GitBox
pudidic commented on PR #3780: URL: https://github.com/apache/hive/pull/3780#issuecomment-1396451284 LGTM +1. I'll merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hive] pudidic merged pull request #3736: HIVE-26711 The very first REPL Load should make the Target Database read-only.

2023-01-18 Thread GitBox
pudidic merged PR #3736: URL: https://github.com/apache/hive/pull/3736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

[GitHub] [hive] pudidic commented on pull request #3736: HIVE-26711 The very first REPL Load should make the Target Database read-only.

2023-01-18 Thread GitBox
pudidic commented on PR #3736: URL: https://github.com/apache/hive/pull/3736#issuecomment-1396450347 LGTM +1. I'll merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hive] kasakrisz merged pull request #3934: HIVE-26922: Deadlock when rebuilding Materialized view stored by Iceberg

2023-01-18 Thread GitBox
kasakrisz merged PR #3934: URL: https://github.com/apache/hive/pull/3934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

[GitHub] [hive] sonarcloud[bot] commented on pull request #3907: HIVE-26808: port iceberg catalog changes

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3907: URL: https://github.com/apache/hive/pull/3907#issuecomment-1396377426 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3962: HIVE-26928: LlapIoImpl::getParquetFooterBuffersFromCache throws excep…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3962: URL: https://github.com/apache/hive/pull/3962#issuecomment-1396336653 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3955: HIVE-26947: Handle compaction.Worker sleep for err cases to avoid high frequency connection respawning to HMS

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3955: URL: https://github.com/apache/hive/pull/3955#issuecomment-1396304048 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3934: HIVE-26922: Deadlock when rebuilding Materialized view stored by Iceberg

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3934: URL: https://github.com/apache/hive/pull/3934#issuecomment-1396235662 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3801: HIVE-22977: Merge delta files instead of running a query in major/min…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3801: URL: https://github.com/apache/hive/pull/3801#issuecomment-1396155011 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3907: HIVE-26808: port iceberg catalog changes

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3907: URL: https://github.com/apache/hive/pull/3907#issuecomment-1396102462 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3780: HIVE-26598: Fix unsetting of db params for optimized bootstrap when r…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3780: URL: https://github.com/apache/hive/pull/3780#issuecomment-1387703835 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] amanraj2520 commented on pull request #3954: HIVE-26945 : Fixed query39, query47, query49 and query57 q.out files

2023-01-18 Thread GitBox
amanraj2520 commented on PR #3954: URL: https://github.com/apache/hive/pull/3954#issuecomment-1387598230 Hi @abstractdog these tests failed due to HIVE-20423. Link : https://issues.apache.org/jira/browse/HIVE-20423 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hive] sonarcloud[bot] commented on pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3964: URL: https://github.com/apache/hive/pull/3964#issuecomment-1387581260 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] amanraj2520 commented on pull request #3941: HIVE-26939 : Changed placement policy from NODE to node

2023-01-18 Thread GitBox
amanraj2520 commented on PR #3941: URL: https://github.com/apache/hive/pull/3941#issuecomment-1387560380 @abstractdog Can you please review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hive] sonarcloud[bot] commented on pull request #3962: HIVE-26928: LlapIoImpl::getParquetFooterBuffersFromCache throws excep…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3962: URL: https://github.com/apache/hive/pull/3962#issuecomment-1387348148 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] nrg4878 merged pull request #3716: HIVE-26681:Remove dom4j: flexible XML framework for Java from hive

2023-01-18 Thread GitBox
nrg4878 merged PR #3716: URL: https://github.com/apache/hive/pull/3716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

[GitHub] [hive] zabetak commented on a diff in pull request #3939: HIVE-26925: MV with iceberg storage format fails when contains 'PARTITIONED ON' clause due to column number/types difference.

2023-01-18 Thread GitBox
zabetak commented on code in PR #3939: URL: https://github.com/apache/hive/pull/3939#discussion_r1073656566 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableDesc.java: ## @@ -958,6 +940,31 @@ public Table toTable(HiveConf conf) throws HiveException { ret

[GitHub] [hive] kasakrisz merged pull request #3936: HIVE-26924: Alter materialized view enable rewrite throws SemanticException for source iceberg table

2023-01-18 Thread GitBox
kasakrisz merged PR #3936: URL: https://github.com/apache/hive/pull/3936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

[GitHub] [hive] kasakrisz commented on a diff in pull request #3936: HIVE-26924: Alter materialized view enable rewrite throws SemanticException for source iceberg table

2023-01-18 Thread GitBox
kasakrisz commented on code in PR #3936: URL: https://github.com/apache/hive/pull/3936#discussion_r1073645247 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteAnalyzer.java: ## @@ -68,10 +68,12 @@ public void analyzeInterna

[GitHub] [hive] skysiders commented on pull request #3894: HIVE-26887 Make sure dirPath has the correct permissions

2023-01-18 Thread GitBox
skysiders commented on PR #3894: URL: https://github.com/apache/hive/pull/3894#issuecomment-1387202288 Hi @zabetak , thanks for your review. You mentioned that this is "kind of a breaking change", but I don't agree with this. In setting file permissions, most of the time we can rely on t

[GitHub] [hive] kasakrisz commented on pull request #3936: HIVE-26924: Alter materialized view enable rewrite throws SemanticException for source iceberg table

2023-01-18 Thread GitBox
kasakrisz commented on PR #3936: URL: https://github.com/apache/hive/pull/3936#issuecomment-1387194012 Yes, the doc is not up-to-date. Iceberg is also missing. In case of create materialized view checks are performed here: https://github.com/apache/hive/blob/55471330426c2e0a52101c2

[GitHub] [hive] sonarcloud[bot] commented on pull request #3736: HIVE-26711 The very first REPL Load should make the Target Database read-only.

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3736: URL: https://github.com/apache/hive/pull/3736#issuecomment-1387173495 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] abstractdog merged pull request #3928: HIVE-26915: Disable TestCodahaleMetrics.testFileReporting flaky

2023-01-18 Thread GitBox
abstractdog merged PR #3928: URL: https://github.com/apache/hive/pull/3928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

[GitHub] [hive] abstractdog commented on pull request #3954: HIVE-26945 : Fixed query39, query47, query49 and query57 q.out files

2023-01-18 Thread GitBox
abstractdog commented on PR #3954: URL: https://github.com/apache/hive/pull/3954#issuecomment-1387136989 basically, these changes make sense to me, just one thing @amanraj2520: can you check if these bits are present on master in this form and clarify what patches caused these changes? --

[GitHub] [hive] kasakrisz commented on a diff in pull request #3934: HIVE-26922: Deadlock when rebuilding Materialized view stored by Iceberg

2023-01-18 Thread GitBox
kasakrisz commented on code in PR #3934: URL: https://github.com/apache/hive/pull/3934#discussion_r1073584822 ## ql/src/test/org/apache/hadoop/hive/ql/metadata/StorageHandlerMock.java: ## @@ -70,7 +70,7 @@ public class StorageHandlerMock extends DefaultStorageHandler { if

[GitHub] [hive] zabetak commented on a diff in pull request #3936: HIVE-26924: Alter materialized view enable rewrite throws SemanticException for source iceberg table

2023-01-18 Thread GitBox
zabetak commented on code in PR #3936: URL: https://github.com/apache/hive/pull/3936#discussion_r1073576224 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteAnalyzer.java: ## @@ -68,10 +68,12 @@ public void analyzeInternal(

[GitHub] [hive] abstractdog commented on pull request #3448: HIVE-26400: Provide docker images for Hive

2023-01-18 Thread GitBox
abstractdog commented on PR #3448: URL: https://github.com/apache/hive/pull/3448#issuecomment-1387132348 I had some comments earlier, if you can confirm you addressed those @dengzhhu653 , I'll take a second look and approve, it's time to merge this I believe please create an umbrella tic

[GitHub] [hive] sonarcloud[bot] commented on pull request #3882: HIVE-26802 Create qtest that runs the queries that query-based compac…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3882: URL: https://github.com/apache/hive/pull/3882#issuecomment-1387131743 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] kasakrisz commented on a diff in pull request #3934: HIVE-26922: Deadlock when rebuilding Materialized view stored by Iceberg

2023-01-18 Thread GitBox
kasakrisz commented on code in PR #3934: URL: https://github.com/apache/hive/pull/3934#discussion_r1073566847 ## ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java: ## @@ -3122,7 +3117,19 @@ Seems much cleaner if each stmt is identified as a particular HiveOperation (whi

[GitHub] [hive] kasakrisz commented on pull request #3934: HIVE-26922: Deadlock when rebuilding Materialized view stored by Iceberg

2023-01-18 Thread GitBox
kasakrisz commented on PR #3934: URL: https://github.com/apache/hive/pull/3934#issuecomment-1387079817 Lock requests in the code: 1. https://github.com/apache/hive/blob/55471330426c2e0a52101c2e535a66f751be76ee/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java#L3029 2. https://gi

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…

2023-01-18 Thread GitBox
SourabhBadhya commented on code in PR #3964: URL: https://github.com/apache/hive/pull/3964#discussion_r1073502143 ## ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java: ## @@ -676,6 +676,39 @@ private int getScale(PrimitiveType type) { re

[GitHub] [hive] sonarcloud[bot] commented on pull request #3959: HIVE-26952 - set the value of metastore.storage.schema.reader.impl t…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3959: URL: https://github.com/apache/hive/pull/3959#issuecomment-1387028071 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3951: HIVE-26942 : Prevent updation of "repl.target.last.id" when RESUME action initiated

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3951: URL: https://github.com/apache/hive/pull/3951#issuecomment-1387019466 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] zabetak commented on a diff in pull request #3934: HIVE-26922: Deadlock when rebuilding Materialized view stored by Iceberg

2023-01-18 Thread GitBox
zabetak commented on code in PR #3934: URL: https://github.com/apache/hive/pull/3934#discussion_r1073456835 ## ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java: ## @@ -3122,7 +3117,19 @@ Seems much cleaner if each stmt is identified as a particular HiveOperation (whi

[GitHub] [hive] zratkai commented on a diff in pull request #3882: HIVE-26802 Create qtest that runs the queries that query-based compac…

2023-01-18 Thread GitBox
zratkai commented on code in PR #3882: URL: https://github.com/apache/hive/pull/3882#discussion_r1073453543 ## itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java: ## @@ -236,7 +240,39 @@ public MiniLlapLocalCliConfig() { } } } + + publ

[GitHub] [hive] zabetak commented on pull request #3894: HIVE-26887 Make sure dirPath has the correct permissions

2023-01-18 Thread GitBox
zabetak commented on PR #3894: URL: https://github.com/apache/hive/pull/3894#issuecomment-1386890501 Thanks for the elaborate analysis and discussion @skysiders @cnauroth ! Looking into the changes it seems that this is kind of a breaking change since depending on the configuration pe

[GitHub] [hive] kasakrisz commented on a diff in pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…

2023-01-18 Thread GitBox
kasakrisz commented on code in PR #3964: URL: https://github.com/apache/hive/pull/3964#discussion_r1073368036 ## ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java: ## @@ -676,6 +676,39 @@ private int getScale(PrimitiveType type) { return

[GitHub] [hive] sonarcloud[bot] commented on pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3964: URL: https://github.com/apache/hive/pull/3964#issuecomment-1386861732 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

2023-01-18 Thread GitBox
amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1386852115 @abstractdog @zabetak Please review and merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] amanraj2520 commented on pull request #3928: HIVE-26915: Disable TestCodahaleMetrics.testFileReporting flaky

2023-01-18 Thread GitBox
amanraj2520 commented on PR #3928: URL: https://github.com/apache/hive/pull/3928#issuecomment-1386851403 @zabetak @abstractdog Please review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3882: HIVE-26802 Create qtest that runs the queries that query-based compac…

2023-01-18 Thread GitBox
deniskuzZ commented on code in PR #3882: URL: https://github.com/apache/hive/pull/3882#discussion_r107590 ## itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestMiniLlapLocalCompactorCliDriver.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3882: HIVE-26802 Create qtest that runs the queries that query-based compac…

2023-01-18 Thread GitBox
deniskuzZ commented on code in PR #3882: URL: https://github.com/apache/hive/pull/3882#discussion_r1073331086 ## itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java: ## @@ -236,7 +240,39 @@ public MiniLlapLocalCliConfig() { } } } + + pu

[GitHub] [hive] sonarcloud[bot] commented on pull request #3962: HIVE-26928: LlapIoImpl::getParquetFooterBuffersFromCache throws excep…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3962: URL: https://github.com/apache/hive/pull/3962#issuecomment-1386778230 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3963: HIVE-26599: Registering Tables metric during second cycle of optimise…

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #3963: URL: https://github.com/apache/hive/pull/3963#issuecomment-1386777389 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] SourabhBadhya opened a new pull request, #3964: HIVE-26955: Alter table fails when decimal column data type is change…

2023-01-18 Thread GitBox
SourabhBadhya opened a new pull request, #3964: URL: https://github.com/apache/hive/pull/3964 …d to string/char/varchar in Parquet ### What changes were proposed in this pull request? Alter table fails when decimal column data type is changed to string/char/varchar in P

[GitHub] [hive] pudidic merged pull request #3953: HIVE-26943 : Fix NPE during Optimised Bootstrap when db is dropped

2023-01-18 Thread GitBox
pudidic merged PR #3953: URL: https://github.com/apache/hive/pull/3953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

[GitHub] [hive] pudidic commented on pull request #3953: HIVE-26943 : Fix NPE during Optimised Bootstrap when db is dropped

2023-01-18 Thread GitBox
pudidic commented on PR #3953: URL: https://github.com/apache/hive/pull/3953#issuecomment-1386716704 LGTM. I will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hive] kasakrisz commented on a diff in pull request #3934: HIVE-26922: Deadlock when rebuilding Materialized view stored by Iceberg

2023-01-18 Thread GitBox
kasakrisz commented on code in PR #3934: URL: https://github.com/apache/hive/pull/3934#discussion_r1073259594 ## ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java: ## @@ -3122,7 +3117,19 @@ Seems much cleaner if each stmt is identified as a particular HiveOperation (whi

[GitHub] [hive] kasakrisz commented on a diff in pull request #3936: HIVE-26924: Alter materialized view enable rewrite throws SemanticException for source iceberg table

2023-01-18 Thread GitBox
kasakrisz commented on code in PR #3936: URL: https://github.com/apache/hive/pull/3936#discussion_r1073252916 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteAnalyzer.java: ## @@ -68,10 +68,12 @@ public void analyzeInterna

[GitHub] [hive] kasakrisz merged pull request #3935: HIVE-26717: Query based Rebalance compaction on insert-only tables

2023-01-18 Thread GitBox
kasakrisz merged PR #3935: URL: https://github.com/apache/hive/pull/3935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

[GitHub] [hive] amansinha100 commented on pull request #3852: HIVE-22173: Query with multiple lateral views hangs during compilation

2023-01-18 Thread GitBox
amansinha100 commented on PR #3852: URL: https://github.com/apache/hive/pull/3852#issuecomment-1386647977 > > Also, the commit message mentions partition pruning but I didn't see changes related to that (I might have missed it). > > @amansinha100 The partition pruning

[GitHub] [hive] amansinha100 commented on a diff in pull request #3852: HIVE-22173: Query with multiple lateral views hangs during compilation

2023-01-18 Thread GitBox
amansinha100 commented on code in PR #3852: URL: https://github.com/apache/hive/pull/3852#discussion_r1073206272 ## common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: ## @@ -3710,7 +3710,12 @@ public static enum ConfVars { HIVE_EXPLAIN_USER("hive.explain.user", true