sonarcloud[bot] commented on PR #3963:
URL: https://github.com/apache/hive/pull/3963#issuecomment-1396566117
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #3965:
URL: https://github.com/apache/hive/pull/3965#issuecomment-1396537991
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
dengzhhu653 commented on PR #3448:
URL: https://github.com/apache/hive/pull/3448#issuecomment-1396511930
> I had some comments earlier, if you can confirm you addressed those
@dengzhhu653 , I'll take a second look and approve, it's time to merge this I
believe please create an umbrella tick
tarak271 commented on code in PR #3959:
URL: https://github.com/apache/hive/pull/3959#discussion_r1080851725
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##
@@ -67,6 +67,9 @@ public class MetastoreConf {
stat
ayushtkn opened a new pull request, #3965:
URL: https://github.com/apache/hive/pull/3965
### What changes were proposed in this pull request?
Two changes:
- Preserve the format version for the iceberg table
- Add auto translation logic for iceberg CTLT tables as well(if table
pudidic commented on PR #3951:
URL: https://github.com/apache/hive/pull/3951#issuecomment-1396452258
There are several tests failing. Please check them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pudidic merged PR #3780:
URL: https://github.com/apache/hive/pull/3780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or
pudidic commented on PR #3780:
URL: https://github.com/apache/hive/pull/3780#issuecomment-1396451284
LGTM +1. I'll merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pudidic merged PR #3736:
URL: https://github.com/apache/hive/pull/3736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or
pudidic commented on PR #3736:
URL: https://github.com/apache/hive/pull/3736#issuecomment-1396450347
LGTM +1. I'll merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kasakrisz merged PR #3934:
URL: https://github.com/apache/hive/pull/3934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.
sonarcloud[bot] commented on PR #3907:
URL: https://github.com/apache/hive/pull/3907#issuecomment-1396377426
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #3962:
URL: https://github.com/apache/hive/pull/3962#issuecomment-1396336653
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #3955:
URL: https://github.com/apache/hive/pull/3955#issuecomment-1396304048
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #3934:
URL: https://github.com/apache/hive/pull/3934#issuecomment-1396235662
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #3801:
URL: https://github.com/apache/hive/pull/3801#issuecomment-1396155011
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #3907:
URL: https://github.com/apache/hive/pull/3907#issuecomment-1396102462
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #3780:
URL: https://github.com/apache/hive/pull/3780#issuecomment-1387703835
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
amanraj2520 commented on PR #3954:
URL: https://github.com/apache/hive/pull/3954#issuecomment-1387598230
Hi @abstractdog these tests failed due to HIVE-20423. Link :
https://issues.apache.org/jira/browse/HIVE-20423
--
This is an automated message from the Apache Git Service.
To respond to
sonarcloud[bot] commented on PR #3964:
URL: https://github.com/apache/hive/pull/3964#issuecomment-1387581260
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
amanraj2520 commented on PR #3941:
URL: https://github.com/apache/hive/pull/3941#issuecomment-1387560380
@abstractdog Can you please review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
sonarcloud[bot] commented on PR #3962:
URL: https://github.com/apache/hive/pull/3962#issuecomment-1387348148
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
nrg4878 merged PR #3716:
URL: https://github.com/apache/hive/pull/3716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or
zabetak commented on code in PR #3939:
URL: https://github.com/apache/hive/pull/3939#discussion_r1073656566
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableDesc.java:
##
@@ -958,6 +940,31 @@ public Table toTable(HiveConf conf) throws HiveException {
ret
kasakrisz merged PR #3936:
URL: https://github.com/apache/hive/pull/3936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.
kasakrisz commented on code in PR #3936:
URL: https://github.com/apache/hive/pull/3936#discussion_r1073645247
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteAnalyzer.java:
##
@@ -68,10 +68,12 @@ public void analyzeInterna
skysiders commented on PR #3894:
URL: https://github.com/apache/hive/pull/3894#issuecomment-1387202288
Hi @zabetak , thanks for your review.
You mentioned that this is "kind of a breaking change", but I don't agree
with this. In setting file permissions, most of the time we can rely on t
kasakrisz commented on PR #3936:
URL: https://github.com/apache/hive/pull/3936#issuecomment-1387194012
Yes, the doc is not up-to-date. Iceberg is also missing.
In case of create materialized view checks are performed here:
https://github.com/apache/hive/blob/55471330426c2e0a52101c2
sonarcloud[bot] commented on PR #3736:
URL: https://github.com/apache/hive/pull/3736#issuecomment-1387173495
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
abstractdog merged PR #3928:
URL: https://github.com/apache/hive/pull/3928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach
abstractdog commented on PR #3954:
URL: https://github.com/apache/hive/pull/3954#issuecomment-1387136989
basically, these changes make sense to me, just one thing @amanraj2520: can
you check if these bits are present on master in this form and clarify what
patches caused these changes?
--
kasakrisz commented on code in PR #3934:
URL: https://github.com/apache/hive/pull/3934#discussion_r1073584822
##
ql/src/test/org/apache/hadoop/hive/ql/metadata/StorageHandlerMock.java:
##
@@ -70,7 +70,7 @@ public class StorageHandlerMock extends DefaultStorageHandler
{
if
zabetak commented on code in PR #3936:
URL: https://github.com/apache/hive/pull/3936#discussion_r1073576224
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteAnalyzer.java:
##
@@ -68,10 +68,12 @@ public void analyzeInternal(
abstractdog commented on PR #3448:
URL: https://github.com/apache/hive/pull/3448#issuecomment-1387132348
I had some comments earlier, if you can confirm you addressed those
@dengzhhu653 , I'll take a second look and approve, it's time to merge this I
believe
please create an umbrella tic
sonarcloud[bot] commented on PR #3882:
URL: https://github.com/apache/hive/pull/3882#issuecomment-1387131743
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
kasakrisz commented on code in PR #3934:
URL: https://github.com/apache/hive/pull/3934#discussion_r1073566847
##
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##
@@ -3122,7 +3117,19 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
kasakrisz commented on PR #3934:
URL: https://github.com/apache/hive/pull/3934#issuecomment-1387079817
Lock requests in the code:
1.
https://github.com/apache/hive/blob/55471330426c2e0a52101c2e535a66f751be76ee/ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java#L3029
2.
https://gi
SourabhBadhya commented on code in PR #3964:
URL: https://github.com/apache/hive/pull/3964#discussion_r1073502143
##
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java:
##
@@ -676,6 +676,39 @@ private int getScale(PrimitiveType type) {
re
sonarcloud[bot] commented on PR #3959:
URL: https://github.com/apache/hive/pull/3959#issuecomment-1387028071
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #3951:
URL: https://github.com/apache/hive/pull/3951#issuecomment-1387019466
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
zabetak commented on code in PR #3934:
URL: https://github.com/apache/hive/pull/3934#discussion_r1073456835
##
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##
@@ -3122,7 +3117,19 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
zratkai commented on code in PR #3882:
URL: https://github.com/apache/hive/pull/3882#discussion_r1073453543
##
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java:
##
@@ -236,7 +240,39 @@ public MiniLlapLocalCliConfig() {
}
}
}
+
+ publ
zabetak commented on PR #3894:
URL: https://github.com/apache/hive/pull/3894#issuecomment-1386890501
Thanks for the elaborate analysis and discussion @skysiders @cnauroth !
Looking into the changes it seems that this is kind of a breaking change
since depending on the configuration pe
kasakrisz commented on code in PR #3964:
URL: https://github.com/apache/hive/pull/3964#discussion_r1073368036
##
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java:
##
@@ -676,6 +676,39 @@ private int getScale(PrimitiveType type) {
return
sonarcloud[bot] commented on PR #3964:
URL: https://github.com/apache/hive/pull/3964#issuecomment-1386861732
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
amanraj2520 commented on PR #3900:
URL: https://github.com/apache/hive/pull/3900#issuecomment-1386852115
@abstractdog @zabetak Please review and merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
amanraj2520 commented on PR #3928:
URL: https://github.com/apache/hive/pull/3928#issuecomment-1386851403
@zabetak @abstractdog Please review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
deniskuzZ commented on code in PR #3882:
URL: https://github.com/apache/hive/pull/3882#discussion_r107590
##
itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestMiniLlapLocalCompactorCliDriver.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation
deniskuzZ commented on code in PR #3882:
URL: https://github.com/apache/hive/pull/3882#discussion_r1073331086
##
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java:
##
@@ -236,7 +240,39 @@ public MiniLlapLocalCliConfig() {
}
}
}
+
+ pu
sonarcloud[bot] commented on PR #3962:
URL: https://github.com/apache/hive/pull/3962#issuecomment-1386778230
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
sonarcloud[bot] commented on PR #3963:
URL: https://github.com/apache/hive/pull/3963#issuecomment-1386777389
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Quality
SourabhBadhya opened a new pull request, #3964:
URL: https://github.com/apache/hive/pull/3964
…d to string/char/varchar in Parquet
### What changes were proposed in this pull request?
Alter table fails when decimal column data type is changed to
string/char/varchar in P
pudidic merged PR #3953:
URL: https://github.com/apache/hive/pull/3953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or
pudidic commented on PR #3953:
URL: https://github.com/apache/hive/pull/3953#issuecomment-1386716704
LGTM. I will merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kasakrisz commented on code in PR #3934:
URL: https://github.com/apache/hive/pull/3934#discussion_r1073259594
##
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##
@@ -3122,7 +3117,19 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
kasakrisz commented on code in PR #3936:
URL: https://github.com/apache/hive/pull/3936#discussion_r1073252916
##
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteAnalyzer.java:
##
@@ -68,10 +68,12 @@ public void analyzeInterna
kasakrisz merged PR #3935:
URL: https://github.com/apache/hive/pull/3935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.
amansinha100 commented on PR #3852:
URL: https://github.com/apache/hive/pull/3852#issuecomment-1386647977
> > Also, the commit message mentions partition pruning but I didn't see
changes related to that (I might have missed it).
>
> @amansinha100 The partition pruning
amansinha100 commented on code in PR #3852:
URL: https://github.com/apache/hive/pull/3852#discussion_r1073206272
##
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##
@@ -3710,7 +3710,12 @@ public static enum ConfVars {
HIVE_EXPLAIN_USER("hive.explain.user", true
59 matches
Mail list logo