[GitHub] [hive] sonarcloud[bot] commented on pull request #4085: HIVE-15826: Add 'serialization.encoding' To All SerDes

sonarcloud[bot] commented on PR #4085: URL: https://github.com/apache/hive/pull/4085#issuecomment-1447724318 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] ayushtkn merged pull request #4082: HIVE-27105: Parquet and kafka-client both use zstd-jni. Upgrading kaf…

ayushtkn merged PR #4082: URL: https://github.com/apache/hive/pull/4082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.o

[GitHub] [hive] sonarcloud[bot] commented on pull request #4070: HIVE-27088: fixed nway join pattern

sonarcloud[bot] commented on PR #4070: URL: https://github.com/apache/hive/pull/4070#issuecomment-1447643027 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #4032: HIVE-27019: Split Cleaner into separate manageable modular entities

sonarcloud[bot] commented on PR #4032: URL: https://github.com/apache/hive/pull/4032#issuecomment-1447591048 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

SourabhBadhya commented on code in PR #3576: URL: https://github.com/apache/hive/pull/3576#discussion_r1119563491 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java: ## @@ -1535,20 +1556,14 @@ public void setHado

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #4032: HIVE-27019: Split Cleaner into separate manageable modular entities

SourabhBadhya commented on code in PR #4032: URL: https://github.com/apache/hive/pull/4032#discussion_r1119560097 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CleaningRequest.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #4032: HIVE-27019: Split Cleaner into separate manageable modular entities

SourabhBadhya commented on code in PR #4032: URL: https://github.com/apache/hive/pull/4032#discussion_r1119560009 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/FSRemover.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [hive] sonarcloud[bot] commented on pull request #4028: HIVE-25032: Optimise PartitionManagementTask

sonarcloud[bot] commented on PR #4028: URL: https://github.com/apache/hive/pull/4028#issuecomment-1447555423 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #4032: HIVE-27019: Split Cleaner into separate manageable modular entities

SourabhBadhya commented on code in PR #4032: URL: https://github.com/apache/hive/pull/4032#discussion_r1119559393 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java: ## @@ -57,15 +50,15 @@ public class MetaStoreCompactorThread extends Compactor

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #4032: HIVE-27019: Split Cleaner into separate manageable modular entities

SourabhBadhya commented on code in PR #4032: URL: https://github.com/apache/hive/pull/4032#discussion_r1119558651 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/CompactionHandler.java: ## @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #4032: HIVE-27019: Split Cleaner into separate manageable modular entities

SourabhBadhya commented on code in PR #4032: URL: https://github.com/apache/hive/pull/4032#discussion_r1119558481 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CacheContainer.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #4032: HIVE-27019: Split Cleaner into separate manageable modular entities

SourabhBadhya commented on code in PR #4032: URL: https://github.com/apache/hive/pull/4032#discussion_r1119558304 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CacheContainer.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [hive] sonarcloud[bot] commented on pull request #4082: HIVE-27105: Parquet and kafka-client both use zstd-jni. Upgrading kaf…

sonarcloud[bot] commented on PR #4082: URL: https://github.com/apache/hive/pull/4082#issuecomment-1447373601 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

sonarcloud[bot] commented on PR #3576: URL: https://github.com/apache/hive/pull/3576#issuecomment-1447340160 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #4028: HIVE-25032: Optimise PartitionManagementTask

sonarcloud[bot] commented on PR #4028: URL: https://github.com/apache/hive/pull/4028#issuecomment-1446936821 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #4087: [HIVE-27110] Upgrade com.esotericsoftware:Kryo version to 5.2.0

sonarcloud[bot] commented on PR #4087: URL: https://github.com/apache/hive/pull/4087#issuecomment-1446861385 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #4082: HIVE-27105: Parquet and kafka-client both use zstd-jni. Upgrading kaf…

sonarcloud[bot] commented on PR #4082: URL: https://github.com/apache/hive/pull/4082#issuecomment-1446769765 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #4028: HIVE-25032: Optimise PartitionManagementTask

sonarcloud[bot] commented on PR #4028: URL: https://github.com/apache/hive/pull/4028#issuecomment-1446529472 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

sonarcloud[bot] commented on PR #3576: URL: https://github.com/apache/hive/pull/3576#issuecomment-1446500387 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] veghlaci05 commented on a diff in pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

veghlaci05 commented on code in PR #3576: URL: https://github.com/apache/hive/pull/3576#discussion_r1118834857 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -5894,6 +5902,63 @@ private void addTxnToMinHistoryLe

[GitHub] [hive] sonarcloud[bot] commented on pull request #4088: HIVE-27013: Iceberg: Provide an option to enable iceberg manifest caching for all catalogs.

sonarcloud[bot] commented on PR #4088: URL: https://github.com/apache/hive/pull/4088#issuecomment-1446432838 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] dengzhhu653 commented on pull request #4028: HIVE-25032: Optimise PartitionManagementTask

dengzhhu653 commented on PR #4028: URL: https://github.com/apache/hive/pull/4028#issuecomment-1446407552 > I think the test failures are genuine. Can you please address them? ack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

deniskuzZ commented on code in PR #3576: URL: https://github.com/apache/hive/pull/3576#discussion_r1118777607 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java: ## @@ -140,41 +140,36 @@ public void run() { HiveConf.ConfVars.HIVE_COMPACTOR_

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

deniskuzZ commented on code in PR #3576: URL: https://github.com/apache/hive/pull/3576#discussion_r1118775359 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -5894,6 +5902,63 @@ private void addTxnToMinHistoryLev

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

deniskuzZ commented on code in PR #3576: URL: https://github.com/apache/hive/pull/3576#discussion_r1118766777 ## ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java: ## @@ -395,6 +399,32 @@ private boolean allowOperationInATransaction(QueryPlan queryPlan) { ret

[GitHub] [hive] difin commented on a diff in pull request #4082: HIVE-27105: Parquet and kafka-client both use zstd-jni. Upgrading kaf…

difin commented on code in PR #4082: URL: https://github.com/apache/hive/pull/4082#discussion_r1118766580 ## kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaStorageHandler.java: ## @@ -310,7 +311,7 @@ private String getQueryId() { RetryUtils.CleanupAfterFailure c

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

deniskuzZ commented on code in PR #3576: URL: https://github.com/apache/hive/pull/3576#discussion_r1118764958 ## ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCleaner2.java: ## @@ -23,6 +23,6 @@ public class TestCleaner2 extends TestCleaner { @Override boolean u

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

deniskuzZ commented on code in PR #3576: URL: https://github.com/apache/hive/pull/3576#discussion_r1118764121 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -5894,6 +5902,63 @@ private void addTxnToMinHistoryLev

[GitHub] [hive] sonarcloud[bot] commented on pull request #4087: [WIP] Upgrade kryo version to 5.2.0

sonarcloud[bot] commented on PR #4087: URL: https://github.com/apache/hive/pull/4087#issuecomment-1446334673 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] ayushtkn opened a new pull request, #4088: HIVE-27013: Iceberg: Provide an option to enable iceberg manifest caching for all catalogs.

ayushtkn opened a new pull request, #4088: URL: https://github.com/apache/hive/pull/4088 ### What changes were proposed in this pull request? Provide a config to set catalog level properties globally for all catalogs. ### Why are the changes needed? User Ease ### D

[GitHub] [hive] Indhumathi27 opened a new pull request, #4087: [WIP] Upgrade kryo version to 5.2.0

Indhumathi27 opened a new pull request, #4087: URL: https://github.com/apache/hive/pull/4087 ### What changes were proposed in this pull request? Upgrade kryo version to 5.2.0 ### Why are the changes needed? Upgrading kryo version to higher version 5.2.0 ### Does

[GitHub] [hive] sonarcloud[bot] commented on pull request #4082: HIVE-27105: Parquet and kafka-client both use zstd-jni. Upgrading kaf…

sonarcloud[bot] commented on PR #4082: URL: https://github.com/apache/hive/pull/4082#issuecomment-1446253057 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] kasakrisz commented on a diff in pull request #4077: HIVE-26735: Ability to sort the data during rebalancing compaction

kasakrisz commented on code in PR #4077: URL: https://github.com/apache/hive/pull/4077#discussion_r1118677843 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -1561,7 +1561,7 @@ public void commitTxn(CommitTxnRequ

[GitHub] [hive] veghlaci05 commented on a diff in pull request #3576: HIVE-26704: Cleaner shouldn't be blocked by global min open txnId

veghlaci05 commented on code in PR #3576: URL: https://github.com/apache/hive/pull/3576#discussion_r1118536472 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -5894,6 +5902,63 @@ private void addTxnToMinHistoryLe

[GitHub] [hive] shreeyasand opened a new pull request, #4086: HIVE-27109: Upgrade jackson version to 2.12.7.1 to fix CVE-2022-42003

shreeyasand opened a new pull request, #4086: URL: https://github.com/apache/hive/pull/4086 ### What changes were proposed in this pull request? Upgrade jackson version to 2.12.7.1 ### Why are the changes needed? To fix CVE-2022-42003 ### Does this PR introduce _an

[GitHub] [hive] sonarcloud[bot] commented on pull request #4085: HIVE-15826: Add 'serialization.encoding' To All SerDes

sonarcloud[bot] commented on PR #4085: URL: https://github.com/apache/hive/pull/4085#issuecomment-1446134929 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] ayushtkn commented on a diff in pull request #4082: HIVE-27105: Parquet and kafka-client both use zstd-jni. Upgrading kaf…

ayushtkn commented on code in PR #4082: URL: https://github.com/apache/hive/pull/4082#discussion_r1118373976 ## kafka-handler/src/java/org/apache/hadoop/hive/kafka/KafkaStorageHandler.java: ## @@ -310,7 +311,7 @@ private String getQueryId() { RetryUtils.CleanupAfterFailur

[GitHub] [hive] sonarcloud[bot] commented on pull request #4028: HIVE-25032: Optimise PartitionManagementTask

sonarcloud[bot] commented on PR #4028: URL: https://github.com/apache/hive/pull/4028#issuecomment-1446028047 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] sonarcloud[bot] commented on pull request #4084: HIVE-27107 : Fix improper metrics count for RESUME/RESET workflow

sonarcloud[bot] commented on PR #4084: URL: https://github.com/apache/hive/pull/4084#issuecomment-1445956466 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4028: HIVE-25032: Optimise PartitionManagementTask

dengzhhu653 commented on code in PR #4028: URL: https://github.com/apache/hive/pull/4028#discussion_r1118441614 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java: ## @@ -2174,6 +2174,22 @@ List dropPartitions(String cat

[GitHub] [hive] guptashailesh92 opened a new pull request, #4085: HIVE-15826: Add 'serialization.encoding' To All SerDes

guptashailesh92 opened a new pull request, #4085: URL: https://github.com/apache/hive/pull/4085 Added support for **serialization.encoding** for OpenCSV, JsonSerde and RegexSerde. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hive] sonarcloud[bot] commented on pull request #4079: HIVE-27101: Support incremental materialized view rebuild when Iceberg source tables have insert operation only.

sonarcloud[bot] commented on PR #4079: URL: https://github.com/apache/hive/pull/4079#issuecomment-144588 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [hive] deniskuzZ commented on a diff in pull request #4032: HIVE-27019: Split Cleaner into separate manageable modular entities

deniskuzZ commented on code in PR #4032: URL: https://github.com/apache/hive/pull/4032#discussion_r1118391763 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java: ## @@ -212,323 +138,9 @@ public void run() { } } - private void clean(CompactionInfo ci,