sonarcloud[bot] commented on PR #4681:
URL: https://github.com/apache/hive/pull/4681#issuecomment-1760980682
Kudos, SonarCloud Quality Gate passed! [ {
*
*/
public static class SetC
zhangbutao commented on code in PR #4797:
URL: https://github.com/apache/hive/pull/4797#discussion_r1357037371
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##
@@ -237,11 +238,18 @@ public static void rollback(Table table,
AlterTable
zhangbutao commented on code in PR #4797:
URL: https://github.com/apache/hive/pull/4797#discussion_r1357037895
##
ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTableExecuteSpec.java:
##
@@ -165,19 +165,19 @@ public String toString() {
*
*/
public static class SetC
zhangbutao commented on PR #4797:
URL: https://github.com/apache/hive/pull/4797#issuecomment-1759899256
> what happens when a branch or tag name is a number?
Good catch!
If we have a table which has a snapshotId 123456789, it will obviously
succeed in this case:
`ALTER TABLE t
sonarcloud[bot] commented on PR #4748:
URL: https://github.com/apache/hive/pull/4748#issuecomment-1759865704
Kudos, SonarCloud Quality Gate passed! [ I may be overthinking this
sonarcloud[bot] commented on PR #4793:
URL: https://github.com/apache/hive/pull/4793#issuecomment-1759719443
Kudos, SonarCloud Quality Gate passed! [
+PREHOOK: type: CREATETABLE
+
sonarcloud[bot] commented on PR #4781:
URL: https://github.com/apache/hive/pull/4781#issuecomment-1759470592
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
simhadri-g commented on code in PR #4761:
URL: https://github.com/apache/hive/pull/4761#discussion_r1356526580
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##
@@ -408,12 +409,12 @@ private void commitTable(FileIO io, Execut
simhadri-g commented on code in PR #4761:
URL: https://github.com/apache/hive/pull/4761#discussion_r1356525159
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##
@@ -488,6 +490,9 @@ private void commitWrite(Table table, String
deniskuzZ commented on PR #4796:
URL: https://github.com/apache/hive/pull/4796#issuecomment-1759226171
jira number looks unrelated to the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
zabetak commented on PR #4792:
URL: https://github.com/apache/hive/pull/4792#issuecomment-1759191729
Started a flaky check: http://ci.hive.apache.org/job/hive-flaky-check/743/
The `TestMiniTezCliDriver` needs 10 to 15 minutes to complete so multiplied
by 100 runs is roughly 17H so the
deniskuzZ commented on code in PR #4781:
URL: https://github.com/apache/hive/pull/4781#discussion_r1356455206
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##
@@ -1590,10 +1593,18 @@ public Map
getNativeProperties(org.apache
deniskuzZ commented on code in PR #4781:
URL: https://github.com/apache/hive/pull/4781#discussion_r1356455206
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##
@@ -1590,10 +1593,18 @@ public Map
getNativeProperties(org.apache
sonarcloud[bot] commented on PR #4793:
URL: https://github.com/apache/hive/pull/4793#issuecomment-1759085347
Kudos, SonarCloud Quality Gate passed! [