Re: [PR] HIVE-27892: Hive 'insert overwrite table' for multiple partition tabl… [hive]

2023-11-26 Thread via GitHub
sonarcloud[bot] commented on PR #4893: URL: https://github.com/apache/hive/pull/4893#issuecomment-1827206010 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-11-26 Thread via GitHub
rkirtir opened a new pull request, #4901: URL: https://github.com/apache/hive/pull/4901 ### What changes were proposed in this pull request? In the query-executor, we create ephemeral nodes which have the special behaviour that they are automatically deleted when the query-coordin

Re: [PR] HIVE-27899: Killed speculative execution task attempt should not comm… [hive]

2023-11-26 Thread via GitHub
zhengchenyu commented on PR #4899: URL: https://github.com/apache/hive/pull/4899#issuecomment-1827191490 @abstractdog Can you please review this PR? It is reasonable to use AM’s synchronization mechanism for commit file. -- This is an automated message from the Apache Git Service. To

Re: [PR] HIVE-27905: SPLIT throws ClassCastException [hive]

2023-11-26 Thread via GitHub
ayushtkn commented on PR #4896: URL: https://github.com/apache/hive/pull/4896#issuecomment-1827163618 Yep -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] [HIVE-27893] Add a range validator in hive.metastore.batch.retrieve.max to only have values >= 1. Fallback to default if batchSize is ever < 1 [hive]

2023-11-26 Thread via GitHub
sonarcloud[bot] commented on PR #4881: URL: https://github.com/apache/hive/pull/4881#issuecomment-1827160282 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre… [hive]

2023-11-26 Thread via GitHub
sonarcloud[bot] commented on PR #4761: URL: https://github.com/apache/hive/pull/4761#issuecomment-1827118247 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27905: SPLIT throws ClassCastException [hive]

2023-11-26 Thread via GitHub
okumin commented on PR #4896: URL: https://github.com/apache/hive/pull/4896#issuecomment-1827066572 @ayushtkn Thanks. Can I address all similar issues in this single ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HIVE-27709: Backport of HIVE-22595: Dynamic partition inserts fail on Avro table table with external schema [hive]

2023-11-26 Thread via GitHub
github-actions[bot] commented on PR #4718: URL: https://github.com/apache/hive/pull/4718#issuecomment-1826955417 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre… [hive]

2023-11-26 Thread via GitHub
sonarcloud[bot] commented on PR #4761: URL: https://github.com/apache/hive/pull/4761#issuecomment-1826943830 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27906: Iceberg: Implement Delete Orphan Files. [hive]

2023-11-26 Thread via GitHub
sonarcloud[bot] commented on PR #4897: URL: https://github.com/apache/hive/pull/4897#issuecomment-1826864649 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27906: Iceberg: Implement Delete Orphan Files. [hive]

2023-11-26 Thread via GitHub
ayushtkn commented on code in PR #4897: URL: https://github.com/apache/hive/pull/4897#discussion_r1405438725 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergDeleteOrphanFiles.java: ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] HIVE-27906: Iceberg: Implement Delete Orphan Files. [hive]

2023-11-26 Thread via GitHub
ayushtkn commented on code in PR #4897: URL: https://github.com/apache/hive/pull/4897#discussion_r1405438583 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergDeleteOrphanFiles.java: ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] HIVE-27906: Iceberg: Implement Delete Orphan Files. [hive]

2023-11-26 Thread via GitHub
ayushtkn commented on code in PR #4897: URL: https://github.com/apache/hive/pull/4897#discussion_r1405438665 ## ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTableExecuteSpec.java: ## @@ -270,4 +271,27 @@ public SearchArgument getSarg() { return sarg; } } + +

Re: [PR] HIVE-27896: Remove common-lang usage [hive]

2023-11-26 Thread via GitHub
ayushtkn merged PR #4891: URL: https://github.com/apache/hive/pull/4891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.o

Re: [PR] Fixed 8 flaky tests in `hbase-handler` [hive]

2023-11-26 Thread via GitHub
zhangbutao commented on PR #4900: URL: https://github.com/apache/hive/pull/4900#issuecomment-1826725247 > This Map does not guarantee the same order of the fields every time which causes the assertions to fail. I almost understand what you mean. But i have never seen these tests fail.

Re: [PR] HIVE-27906: Iceberg: Implement Delete Orphan Files. [hive]

2023-11-26 Thread via GitHub
zhangbutao commented on code in PR #4897: URL: https://github.com/apache/hive/pull/4897#discussion_r1405347851 ## ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTableExecuteSpec.java: ## @@ -270,4 +271,27 @@ public SearchArgument getSarg() { return sarg; } } + +