Re: [PR] HIVE-27712: GenericUDAFNumericStatsEvaluator throws NPE [hive]

2023-12-05 Thread via GitHub
liangyu-1 commented on PR #4909: URL: https://github.com/apache/hive/pull/4909#issuecomment-1842272528 > Copy my respose from JIRA comment: This problem is somewhat similar to that one https://issues.apache.org/jira/browse/HIVE-22633, which maybe be fixed by https://issues.apache.org/jira/b

Re: [PR] HIVE-27893 Add a range validator in hive.metastore.batch.retrieve.max to only have values greater than 0 [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4912: URL: https://github.com/apache/hive/pull/4912#issuecomment-1842273062 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27930: Insert overwrite table partition does not clean up directory before overwriting [hive]

2023-12-05 Thread via GitHub
KiranVelumuri commented on code in PR #4915: URL: https://github.com/apache/hive/pull/4915#discussion_r1416834704 ## ql/src/test/queries/clientpositive/insert_overwrite_drop_partition.q: ## @@ -0,0 +1,46 @@ +set hive.exec.dynamic.partition.mode=nonstrict; +set hive.stats.column.

Re: [PR] HIVE-27930: Insert overwrite table partition does not clean up directory before overwriting [hive]

2023-12-05 Thread via GitHub
KiranVelumuri commented on code in PR #4915: URL: https://github.com/apache/hive/pull/4915#discussion_r1416832900 ## ql/src/test/queries/clientpositive/insert_overwrite_drop_partition.q: ## @@ -0,0 +1,46 @@ +set hive.exec.dynamic.partition.mode=nonstrict; +set hive.stats.column.

Re: [PR] HIVE-27930: Insert overwrite table partition does not clean up directory before overwriting [hive]

2023-12-05 Thread via GitHub
KiranVelumuri commented on code in PR #4915: URL: https://github.com/apache/hive/pull/4915#discussion_r1416831243 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -5542,6 +5542,12 @@ private void replaceFiles(Path tablePath, Path srcf, Path destf, Path oldPath

Re: [PR] HIVE-27797 - Transactions that got timed out are not getting logged a… [hive]

2023-12-05 Thread via GitHub
tarak271 commented on code in PR #4805: URL: https://github.com/apache/hive/pull/4805#discussion_r1416761606 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -5811,14 +5812,14 @@ public void performTimeOuts() {

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre… [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4761: URL: https://github.com/apache/hive/pull/4761#issuecomment-1842146722 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27553: Fix After upgrading from Hive1 to Hive3, Decimal computation experiences a loss of precision [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4739: URL: https://github.com/apache/hive/pull/4739#issuecomment-1842092277 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27894: Enhanced HMSHandler partition logs [hive]

2023-12-05 Thread via GitHub
chinnaraolalam merged PR #4886: URL: https://github.com/apache/hive/pull/4886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.ap

Re: [PR] HIVE-27894: Enhanced HMSHandler partition logs [hive]

2023-12-05 Thread via GitHub
chinnaraolalam commented on PR #4886: URL: https://github.com/apache/hive/pull/4886#issuecomment-1842063576 +1 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] HIVE-27893 Add a range validator in hive.metastore.batch.retrieve.max to only have values greater than 0 [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4912: URL: https://github.com/apache/hive/pull/4912#issuecomment-1842062604 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27553: Fix After upgrading from Hive1 to Hive3, Decimal computation experiences a loss of precision [hive]

2023-12-05 Thread via GitHub
bwzheng2010 commented on code in PR #4739: URL: https://github.com/apache/hive/pull/4739#discussion_r1416619728 ## ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java: ## @@ -115,14 +115,34 @@ protected HiveDecimalWritable evaluate(HiveDecimal left, HiveDe

Re: [PR] HIVE-27553: Fix After upgrading from Hive1 to Hive3, Decimal computation experiences a loss of precision [hive]

2023-12-05 Thread via GitHub
bwzheng2010 commented on code in PR #4739: URL: https://github.com/apache/hive/pull/4739#discussion_r1416618023 ## common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: ## @@ -5725,7 +5725,10 @@ public static enum ConfVars { HIVE_ADDITIONAL_CONFIG_FILES("hive.additio

Re: [PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4901: URL: https://github.com/apache/hive/pull/4901#issuecomment-1842031899 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-12-05 Thread via GitHub
rkirtir commented on code in PR #4901: URL: https://github.com/apache/hive/pull/4901#discussion_r1416591517 ## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/TestMariadb.java: ## @@ -0,0 +1,33 @@ +/* Review Comment: sorry, my b

Re: [PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-12-05 Thread via GitHub
rkirtir commented on code in PR #4901: URL: https://github.com/apache/hive/pull/4901#discussion_r1416591119 ## llap-client/src/test/org/apache/hadoop/hive/llap/registry/impl/TestLlapZookeeperRegistryImpl.java: ## @@ -124,6 +126,17 @@ public void testUpdate() throws Exception {

Re: [PR] HIVE-27791 Eliminate totalSize check from test [hive]

2023-12-05 Thread via GitHub
zhangbutao commented on PR #4913: URL: https://github.com/apache/hive/pull/4913#issuecomment-1841976910 > @ayushtkn, @zhangbutao thanks for the review! Modified according to your suggestions. Please have a look on it! @zratkai Good! But http://ci.hive.apache.org/blue/organizations/je

Re: [PR] Multi-stream JDBC changes [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4902: URL: https://github.com/apache/hive/pull/4902#issuecomment-1841705149 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27893 Add a range validator in hive.metastore.batch.retrieve.max to only have values greater than 0 [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4912: URL: https://github.com/apache/hive/pull/4912#issuecomment-1841582896 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27850: Major Compaction for Iceberg tables [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4855: URL: https://github.com/apache/hive/pull/4855#issuecomment-1841499369 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27791 Eliminate totalSize check from test [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4913: URL: https://github.com/apache/hive/pull/4913#issuecomment-1841471090 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27850: Major Compaction for Iceberg tables [hive]

2023-12-05 Thread via GitHub
difin commented on code in PR #4855: URL: https://github.com/apache/hive/pull/4855#discussion_r1416106799 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java: ## @@ -337,151 +341,16 @@ protected Boolean findNextCompactionAndExecute(boolean collectGenericStats, bo

Re: [PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-12-05 Thread via GitHub
abstractdog commented on code in PR #4901: URL: https://github.com/apache/hive/pull/4901#discussion_r1416030598 ## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/TestMariadb.java: ## @@ -0,0 +1,33 @@ +/* Review Comment: this is

Re: [PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-12-05 Thread via GitHub
abstractdog commented on code in PR #4901: URL: https://github.com/apache/hive/pull/4901#discussion_r1416029689 ## llap-client/src/test/org/apache/hadoop/hive/llap/registry/impl/TestLlapZookeeperRegistryImpl.java: ## @@ -124,6 +126,17 @@ public void testUpdate() throws Exception

Re: [PR] HIVE-27791 Eliminate totalSize check from test [hive]

2023-12-05 Thread via GitHub
zratkai commented on PR #4913: URL: https://github.com/apache/hive/pull/4913#issuecomment-1841230908 @ayushtkn, @zhangbutao thanks for the review! Modified according to your suggestions. Please have a look on it! -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] HIVE-27894: Enhanced HMSHandler partition logs [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4886: URL: https://github.com/apache/hive/pull/4886#issuecomment-1841185137 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27797 - Transactions that got timed out are not getting logged a… [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4805: URL: https://github.com/apache/hive/pull/4805#issuecomment-1841177848 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27481: TxnHandler cleanup [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4566: URL: https://github.com/apache/hive/pull/4566#issuecomment-1841106819 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27446: Exception when rebuild materialized view incrementally in presence of delete operations [hive]

2023-12-05 Thread via GitHub
veghlaci05 commented on code in PR #4427: URL: https://github.com/apache/hive/pull/4427#discussion_r1415642513 ## ql/src/test/queries/clientpositive/materialized_view_join_rebuild.q: ## @@ -0,0 +1,33 @@ +-- Test Incremental rebuild of materialized view without aggregate when sou

Re: [PR] HIVE-27481: TxnHandler cleanup [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4566: URL: https://github.com/apache/hive/pull/4566#issuecomment-1840712220 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27850: Major Compaction for Iceberg tables [hive]

2023-12-05 Thread via GitHub
difin commented on code in PR #4855: URL: https://github.com/apache/hive/pull/4855#discussion_r1414286172 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/ACIDCompactionExecutor.java: ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] HIVE-27850: Major Compaction for Iceberg tables [hive]

2023-12-05 Thread via GitHub
difin commented on code in PR #4855: URL: https://github.com/apache/hive/pull/4855#discussion_r1414286172 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/ACIDCompactionExecutor.java: ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] HIVE-27893 Add a range validator in hive.metastore.batch.retrieve.max to only have values greater than 0 [hive]

2023-12-05 Thread via GitHub
zratkai commented on code in PR #4912: URL: https://github.com/apache/hive/pull/4912#discussion_r1415505514 ## ql/src/test/org/apache/hadoop/hive/ql/exec/TestGetPartitionInBatches.java: ## @@ -256,4 +258,21 @@ public void testBatchingWhenException() throws Exception { /

Re: [PR] HIVE-27930: Insert overwrite table partition does not clean up directory before overwriting [hive]

2023-12-05 Thread via GitHub
zhangbutao commented on code in PR #4915: URL: https://github.com/apache/hive/pull/4915#discussion_r1415475630 ## ql/src/test/queries/clientpositive/insert_overwrite_drop_partition.q: ## @@ -0,0 +1,46 @@ +set hive.exec.dynamic.partition.mode=nonstrict; +set hive.stats.column.aut

Re: [PR] HIVE-27928: Release branch cleanup [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4916: URL: https://github.com/apache/hive/pull/4916#issuecomment-1840633019 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27797 - Transactions that got timed out are not getting logged a… [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4805: URL: https://github.com/apache/hive/pull/4805#issuecomment-1840555844 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27930: Insert overwrite table partition does not clean up directory before overwriting [hive]

2023-12-05 Thread via GitHub
zhangbutao commented on code in PR #4915: URL: https://github.com/apache/hive/pull/4915#discussion_r1415300846 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -5542,6 +5542,12 @@ private void replaceFiles(Path tablePath, Path srcf, Path destf, Path oldPath, H

Re: [PR] HIVE-27893 Add a range validator in hive.metastore.batch.retrieve.max to only have values greater than 0 [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4912: URL: https://github.com/apache/hive/pull/4912#issuecomment-1840409860 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27911 : Drop database query failing with Invalid ACL Exception [hive]

2023-12-05 Thread via GitHub
sonarcloud[bot] commented on PR #4901: URL: https://github.com/apache/hive/pull/4901#issuecomment-1840350551 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27928: Release branch cleanup [hive]

2023-12-05 Thread via GitHub
deniskuzZ commented on PR #4916: URL: https://github.com/apache/hive/pull/4916#issuecomment-1840267204 > you will add 4.0.0 metastore scripts here then branch out & then move the version again to 4.0.1-SNAPSHOT? i've created that just for the branch-4.0, but looks like I need to merge

Re: [PR] [HIVE-27893] Add a range validator in hive.metastore.batch.retrieve.max to only have values >= 1 [hive]

2023-12-05 Thread via GitHub
vikramahuja1001 commented on code in PR #4912: URL: https://github.com/apache/hive/pull/4912#discussion_r1415125941 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -4153,43 +4153,14 @@ public List getPartitions(Table tbl) throws HiveException { } /**

Re: [PR] HIVE-27918: Iceberg: Push transforms for clustering during table writes [hive]

2023-12-05 Thread via GitHub
SourabhBadhya merged PR #4908: URL: https://github.com/apache/hive/pull/4908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apa