sonarcloud[bot] commented on PR #4979:
URL: https://github.com/apache/hive/pull/4979#issuecomment-1879576179
## [](https://sonarcloud.
abstractdog commented on PR #4979:
URL: https://github.com/apache/hive/pull/4979#issuecomment-1879545041
thanks for the patch/fix @yigress! could you please reformat the code
according to the style definition here:
https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml
abstractdog merged PR #4977:
URL: https://github.com/apache/hive/pull/4977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach
sonarcloud[bot] commented on PR #4979:
URL: https://github.com/apache/hive/pull/4979#issuecomment-1879503826
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #4380:
URL: https://github.com/apache/hive/pull/4380#issuecomment-1879495743
## [](https://sonarcloud.
github-actions[bot] closed pull request #4716: HIVE-27707 : Backport of
HIVE-22841
URL: https://github.com/apache/hive/pull/4716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #2866:
URL: https://github.com/apache/hive/pull/2866#issuecomment-1879450517
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the
github-actions[bot] closed pull request #4836: HIVE-27831: Set
hive.cbo.fallback.strategy to NEVER by default
URL: https://github.com/apache/hive/pull/4836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sonarcloud[bot] commented on PR #4913:
URL: https://github.com/apache/hive/pull/4913#issuecomment-1879376240
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #4380:
URL: https://github.com/apache/hive/pull/4380#issuecomment-1879352803
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #4977:
URL: https://github.com/apache/hive/pull/4977#issuecomment-1879264994
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #4979:
URL: https://github.com/apache/hive/pull/4979#issuecomment-1879208061
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #4380:
URL: https://github.com/apache/hive/pull/4380#issuecomment-1879149051
## [](https://sonarcloud.
yigress commented on PR #4937:
URL: https://github.com/apache/hive/pull/4937#issuecomment-1879124341
turns out I forgot to push a local change earlier to this PR (missing a $
character). sorry about the trouble and thank you @abstractdog!
new pull request https://github.com/apache/hi
yigress opened a new pull request, #4979:
URL: https://github.com/apache/hive/pull/4979
### What changes were proposed in this pull request?
clean up the code for readibilty
fix the issue when parent partition path exists for multi partitioned
dynamic insert.
### Why are
sonarcloud[bot] commented on PR #4920:
URL: https://github.com/apache/hive/pull/4920#issuecomment-1879006926
## [](https://sonarcloud.
mdayakar commented on PR #4977:
URL: https://github.com/apache/hive/pull/4977#issuecomment-1878988463
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
sonarcloud[bot] commented on PR #4380:
URL: https://github.com/apache/hive/pull/4380#issuecomment-1878824768
## [](https://sonarcloud.
ramesh0201 commented on code in PR #4755:
URL: https://github.com/apache/hive/pull/4755#discussion_r1442988267
##
ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java:
##
@@ -76,8 +76,8 @@
* Handles transaction related duties of the Driver.
*/
class DriverTxnHandler
ramesh0201 commented on code in PR #4755:
URL: https://github.com/apache/hive/pull/4755#discussion_r1442987243
##
common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java:
##
@@ -207,6 +241,14 @@ public Map getStartTimes() {
return ImmutableMap.copyOf(startTimes);
}
ramesh0201 commented on code in PR #4755:
URL: https://github.com/apache/hive/pull/4755#discussion_r1442986918
##
common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java:
##
@@ -152,10 +178,18 @@ public long perfLogEnd(String callerName, String method) {
* @return long
ramesh0201 commented on code in PR #4755:
URL: https://github.com/apache/hive/pull/4755#discussion_r1442985426
##
common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java:
##
@@ -129,9 +133,31 @@ public static void setPerfLogger(PerfLogger
resetPerfLogger) {
* @param m
ramesh0201 commented on code in PR #4755:
URL: https://github.com/apache/hive/pull/4755#discussion_r1442984613
##
common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java:
##
@@ -92,6 +94,8 @@ public class PerfLogger {
protected final Map startTimes = new ConcurrentHas
sonarcloud[bot] commented on PR #4740:
URL: https://github.com/apache/hive/pull/4740#issuecomment-1878797904
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #4920:
URL: https://github.com/apache/hive/pull/4920#issuecomment-1878556744
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #4913:
URL: https://github.com/apache/hive/pull/4913#issuecomment-1878551649
## [](https://sonarcloud.
sonarcloud[bot] commented on PR #4950:
URL: https://github.com/apache/hive/pull/4950#issuecomment-1878429641
## [](https://sonarcloud.
abstractdog merged PR #4907:
URL: https://github.com/apache/hive/pull/4907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach
abstractdog commented on code in PR #4920:
URL: https://github.com/apache/hive/pull/4920#discussion_r1442615686
##
data/conf/iceberg/llap/hive-site.xml:
##
@@ -38,10 +38,12 @@
A base for other temporary directories.
+
Review Comment:
thanks @zhangbutao !
abstractdog commented on PR #4937:
URL: https://github.com/apache/hive/pull/4937#issuecomment-1878298661
> sincere apologies @abstractdog and @sunchao! I run locally those tests and
passed and missed those failures in the jenkins. Will fix the issues.
okok, thanks @yigress , @sunchao
30 matches
Mail list logo
