Re: [PR] HIVE-27999: Upgrade to Java 17 to run sonar analysis [hive]

2024-01-17 Thread via GitHub
wecharyu commented on PR #5004: URL: https://github.com/apache/hive/pull/5004#issuecomment-1897934743 > Error when running: 'node -v'. Is Node.js available during analysis?: Cannot run program "node": error=2, No such file or directory @zhangbutao This error also exists in the origina

Re: [PR] HIVE-27960:Invalid function error when using custom udaf [hive]

2024-01-17 Thread via GitHub
sonarcloud[bot] commented on PR #4981: URL: https://github.com/apache/hive/pull/4981#issuecomment-1897883679 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28001: Fix the flaky test TestLeaderElection [hive]

2024-01-17 Thread via GitHub
dengzhhu653 merged PR #5011: URL: https://github.com/apache/hive/pull/5011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-27999: Upgrade to Java 17 to run sonar analysis [hive]

2024-01-17 Thread via GitHub
SourabhBadhya commented on PR #5004: URL: https://github.com/apache/hive/pull/5004#issuecomment-1897851466 I think this patch also introduced these 3 new test failures related to timestamp in the current master branch - http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/

Re: [PR] HIVE-28001: Fix the flaky test TestLeaderElection [hive]

2024-01-17 Thread via GitHub
dengzhhu653 commented on PR #5011: URL: https://github.com/apache/hive/pull/5011#issuecomment-1897821164 The tests failed is caused by Sonar check, no other tests are failed in the latest run, will merge this PR soon. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] HIVE-27991: Utilise FanoutWriters when inserting records in an Iceberg table when the records are unsorted [hive]

2024-01-17 Thread via GitHub
sonarcloud[bot] commented on PR #4988: URL: https://github.com/apache/hive/pull/4988#issuecomment-1897782678 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27749: Addendum: Fix INSERT query [hive]

2024-01-17 Thread via GitHub
sonarcloud[bot] commented on PR #5009: URL: https://github.com/apache/hive/pull/5009#issuecomment-189494 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27960:Invalid function error when using custom udaf [hive]

2024-01-17 Thread via GitHub
sonarcloud[bot] commented on PR #4981: URL: https://github.com/apache/hive/pull/4981#issuecomment-1897602551 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28001: Fix the flaky test TestLeaderElection [hive]

2024-01-17 Thread via GitHub
dengzhhu653 commented on code in PR #5011: URL: https://github.com/apache/hive/pull/5011#discussion_r1456697991 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/LeaderElectionContext.java: ## @@ -42,12 +42,12 @@ public class LeaderEl

Re: [PR] HIVE-27994: Optimize renaming the partitioned table [hive]

2024-01-17 Thread via GitHub
saihemanth-cloudera commented on code in PR #4995: URL: https://github.com/apache/hive/pull/4995#discussion_r1456676913 ## ql/src/test/queries/clientpositive/rename_table.q: ## @@ -0,0 +1,40 @@ +--! qt:dataset:src +--! qt:dataset:part +-- This test verifies that if the table aft

Re: [PR] HIVE-27994: Optimize renaming the partitioned table [hive]

2024-01-17 Thread via GitHub
saihemanth-cloudera commented on code in PR #4995: URL: https://github.com/apache/hive/pull/4995#discussion_r1456676913 ## ql/src/test/queries/clientpositive/rename_table.q: ## @@ -0,0 +1,40 @@ +--! qt:dataset:src +--! qt:dataset:part +-- This test verifies that if the table aft

Re: [PR] HIVE-27960:Invalid function error when using custom udaf [hive]

2024-01-17 Thread via GitHub
tc-gaoxiong commented on PR #4981: URL: https://github.com/apache/hive/pull/4981#issuecomment-1897553696 Just code one line, but so hard. I am sorry for those stupid operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] HIVE-27852: Backport of HIVE-27324: Hive query with NOT IN condition is giving incorrect results [hive]

2024-01-17 Thread via GitHub
github-actions[bot] closed pull request #4853: HIVE-27852: Backport of HIVE-27324: Hive query with NOT IN condition is giving incorrect results URL: https://github.com/apache/hive/pull/4853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] HIVE-27847: Casting NUMERIC types to TIMESTAMP is prohibited [hive]

2024-01-17 Thread via GitHub
github-actions[bot] closed pull request #4851: HIVE-27847: Casting NUMERIC types to TIMESTAMP is prohibited URL: https://github.com/apache/hive/pull/4851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HIVE-27637: Compare highest write ID of compaction records when tryin… [hive]

2024-01-17 Thread via GitHub
sonarcloud[bot] commented on PR #4740: URL: https://github.com/apache/hive/pull/4740#issuecomment-1897246567 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27512: CalciteSemanticException.UnsupportedFeature enum to capital [hive]

2024-01-17 Thread via GitHub
aturoczy commented on code in PR #4894: URL: https://github.com/apache/hive/pull/4894#discussion_r1456549702 ## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java: ## @@ -30,12 +30,20 @@ public class CalciteSemanticException extends SemanticEx

Re: [PR] HIVE-28001: Fix the flaky test TestLeaderElection [hive]

2024-01-17 Thread via GitHub
saihemanth-cloudera commented on code in PR #5011: URL: https://github.com/apache/hive/pull/5011#discussion_r1456547617 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/LeaderElectionContext.java: ## @@ -42,12 +42,12 @@ public class

Re: [PR] HIVE-27749: Addendum: Fix INSERT query [hive]

2024-01-17 Thread via GitHub
aturoczy commented on PR #5009: URL: https://github.com/apache/hive/pull/5009#issuecomment-1896820227 Can we move ahead with this change as the test is executed properly? cc: @ayushtkn @deniskuzZ @SourabhBadhya @abstractdog -- This is an automated message from the Apache Gi

Re: [PR] HIVE-27775: DirectSQL and JDO results are different when fetching par… [hive]

2024-01-17 Thread via GitHub
aturoczy commented on PR #4959: URL: https://github.com/apache/hive/pull/4959#issuecomment-1896812063 Can we pay attention to this issue pls? It is a blocker for Hive4 release. cc: @dengzhhu653 @abstractdog @zabetak @ayushtkn @nrg4878 -- This is an automated message from the Apach

Re: [PR] HIVE-27773 get_valid_write_ids is being called multiple times for a single query [hive]

2024-01-17 Thread via GitHub
sonarcloud[bot] commented on PR #4787: URL: https://github.com/apache/hive/pull/4787#issuecomment-1896639772 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28008: Missing try-with-resources in ParquetHiveSerDe [hive]

2024-01-17 Thread via GitHub
sonarcloud[bot] commented on PR #5013: URL: https://github.com/apache/hive/pull/5013#issuecomment-1896365067 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27637: Compare highest write ID of compaction records when tryin… [hive]

2024-01-17 Thread via GitHub
sonarcloud[bot] commented on PR #4740: URL: https://github.com/apache/hive/pull/4740#issuecomment-1896336789 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28001: Fix the flaky test TestLeaderElection [hive]

2024-01-17 Thread via GitHub
deniskuzZ commented on PR #5011: URL: https://github.com/apache/hive/pull/5011#issuecomment-1896163300 @dengzhhu653, not related to current PR, however, shouldn't we initialize TxnHandler.connPoolCompactor only on leader HMS similar to CompactorPMF? More like a follow-up to HIVE-26509 --

Re: [PR] HIVE-27999: Upgrade to Java 17 to run sonar analysis [hive]

2024-01-17 Thread via GitHub
zhangbutao commented on PR #5004: URL: https://github.com/apache/hive/pull/5004#issuecomment-1895989076 It looks like sonar still failed after upgrading jdk. http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5009/5/pipeline/414 `[2024-01-17T13:06:33.547Z]

[PR] HIVE-28008 - added missing try-with-resources in ParuetHiveSerDe [hive]

2024-01-17 Thread via GitHub
mlorek opened a new pull request, #5013: URL: https://github.com/apache/hive/pull/5013 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the change a

[PR] WIP: Dont review [hive]

2024-01-17 Thread via GitHub
akshat0395 opened a new pull request, #5012: URL: https://github.com/apache/hive/pull/5012 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the chan

Re: [PR] HIVE-27984: Support backward compatibility of hms thrift struct about column stats [hive]

2024-01-17 Thread via GitHub
zhangbutao commented on PR #4984: URL: https://github.com/apache/hive/pull/4984#issuecomment-1895488001 Can i request your review? @ayushtkn @dengzhhu653 @deniskuzZ Thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HIVE-27481: Addendum: Fix post-refactor issues [hive]

2024-01-17 Thread via GitHub
veghlaci05 commented on code in PR #5010: URL: https://github.com/apache/hive/pull/5010#discussion_r1455027488 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/jdbc/MultiDataSourceJdbcResource.java: ## @@ -191,32 +191,23 @@ public Integ

Re: [PR] HIVE-27960:Invalid function error when using custom udaf [hive]

2024-01-17 Thread via GitHub
tc-gaoxiong commented on PR #4981: URL: https://github.com/apache/hive/pull/4981#issuecomment-1895382136 > @tc-gaoxiong You can rebase this PR to get a green CI. Thanks !!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] HIVE-27986: Generated file name no longer depend on attemptid. [hive]

2024-01-17 Thread via GitHub
zhengchenyu commented on PR #4986: URL: https://github.com/apache/hive/pull/4986#issuecomment-1895379210 @abstractdog Can you please review the proposal in https://issues.apache.org/jira/browse/HIVE-27985? -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] HIVE-21520: Query 'Submit plan' time reported is incorrect [hive]

2024-01-17 Thread via GitHub
abstractdog merged PR #4996: URL: https://github.com/apache/hive/pull/4996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-27960:Invalid function error when using custom udaf [hive]

2024-01-17 Thread via GitHub
zhangbutao commented on PR #4981: URL: https://github.com/apache/hive/pull/4981#issuecomment-1895341564 @tc-gaoxiong You can rebase this PR to get a green CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] HIVE-26713: StringExpr ArrayIndexOutOfBoundsException with LIKE '%xxx%' [hive]

2024-01-17 Thread via GitHub
zhangbutao commented on PR #4999: URL: https://github.com/apache/hive/pull/4999#issuecomment-1895341385 @ryukobayashi You can rebase this PR to get a green CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] HIVE-27999: Upgrade to Java 17 to run sonar analysis [hive]

2024-01-17 Thread via GitHub
zabetak closed pull request #5004: HIVE-27999: Upgrade to Java 17 to run sonar analysis URL: https://github.com/apache/hive/pull/5004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] HIVE-27489: HPL/SQL does not support table aliases on column names in loops. [hive]

2024-01-17 Thread via GitHub
mdayakar commented on code in PR #5005: URL: https://github.com/apache/hive/pull/5005#discussion_r1454876791 ## hplsql/src/main/java/org/apache/hive/hplsql/Stmt.java: ## @@ -957,7 +957,11 @@ public Integer forCursor(HplsqlParser.For_cursor_stmtContext ctx) { int cols = q