Re: [PR] HIVE-28238: Open Hive ACID txn only for transactional resources [hive]

2024-06-02 Thread via GitHub
kasakrisz commented on code in PR #5216: URL: https://github.com/apache/hive/pull/5216#discussion_r1619115966 ## ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java: ## @@ -360,10 +360,13 @@ protected void checkResult(String[][] expectedResult, String query, bool

Re: [PR] [WIP] Calcite upgrade 1.33 [hive]

2024-06-02 Thread via GitHub
sonarcloud[bot] commented on PR #5196: URL: https://github.com/apache/hive/pull/5196#issuecomment-2144323317 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28276: Iceberg:Make Iceberg split threads configurable when table scanning [hive]

2024-06-02 Thread via GitHub
sonarcloud[bot] commented on PR #5260: URL: https://github.com/apache/hive/pull/5260#issuecomment-2144174320 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-27346: Getting exception for wildcard (*) search for database and table name [hive]

2024-06-02 Thread via GitHub
dengzhhu653 commented on PR #4326: URL: https://github.com/apache/hive/pull/4326#issuecomment-2144150204 @DanielZhu58 do you have any idea of why need to make the `dbName` as a pattern here? do we need to fix the document if possible? -- This is an automated message from the Apache Git Se

Re: [PR] HIVE-28276: Iceberg:Make Iceberg split threads configurable when table scanning [hive]

2024-06-02 Thread via GitHub
zhangbutao commented on code in PR #5260: URL: https://github.com/apache/hive/pull/5260#discussion_r1623702703 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java: ## @@ -220,6 +233,7 @@ public List getSplits(JobContext context) {

Re: [PR] HIVE-27847: Casting NUMERIC types to TIMESTAMP is prohibited [hive]

2024-06-02 Thread via GitHub
dengzhhu653 commented on PR #4851: URL: https://github.com/apache/hive/pull/4851#issuecomment-2144082165 Would anyone be willing to take over this PR since we have no heard from basapuram-kumar? cc @okumin @zratkai -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] HIVE-27512: CalciteSemanticException.UnsupportedFeature enum to capital [hive]

2024-06-02 Thread via GitHub
github-actions[bot] commented on PR #4894: URL: https://github.com/apache/hive/pull/4894#issuecomment-2144078765 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-28276: Iceberg:Make Iceberg split threads configurable when table scanning [hive]

2024-06-02 Thread via GitHub
deniskuzZ commented on code in PR #5260: URL: https://github.com/apache/hive/pull/5260#discussion_r1623491589 ## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java: ## @@ -220,6 +233,7 @@ public List getSplits(JobContext context) {

Re: [PR] WIP: Dont review [hive]

2024-06-02 Thread via GitHub
sonarcloud[bot] commented on PR #5012: URL: https://github.com/apache/hive/pull/5012#issuecomment-2143849371 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.

Re: [PR] HIVE-28194: Regenerate HS2 thrift port in TestRetryingThriftCLIServiceClient [hive]

2024-06-02 Thread via GitHub
sonarcloud[bot] commented on PR #5205: URL: https://github.com/apache/hive/pull/5205#issuecomment-2143768561 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.