abstractdog merged PR #5680:
URL: https://github.com/apache/hive/pull/5680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach
abstractdog commented on PR #5680:
URL: https://github.com/apache/hive/pull/5680#issuecomment-2798521610
merged to master, thanks @SourabhBadhya , @kokila-19 , @aturoczy for the
reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sonarqubecloud[bot] commented on PR #5748:
URL: https://github.com/apache/hive/pull/5748#issuecomment-2798513000
## [](https://sonarcl
SourabhBadhya commented on code in PR #5742:
URL: https://github.com/apache/hive/pull/5742#discussion_r2040576550
##
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java:
##
@@ -257,7 +257,7 @@ public List
getAllInstancesOrdered(boolean cons
SourabhBadhya commented on PR #5743:
URL: https://github.com/apache/hive/pull/5743#issuecomment-2798506927
`equals()` is used to check the object content, `==` does a comparision on
the object reference. Using `equals()` is the right programming paradigm.
I did a small test for confir
SourabhBadhya commented on PR #5765:
URL: https://github.com/apache/hive/pull/5765#issuecomment-2798484493
I would consider running a flaky test Jenkins job for determining whether
the fix will resolve the issue. Please consider using this Jenkins job -
https://ci.hive.apache.org/blue/organ
sonarqubecloud[bot] commented on PR #5621:
URL: https://github.com/apache/hive/pull/5621#issuecomment-2798478311
## [](https://sonarcl
SourabhBadhya commented on code in PR #5765:
URL: https://github.com/apache/hive/pull/5765#discussion_r2040557331
##
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
##
@@ -557,6 +558,12 @@ public static StructField getStandardStructFieldRe
sonarqubecloud[bot] commented on PR #5621:
URL: https://github.com/apache/hive/pull/5621#issuecomment-2798362475
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #5709:
URL: https://github.com/apache/hive/pull/5709#issuecomment-2798305016
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #5766:
URL: https://github.com/apache/hive/pull/5766#issuecomment-2798294828
## [](https://sonarcl
github-actions[bot] commented on PR #5635:
URL: https://github.com/apache/hive/pull/5635#issuecomment-2798254316
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the
sonarqubecloud[bot] commented on PR #5765:
URL: https://github.com/apache/hive/pull/5765#issuecomment-2798045756
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #5758:
URL: https://github.com/apache/hive/pull/5758#issuecomment-2798090281
## [](https://sonarcl
soumyakanti3578 commented on code in PR #5721:
URL: https://github.com/apache/hive/pull/5721#discussion_r2040232072
##
ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsDropTask.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
sonarqubecloud[bot] commented on PR #5763:
URL: https://github.com/apache/hive/pull/5763#issuecomment-2797876074
## [](https://sonarcl
difin commented on PR #5762:
URL: https://github.com/apache/hive/pull/5762#issuecomment-2797734005
> LGTM. Can you change the title to reflect shade plugin upgrade as well,
while merging
Sure, done.
--
This is an automated message from the Apache Git Service.
To respond to the mess
difin merged PR #5762:
URL: https://github.com/apache/hive/pull/5762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
sonarqubecloud[bot] commented on PR #5764:
URL: https://github.com/apache/hive/pull/5764#issuecomment-2797737192
## [](https://sonarcl
RITIKHARIANI opened a new pull request, #5765:
URL: https://github.com/apache/hive/pull/5765
### What changes were proposed in this pull request?
This pull request addresses non-deterministic behavior in the
`TestLazyBinaryColumnarSerDe#testLazyBinaryColumnarSerDeWithEmptyBinary`
zratkai commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2039683320
##
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##
@@ -5839,13 +5842,33 @@ public HiveMetaHook getHook(
}
};
+if ("rest".equals(conf.get("me
difin commented on code in PR #5758:
URL: https://github.com/apache/hive/pull/5758#discussion_r2039833207
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/IPStackUtils.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundatio
sonarqubecloud[bot] commented on PR #5621:
URL: https://github.com/apache/hive/pull/5621#issuecomment-2797310740
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #5762:
URL: https://github.com/apache/hive/pull/5762#issuecomment-2797269219
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #5709:
URL: https://github.com/apache/hive/pull/5709#issuecomment-2797124713
## [](https://sonarcl
zratkai commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2039682557
##
packaging/src/docker/conf/hive-site.xml:
##
@@ -60,4 +60,20 @@
metastore.metastore.event.db.notification.api.auth
false
+
+iceberg.c
zratkai commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2039681751
##
packaging/src/docker/conf/hive-site.xml:
##
@@ -60,4 +60,20 @@
metastore.metastore.event.db.notification.api.auth
false
+
+iceberg.c
zratkai commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2039676656
##
standalone-metastore/metastore-common/pom.xml:
##
@@ -333,6 +333,27 @@
slf4j-simple
test
+
Review Comment:
Iceberg's RESTCatalog needs it ru
zratkai commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2039674270
##
packaging/src/docker/conf/hive-site.xml:
##
@@ -60,4 +60,20 @@
metastore.metastore.event.db.notification.api.auth
false
+
+iceberg.c
zratkai commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2039675203
##
iceberg/iceberg-catalog/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##
@@ -1054,7 +1054,7 @@ public void testSetSnapshotSummary() throws Exception {
kasakrisz commented on code in PR #5749:
URL: https://github.com/apache/hive/pull/5749#discussion_r2038903234
##
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##
@@ -3800,19 +3800,25 @@ private RelNode genGBLogicalPlan(QB qb, RelNode srcRel)
throws SemanticEx
mszurap opened a new pull request, #5764:
URL: https://github.com/apache/hive/pull/5764
### What changes were proposed in this pull request?
The secondary connection factory is used for schema generation, and for
value generation operations. Under normal circumstances 2 connections sh
kasakrisz merged PR #5757:
URL: https://github.com/apache/hive/pull/5757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.
zabetak commented on code in PR #5757:
URL: https://github.com/apache/hive/pull/5757#discussion_r2039517667
##
ql/src/test/queries/clientpositive/cbo_join_transitive_pred_loop_1.q:
##
@@ -1,5 +1,8 @@
set hive.optimize.join.disjunctive.transitive.predicates.pushdown=false;
+--
zabetak commented on code in PR #5757:
URL: https://github.com/apache/hive/pull/5757#discussion_r2039513776
##
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveUnixTimestampSqlOperator.java:
##
@@ -29,13 +29,9 @@
*/
public class HiveUnixTimestampSqlOpe
sonarqubecloud[bot] commented on PR #5763:
URL: https://github.com/apache/hive/pull/5763#issuecomment-2796623720
## [](https://sonarcl
kasakrisz commented on code in PR #5721:
URL: https://github.com/apache/hive/pull/5721#discussion_r2039328547
##
ql/src/test/results/clientpositive/llap/drop_histogram_stats_for_columns.q.out:
##
@@ -0,0 +1,307 @@
+PREHOOK: query: CREATE TABLE test_stats (a string, b int, c doub
kasakrisz commented on code in PR #5721:
URL: https://github.com/apache/hive/pull/5721#discussion_r2039328547
##
ql/src/test/results/clientpositive/llap/drop_histogram_stats_for_columns.q.out:
##
@@ -0,0 +1,307 @@
+PREHOOK: query: CREATE TABLE test_stats (a string, b int, c doub
sonarqubecloud[bot] commented on PR #5549:
URL: https://github.com/apache/hive/pull/5549#issuecomment-2796601172
## [](https://sonarcl
kasakrisz commented on code in PR #5721:
URL: https://github.com/apache/hive/pull/5721#discussion_r2039320194
##
ql/src/test/queries/clientpositive/drop_stats_for_columns.q:
##
@@ -0,0 +1,36 @@
+create table t1(i int, j int, k int);
+
+alter table t1 update statistics set('numRo
kasakrisz commented on code in PR #5721:
URL: https://github.com/apache/hive/pull/5721#discussion_r2039317244
##
ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsDropTask.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
sonarqubecloud[bot] commented on PR #5012:
URL: https://github.com/apache/hive/pull/5012#issuecomment-2796517682
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #5754:
URL: https://github.com/apache/hive/pull/5754#issuecomment-2796415009
## [](https://sonarcl
ayushtkn commented on code in PR #5758:
URL: https://github.com/apache/hive/pull/5758#discussion_r2039155609
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/IPStackUtils.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Founda
deniskuzZ closed pull request #5599: HIVE-28697: upgrade Jetty to
9.4.56.v20240826
URL: https://github.com/apache/hive/pull/5599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
deniskuzZ commented on PR #5599:
URL: https://github.com/apache/hive/pull/5599#issuecomment-2796224120
upgraded in #5720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
deniskuzZ merged PR #5720:
URL: https://github.com/apache/hive/pull/5720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.
ramitg254 closed pull request #5747: Hive 28871: Upgrade json-smart and resolve
CVE-2024-57699
URL: https://github.com/apache/hive/pull/5747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
sonarqubecloud[bot] commented on PR #5749:
URL: https://github.com/apache/hive/pull/5749#issuecomment-2796152380
## [](https://sonarcl
kasakrisz commented on code in PR #5757:
URL: https://github.com/apache/hive/pull/5757#discussion_r2039016434
##
ql/src/test/queries/clientpositive/cbo_join_transitive_pred_loop_1.q:
##
@@ -1,5 +1,8 @@
set hive.optimize.join.disjunctive.transitive.predicates.pushdown=false;
+
kasakrisz commented on code in PR #5757:
URL: https://github.com/apache/hive/pull/5757#discussion_r2039009489
##
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveUnixTimestampSqlOperator.java:
##
@@ -29,13 +29,9 @@
*/
public class HiveUnixTimestampSqlO
sonarqubecloud[bot] commented on PR #5757:
URL: https://github.com/apache/hive/pull/5757#issuecomment-2796104356
## [](https://sonarcl
zabetak commented on code in PR #5757:
URL: https://github.com/apache/hive/pull/5757#discussion_r2038947469
##
ql/src/test/queries/clientpositive/cbo_join_transitive_pred_loop_1.q:
##
@@ -1,5 +1,8 @@
set hive.optimize.join.disjunctive.transitive.predicates.pushdown=false;
+--
53 matches
Mail list logo
