Re: [PR] HIVE-29013: [ICEBERG] Data type info is not correct in Error message for tinyint, smallint [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5866: URL: https://github.com/apache/hive/pull/5866#issuecomment-2972295128 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-29017: Restore ability to prevent metastore metrics startup queries [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5869: URL: https://github.com/apache/hive/pull/5869#issuecomment-2972291174 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-29017: Restore ability to prevent metastore metrics startup queries [hive]

2025-06-13 Thread via GitHub
cnauroth commented on PR #5869: URL: https://github.com/apache/hive/pull/5869#issuecomment-2972240199 @dengzhhu653 and @nrg4878 , this is another request to review bug fix changes in a similar area around the metastore metrics. Thank you. -- This is an automated message from the Apache Gi

[PR] HIVE-29017: Restore ability to prevent metastore metrics startup queries [hive]

2025-06-13 Thread via GitHub
cnauroth opened a new pull request, #5869: URL: https://github.com/apache/hive/pull/5869 ### What changes were proposed in this pull request? Restore configuration `metastore.initial.metadata.count.enabled` to prevent metastore metrics startup queries ### Why are the changes ne

Re: [PR] HIVE-29008: CI logs do not display information about test execution [hive]

2025-06-13 Thread via GitHub
zhangbutao commented on PR #5862: URL: https://github.com/apache/hive/pull/5862#issuecomment-2972193744 BTW, Will this test execution log output increase the duration of the CI execution? I hope not. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Iceberg: Fix wrong row count in table statistics after upgrade to 1.9.1 [hive]

2025-06-13 Thread via GitHub
zhangbutao commented on PR #5867: URL: https://github.com/apache/hive/pull/5867#issuecomment-2972149179 > Iceberg 1.9.1 introduced optimization to ManifestFilterManager which doesn't delete orphan positional delete files from the manifest when committing changes to Iceberg table. These dele

Re: [PR] HIVE-29010: Correct assignment of metastore object count metrics [hive]

2025-06-13 Thread via GitHub
dengzhhu653 merged PR #5863: URL: https://github.com/apache/hive/pull/5863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] fix: Ensure consistent test behavior with NonDex by resolving nondeterministic field order [hive]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #5765: URL: https://github.com/apache/hive/pull/5765#issuecomment-2972031264 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-28874 Incorrect comparison in LlapFixedRegistryImpl [hive]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #5742: URL: https://github.com/apache/hive/pull/5742#issuecomment-2972031300 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-13748: TypeInfoParser cannot handle symbols in the field name of STRUCT [hive]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #5767: URL: https://github.com/apache/hive/pull/5767#issuecomment-2972031237 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the

Re: [PR] HIVE-28957: Enhance TestHiveMetaStoreAuthorizer [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5819: URL: https://github.com/apache/hive/pull/5819#issuecomment-2971958746 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] TimestampWritableV2 should be set to a proper time zone [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5868: URL: https://github.com/apache/hive/pull/5868#issuecomment-2971899766 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] Iceberg: Fix wrong row count in table statistics after upgrade to 1.9.1 [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5867: URL: https://github.com/apache/hive/pull/5867#issuecomment-2971846191 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

[PR] TimestampWritableV2 should be set to a proper time zone [hive]

2025-06-13 Thread via GitHub
vrozov opened a new pull request, #5868: URL: https://github.com/apache/hive/pull/5868 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this pa

Re: [PR] HIVE-29013: [ICEBERG] Data type info is not correct in Error message for tinyint, smallint [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5866: URL: https://github.com/apache/hive/pull/5866#issuecomment-2971533372 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-29008: CI logs do not display information about test execution [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5862: URL: https://github.com/apache/hive/pull/5862#issuecomment-2971322291 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-28665: Iceberg: Upgrade iceberg version to 1.9.1 [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5846: URL: https://github.com/apache/hive/pull/5846#issuecomment-2971316485 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
KiranVelumuri commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2145713643 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5059,6 +5084,22 @@ private RowResolver getColForInsertStmtSpec(Map targetCol2 retur

Re: [PR] HIVE-28986: Upgrade to Tez 0.10.5 [hive]

2025-06-13 Thread via GitHub
abstractdog merged PR #5802: URL: https://github.com/apache/hive/pull/5802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] Iceberg: Fix wrong row count in table statistics after upgrade to 1.9.1 [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5867: URL: https://github.com/apache/hive/pull/5867#issuecomment-2970965280 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-28993: use lower case datanucleus.plugin.pluginRegistryBundleCheck [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5847: URL: https://github.com/apache/hive/pull/5847#issuecomment-2970853949 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

[PR] Iceberg: Fix wrong row count in table statistics after upgrade to 1.9.1 [hive]

2025-06-13 Thread via GitHub
difin opened a new pull request, #5867: URL: https://github.com/apache/hive/pull/5867 ### What changes were proposed in this pull request? Patched iceberg-core with the version of ManifestFilterManager that doesn't contain an optimization which keeps orphan delete files in man

Re: [PR] HIVE-28987: Iceberg: A faulty query predicate can compromise transaction isolation [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on PR #5839: URL: https://github.com/apache/hive/pull/5839#issuecomment-2970530022 > > @kasakrisz, @zabetak isn't it possible to find a top level table scan operator for a specific table based on DAG plan? > > @deniskuzZ I'm not fully understand the functionality i

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2145163355 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5000,6 +5002,29 @@ && isRegex(unescapeIdentifier(expr.getChild(1).getText()), conf)) {

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2145176843 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5059,6 +5084,22 @@ private RowResolver getColForInsertStmtSpec(Map targetCol2 return ne

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2145163355 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5000,6 +5002,29 @@ && isRegex(unescapeIdentifier(expr.getChild(1).getText()), conf)) {

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2145165858 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5000,6 +5002,29 @@ && isRegex(unescapeIdentifier(expr.getChild(1).getText()), conf)) {

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2145146869 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5085,6 +5126,11 @@ RowResolver handleInsertStatementSpec(List col_list, String dest,

Re: [PR] HIVE-29013: [ICEBERG] Data type info is not correct in Error message for tinyint, smallint [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5866: URL: https://github.com/apache/hive/pull/5866#issuecomment-2970470997 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2145129293 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5059,6 +5084,22 @@ private RowResolver getColForInsertStmtSpec(Map targetCol2 return ne

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2144761955 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5059,6 +5084,22 @@ private RowResolver getColForInsertStmtSpec(Map targetCol2 return ne

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2145129293 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5059,6 +5084,22 @@ private RowResolver getColForInsertStmtSpec(Map targetCol2 return ne

Re: [PR] HIVE-28986: Upgrade to Tez 0.10.5 [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5802: URL: https://github.com/apache/hive/pull/5802#issuecomment-2970383246 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] [WIP] HIVE-27473: Rewrite MetaStoreClients to be composable [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5771: URL: https://github.com/apache/hive/pull/5771#issuecomment-2970372329 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-28987: Iceberg: A faulty query predicate can compromise transaction isolation [hive]

2025-06-13 Thread via GitHub
kasakrisz commented on PR #5839: URL: https://github.com/apache/hive/pull/5839#issuecomment-2970226780 > @kasakrisz, @zabetak isn't it possible to find a top level table scan operator for a specific table based on DAG plan? @deniskuzZ I'm not fully understand the functionality int

Re: [PR] HIVE-28658 Add Iceberg REST Catalog client support [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5628: URL: https://github.com/apache/hive/pull/5628#discussion_r2144938273 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java: ## @@ -95,8 +105,9 @@ public interface IMetaStoreClient ex

Re: [PR] HIVE-28665: Iceberg: Upgrade iceberg version to 1.9.1 [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5846: URL: https://github.com/apache/hive/pull/5846#issuecomment-2970143754 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-29007 Fix NPE in TezSessionPoolManager [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5860: URL: https://github.com/apache/hive/pull/5860#issuecomment-2970053495 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-28595: Not able to insert data with hive.cbo.enable=false [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5651: URL: https://github.com/apache/hive/pull/5651#discussion_r2144761955 ## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ## @@ -5059,6 +5084,22 @@ private RowResolver getColForInsertStmtSpec(Map targetCol2 return ne

[PR] HIVE-29013: [ICEBERG] Data type info is not correct in Error message for tinyint, smallint [hive]

2025-06-13 Thread via GitHub
arorasimran0309 opened a new pull request, #5866: URL: https://github.com/apache/hive/pull/5866 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ##

Re: [PR] HIVE-28657: Use protoc-jar-maven-plugin to generate protobuf classes [hive]

2025-06-13 Thread via GitHub
deniskuzZ merged PR #5589: URL: https://github.com/apache/hive/pull/5589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

Re: [PR] HIVE-29011: Update project README and Copyright year [hive]

2025-06-13 Thread via GitHub
deniskuzZ merged PR #5864: URL: https://github.com/apache/hive/pull/5864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

Re: [PR] HIVE-28658 Add Iceberg REST Catalog client support [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5628: URL: https://github.com/apache/hive/pull/5628#discussion_r2144715712 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java: ## @@ -588,8 +622,8 @@ void truncateTable(String dbName, S

Re: [PR] HIVE-28658 Add Iceberg REST Catalog client support [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5628: URL: https://github.com/apache/hive/pull/5628#discussion_r2144713758 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java: ## @@ -566,15 +600,15 @@ default void dropTable(String cat

Re: [PR] HIVE-28658 Add Iceberg REST Catalog client support [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5628: URL: https://github.com/apache/hive/pull/5628#discussion_r2144713758 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java: ## @@ -566,15 +600,15 @@ default void dropTable(String cat

Re: [PR] HIVE-28956 : Use msdb.alterPartitions() API and implement batching for alter table add column cascade command [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5814: URL: https://github.com/apache/hive/pull/5814#discussion_r2142687666 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java: ## @@ -409,23 +409,41 @@ public List run(List input) throw

Re: [PR] HIVE-28956 : Use msdb.alterPartitions() API and implement batching for alter table add column cascade command [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5814: URL: https://github.com/apache/hive/pull/5814#discussion_r2142687666 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java: ## @@ -409,23 +409,41 @@ public List run(List input) throw

Re: [PR] HIVE-28807-Fix-user-level-explain-failure [hive]

2025-06-13 Thread via GitHub
deniskuzZ merged PR #5684: URL: https://github.com/apache/hive/pull/5684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

Re: [PR] HIVE-28658 Add Iceberg REST Catalog client support [hive]

2025-06-13 Thread via GitHub
zratkai commented on code in PR #5628: URL: https://github.com/apache/hive/pull/5628#discussion_r2144644799 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java: ## @@ -588,8 +622,8 @@ void truncateTable(String dbName, Str

Re: [PR] HIVE-28658 Add Iceberg REST Catalog client support [hive]

2025-06-13 Thread via GitHub
zratkai commented on code in PR #5628: URL: https://github.com/apache/hive/pull/5628#discussion_r2144639085 ## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java: ## @@ -566,15 +600,15 @@ default void dropTable(String catNa

Re: [PR] HIVE-27275: Provide docker image for HMS [hive]

2025-06-13 Thread via GitHub
deniskuzZ merged PR #5834: URL: https://github.com/apache/hive/pull/5834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

Re: [PR] HIVE-27275: Provide docker image for HMS [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on PR #5834: URL: https://github.com/apache/hive/pull/5834#issuecomment-2969692174 @abstractdog, I'll merge this PR now to establish a foundation, as I expect some improvements. - refactor rest-catalog to not depend on metastore-server - introduce NONE authenticat

Re: [PR] HIVE-27275: Provide docker image for HMS [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5834: URL: https://github.com/apache/hive/pull/5834#discussion_r2144573021 ## standalone-metastore/metastore-server/src/docker/Dockerfile: ## @@ -0,0 +1,85 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribut

Re: [PR] HIVE-27275: Provide docker image for HMS [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5834: URL: https://github.com/apache/hive/pull/5834#discussion_r2144573021 ## standalone-metastore/metastore-server/src/docker/Dockerfile: ## @@ -0,0 +1,85 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribut

Re: [PR] HIVE-27275: Provide docker image for HMS [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5834: URL: https://github.com/apache/hive/pull/5834#discussion_r2144569211 ## standalone-metastore/metastore-server/src/docker/Dockerfile: ## @@ -0,0 +1,85 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribut

Re: [PR] [WIP] HIVE-28892: Fix spotbugs issues in hive-standalone-metastore-common with spo… [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5865: URL: https://github.com/apache/hive/pull/5865#issuecomment-2969662492 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] HIVE-28735: Propagated the exception properly from hash table-loader threads to main thread [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5845: URL: https://github.com/apache/hive/pull/5845#discussion_r2144560966 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java: ## @@ -307,9 +320,19 @@ public void load(MapJoinTableContainer[]

Re: [PR] HIVE-28735: Propagated the exception properly from hash table-loader threads to main thread [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5845: URL: https://github.com/apache/hive/pull/5845#discussion_r2144535516 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java: ## @@ -307,9 +320,19 @@ public void load(MapJoinTableContainer[]

Re: [PR] HIVE-28735: Propagated the exception properly from hash table-loader threads to main thread [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5845: URL: https://github.com/apache/hive/pull/5845#discussion_r2144534275 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java: ## @@ -83,6 +88,10 @@ public VectorMapJoinFastHashTableLoader()

Re: [PR] HIVE-29009: Intermittent CI timeouts while running tests - disable TestHttpSamlAuthentication [hive]

2025-06-13 Thread via GitHub
abstractdog merged PR #5861: URL: https://github.com/apache/hive/pull/5861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-28735: Propagated the exception properly from hash table-loader threads to main thread [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5845: URL: https://github.com/apache/hive/pull/5845#discussion_r2144510508 ## ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastHashTableLoader.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

Re: [PR] HIVE-28735: Propagated the exception properly from hash table-loader threads to main thread [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5845: URL: https://github.com/apache/hive/pull/5845#discussion_r2144498891 ## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java: ## @@ -307,9 +320,19 @@ public void load(MapJoinTableContainer[]

Re: [PR] HIVE-28735: Propagated the exception properly from hash table-loader threads to main thread [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5845: URL: https://github.com/apache/hive/pull/5845#discussion_r2144491622 ## ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastHashTableLoader.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

Re: [PR] HIVE-28735: Propagated the exception properly from hash table-loader threads to main thread [hive]

2025-06-13 Thread via GitHub
deniskuzZ commented on code in PR #5845: URL: https://github.com/apache/hive/pull/5845#discussion_r2144491622 ## ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/TestVectorMapJoinFastHashTableLoader.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

Re: [PR] HIVE-28665: Iceberg: Upgrade iceberg version to 1.9.1 [hive]

2025-06-13 Thread via GitHub
kasakrisz commented on code in PR #5846: URL: https://github.com/apache/hive/pull/5846#discussion_r2144480584 ## iceberg/iceberg-handler/src/test/results/positive/llap/iceberg_minor_compaction_unpartitioned.q.out: ## @@ -273,13 +273,13 @@ Table Parameters: compactor.thre

Re: [PR] HIVE-28665: Iceberg: Upgrade iceberg version to 1.9.1 [hive]

2025-06-13 Thread via GitHub
kasakrisz commented on code in PR #5846: URL: https://github.com/apache/hive/pull/5846#discussion_r2144477630 ## iceberg/iceberg-handler/src/test/results/positive/llap/iceberg_minor_compaction_partition_evolution.q.out: ## @@ -296,15 +296,15 @@ Table Parameters: compacto

Re: [PR] HIVE-28665: Iceberg: Upgrade iceberg version to 1.9.1 [hive]

2025-06-13 Thread via GitHub
kasakrisz commented on code in PR #5846: URL: https://github.com/apache/hive/pull/5846#discussion_r2144477630 ## iceberg/iceberg-handler/src/test/results/positive/llap/iceberg_minor_compaction_partition_evolution.q.out: ## @@ -296,15 +296,15 @@ Table Parameters: compacto

Re: [PR] HIVE-29002: Upgrade parquet to 1.15.2 to be in sync with iceberg 1.9.1 [hive]

2025-06-13 Thread via GitHub
deniskuzZ merged PR #5858: URL: https://github.com/apache/hive/pull/5858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

[PR] [WIP] HIVE-28892: Fix spotbugs issues in hive-standalone-metastore-common with spo… [hive]

2025-06-13 Thread via GitHub
kokila-19 opened a new pull request, #5865: URL: https://github.com/apache/hive/pull/5865 …tbugs-maven-plugin 4.8.6.6 ### What changes were proposed in this pull request? This task involves addressing and resolving SpotBugs static analysis warnings in the standalone-metastore-commo

Re: [PR] HIVE-29010: Correct assignment of metastore object count metrics [hive]

2025-06-13 Thread via GitHub
sonarqubecloud[bot] commented on PR #5863: URL: https://github.com/apache/hive/pull/5863#issuecomment-2969309342 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl