sonarqubecloud[bot] commented on PR #6058:
URL: https://github.com/apache/hive/pull/6058#issuecomment-3251022927
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3251801962
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #5995:
URL: https://github.com/apache/hive/pull/5995#issuecomment-3251065287
## [](https://sonarcl
github-actions[bot] closed pull request #5904: HIVE-29048: Increase default
pool and queue size of HS2 Background Async Threadpool.
URL: https://github.com/apache/hive/pull/5904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2320337203
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##
@@ -195,29 +189,29 @@ public static boolean dropTable(Configuration conf,
Properties pr
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2320365270
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache Software Foundation
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2320317250
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache Software Foundation
konstantinb commented on code in PR #6014:
URL: https://github.com/apache/hive/pull/6014#discussion_r2320309737
##
ql/src/test/queries/clientpositive/lateral_view_cbo_ppd_filter_loss.q:
##
@@ -0,0 +1,33 @@
+-- SORT_QUERY_RESULTS
+-- HIVE-29084: LATERAL VIEW cartesian product sch
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2320306781
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/client/HiveRESTCatalogClient.java:
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Foundati
difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2320291448
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2320284405
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
saihemanth-cloudera opened a new pull request, #6058:
URL: https://github.com/apache/hive/pull/6058
…VE-28967
### What changes were proposed in this pull request?
Making the RELOAD event backward compatible
### Why are the changes needed?
Clients like impal
difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2305093367
##
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##
@@ -221,7 +222,8 @@ static void setPartitionSpec(TableMetadata metadata,
Ma
difin commented on PR #6048:
URL: https://github.com/apache/hive/pull/6048#issuecomment-3250492543
LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
sonarqubecloud[bot] commented on PR #5995:
URL: https://github.com/apache/hive/pull/5995#issuecomment-3250320989
## [](https://sonarcl
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2319783942
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2319783942
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2319783942
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##
@@ -0,0 +1,437 @@
+/*
+ * Licensed to the Apache Software Foundation
sonarqubecloud[bot] commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3250206404
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #6057:
URL: https://github.com/apache/hive/pull/6057#issuecomment-3250048487
## [](https://sonarcl
wecharyu commented on code in PR #6047:
URL: https://github.com/apache/hive/pull/6047#discussion_r2319480663
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java:
##
@@ -65,57 +64,35 @@ public class HdfsUtils {
/**
*
zabetak opened a new pull request, #6057:
URL: https://github.com/apache/hive/pull/6057
### Why are the changes needed?
In most real deployments the authorization is always enabled so it makes
sense to set the default value to true. Changing the default is important for
testing purposes
Aggarwal-Raghav commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3249658086
@ayushtkn, can you please take a look once!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sonarqubecloud[bot] commented on PR #6043:
URL: https://github.com/apache/hive/pull/6043#issuecomment-3249598957
## [](https://sonarcl
sonarqubecloud[bot] commented on PR #6011:
URL: https://github.com/apache/hive/pull/6011#issuecomment-3249335385
## [](https://sonarcl
zhangbutao commented on PR #5774:
URL: https://github.com/apache/hive/pull/5774#issuecomment-3249150635
> @zhangbutao, this PR is not yet ready for review, right?
Yes, I'll optimize this PR later.
--
This is an automated message from the Apache Git Service.
To respond to the messag
deniskuzZ commented on code in PR #4899:
URL: https://github.com/apache/hive/pull/4899#discussion_r2318872476
##
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezProcessor.java:
##
@@ -293,6 +293,13 @@ protected void initializeAndRunProcessor(Map inputs,
rproc.run();
abstractdog commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3249077938
thanks @Aggarwal-Raghav, I'm good now with the pom.xml changes, but haven't
followed if you've reached consensus with @ayushtkn on the other aspect of this
PR, please let me know guys
deniskuzZ commented on code in PR #6011:
URL: https://github.com/apache/hive/pull/6011#discussion_r2318829665
##
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java:
##
@@ -305,6 +305,14 @@ public void abort() {
} else {
LOG.info("reducer not se
sonarqubecloud[bot] commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3249044347
## [](https://sonarcl
Aggarwal-Raghav commented on code in PR #6054:
URL: https://github.com/apache/hive/pull/6054#discussion_r2318778000
##
pom.xml:
##
@@ -1715,6 +1715,16 @@
true
Banned log4j:log4j dependency/transitive dependency
was found!
deniskuzZ commented on PR #5774:
URL: https://github.com/apache/hive/pull/5774#issuecomment-3248958233
@zhangbutao, this PR is not yet ready for review, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
zhangbutao opened a new pull request, #5774:
URL: https://github.com/apache/hive/pull/5774
Currently, this PR only focus on from clause against the HMS native catalog,
and does not involve other external catalogs such as JDBC catalog or Iceberg
REST catalog.
We can have s
sonarqubecloud[bot] commented on PR #6056:
URL: https://github.com/apache/hive/pull/6056#issuecomment-3248897087
## [](https://sonarcl
abstractdog commented on code in PR #6054:
URL: https://github.com/apache/hive/pull/6054#discussion_r2318649913
##
pom.xml:
##
@@ -1715,6 +1715,16 @@
true
Banned log4j:log4j dependency/transitive dependency
was found!
+
Aggarwal-Raghav commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3248810586
UT passed in local.
```
cd hcatalog/hcatalog-pig-adapter ; mvn clean test
-Dtest=TestTextFileHCatLoader,TestRCFileHCatLoader,TestAvroHCatLoader,TestSequenceFileHCatLoader,TestP
abstractdog commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3248718702
> > can you please check if there is an include/exclude possibility in
bannedDependencies to allow old jline transitively through pig only, does it
make sense?
>
> we can use `inc
Aggarwal-Raghav commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3248640388
> can you please check if there is an include/exclude possibility in
bannedDependencies to allow old jline transitively through pig only, does it
make sense?
we can use `inclu
sonarqubecloud[bot] commented on PR #6043:
URL: https://github.com/apache/hive/pull/6043#issuecomment-3248640293
## [](https://sonarcl
thomasrebele opened a new pull request, #6056:
URL: https://github.com/apache/hive/pull/6056
### What changes were proposed in this pull request?
Fix a bug in HiveCalciteUtil#hasAnyExpressionFromRightSide.
### Why are the changes needed?
Adding constants to the SELECT clause shou
sonarqubecloud[bot] commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3246763166
## [](https://sonarcl
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2316031914
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache Software Foundation
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2316192766
##
iceberg/iceberg-handler/src/test/queries/positive/iceberg_rest_catalog.q:
##
@@ -0,0 +1,68 @@
+-- SORT_QUERY_RESULTS
+-- Mask neededVirtualColumns due to non-strict o
abstractdog commented on code in PR #6011:
URL: https://github.com/apache/hive/pull/6011#discussion_r2315532912
##
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java:
##
@@ -343,12 +351,10 @@ void close() {
}
try {
- if (isAborted()) {
-
kasakrisz commented on code in PR #6055:
URL: https://github.com/apache/hive/pull/6055#discussion_r2318092008
##
ql/src/test/queries/clientpositive/antijoin_conversion.q:
##
@@ -20,3 +20,31 @@ select n.* from n left outer join t on (n.a=t.a) where
cast(t.a as float) is nul
sel
sonarqubecloud[bot] commented on PR #6052:
URL: https://github.com/apache/hive/pull/6052#issuecomment-3242137908
## [](https://sonarcl
KiranVelumuri commented on PR #6052:
URL: https://github.com/apache/hive/pull/6052#issuecomment-3248079513
@ayushtkn Got it. Thank you for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
deniskuzZ commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2316031914
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/BaseHiveIcebergMetaHook.java:
##
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache Software Foundation
Aggarwal-Raghav commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3248057863
> > In conclusion,
> > if Hadoop Classpath first, then jline 3.9.0 is picked => hadoop has to
upgrade jline to 3.25.0
> > if hive classpath is first, then we are all good.
>
ayushtkn commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3248054653
> In conclusion,
if Hadoop Classpath first, then jline 3.9.0 is picked => hadoop has to
upgrade jline to 3.25.0
if hive classpath is first, then we are all good.
So, the solutio
sonarqubecloud[bot] commented on PR #6022:
URL: https://github.com/apache/hive/pull/6022#issuecomment-3248055025
## [](https://sonarcl
Aggarwal-Raghav commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3248030965
Thanks for the reply @ayushtkn.
> I don't understand in that scope or for this problem why are we playing
with Jline-2.x?
In hive packaging, both jline 2.11 and jline 3.
ayushtkn commented on PR #6052:
URL: https://github.com/apache/hive/pull/6052#issuecomment-3248023735
thanx for the details. I don't feel the need for this, but I won't come in
the way. If others feel it is good, I won't be blocking this
--
This is an automated message from the Apache Git
abstractdog commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3247989766
> 1. **The unit test failures in this PR are relevant.** The reason for this
is that Pig version 0.16.0 uses jline 1.x. The jline dependency is being
excluded from Pig due to an enforcer
ayushtkn commented on PR #6054:
URL: https://github.com/apache/hive/pull/6054#issuecomment-3247976929
> As Hadoop has jline 3.9.0**, in my setup** it was getting picked first
compared to 3.25.0 from hive. Causing NoSuchMethodError
org.jline.reader.EndOfFileException#getPartialLine() check
sonarqubecloud[bot] commented on PR #6043:
URL: https://github.com/apache/hive/pull/6043#issuecomment-3247958105
## [](https://sonarcl
56 matches
Mail list logo
