[GitHub] [hive] SourabhBadhya commented on a diff in pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…

2023-01-19 Thread GitBox
SourabhBadhya commented on code in PR #3964: URL: https://github.com/apache/hive/pull/3964#discussion_r1082076397 ## ql/src/test/queries/clientpositive/parquet_alter_column_type.q: ## @@ -0,0 +1,122 @@ +create table test_parquet_1 (id decimal) stored as parquet; +insert into

[GitHub] [hive] SourabhBadhya commented on a diff in pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…

2023-01-18 Thread GitBox
SourabhBadhya commented on code in PR #3964: URL: https://github.com/apache/hive/pull/3964#discussion_r1073502143 ## ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java: ## @@ -676,6 +676,39 @@ private int getScale(PrimitiveType type) {