[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1396811870 Hi @zabetak @abstractdog Kindly review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1386852115 @abstractdog @zabetak Please review and merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1383130293 @abstractdog @zabetak Can you please review and merge this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1382281016 @cnauroth Something like this we can think about:  -- This is an

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1382262775 @cnauroth Got it. Thank your for approving this PR. So essentially how can we add something like a finally block in the test? I think we can try to add that in the TestNegativeLlapLocalC

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1382028203 I think I got the issue. Maybe because at the end we are calling "dfs -rm" instead of "rm" therefore it is not able to delete the file from the local file system. Is it not expected ?

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1381626473 Hi @cnauroth you are correct  How to resolve this? Do you kno

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1381604999 @cnauroth Checking this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1378845778 @cnauroth @abstractdog Removed all the old commits and pushed latest change to the branch. Can you please check this and approve -- This is an automated message from the Apache Git

[GitHub] [hive] amanraj2520 commented on pull request #3900: HIVE-26895 : Backport of HIVE-22899: Make sure qtests clean up copied files from test directories

amanraj2520 commented on PR #3900: URL: https://github.com/apache/hive/pull/3900#issuecomment-1374915533 @cnauroth Yes I raised it just to check a few tests like compustat_avro.q which were failing due to formatting issues. Will re-raise this PR. That's why I did not ask anyone to review.