[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-10-09 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-705332460 @kgyrtkirk Thank you taking your time in reviewing this! Yes, +1 from my side for (deprecating) kyro stuffs. String based approach is cool. But i am not sure how easy or

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-10-07 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-705332460 @kgyrtkirk Thank you taking your time in reviewing this! Yes, +1 from my side for (deprecating) kyro stuffs. String based approach is cool. But i am not sure how easy or

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-09-29 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-700514324 @kgyrtkirk So the new approach is that - We have introduced a new flag **metastore.decode.filter.expression.tostring** which will deserizalize the expr byte array to

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-09-13 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-691810348 @kgyrtkirk Ping for re-review request! This is an automated message from the Apache Git Service. To respond to

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-09-09 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-689608550 @kgyrtkirk I have changed the approach, Please take a look at the new implementation. This is an automated

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-09-07 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-688263050 @kgyrtkirk Ping for review request~ This is an automated message from the Apache Git Service. To respond to

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-08-31 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-683657845 @kgyrtkirk Ping for review request! This is an automated message from the Apache Git Service. To respond to

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-08-24 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-679059909 @kgyrtkirk Could you please review the PR? This is an automated message from the Apache Git Service. To

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-08-17 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-674757864 @kgyrtkirk @jcamachor Ping for review request! This is an automated message from the Apache Git Service. To

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-08-10 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-671311247 @kgyrtkirk Gentle reminder regarding PR review! This is an automated message from the Apache Git Service. To

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-08-03 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-668367912 @kgyrtkirk @jcamachor Could you please take a look? This is an automated message from the Apache Git Service.

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-07-26 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-664119961 @kgyrtkirk Could you please take a look? This is an automated message from the Apache Git Service. To respond

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-07-23 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-663063475 @kgyrtkirk FYI. Test failure **schema_evol_text_vec_part_all_primitive.q** seems unrelated and passed on local run

[GitHub] [hive] shameersss1 commented on pull request #1271: HIVE-23851: MSCK REPAIR Command With Partition Filtering Fails While Dropping Partitions

2020-07-20 Thread GitBox
shameersss1 commented on pull request #1271: URL: https://github.com/apache/hive/pull/1271#issuecomment-660941689 @kgyrtkirk Could you please take a look? This is an automated message from the Apache Git Service. To respond