[GitHub] [arrow] emkornfield commented on pull request #7143: ARROW-8504: [C++] [wip]Add BitRunReader and use it in parquet

2020-05-13 Thread GitBox
emkornfield commented on pull request #7143: URL: https://github.com/apache/arrow/pull/7143#issuecomment-628384930 @wesm OK, I did a little bit more in depth sampling. And it looks like this new algorithm is a win for 0-5% nulls, then a regression until someplace between 45-50% nulls then

[GitHub] [arrow] github-actions[bot] commented on pull request #7175: ARROW-8794: [C++] Expand performance coverage of parquet to arrow reading

2020-05-13 Thread GitBox
github-actions[bot] commented on pull request #7175: URL: https://github.com/apache/arrow/pull/7175#issuecomment-628383810 https://issues.apache.org/jira/browse/ARROW-8794 This is an automated message from the Apache Git Serv

[GitHub] [arrow] emkornfield opened a new pull request #7175: ARROW-8794: [C++] Expand performance coverage of parquet to arrow reading

2020-05-13 Thread GitBox
emkornfield opened a new pull request #7175: URL: https://github.com/apache/arrow/pull/7175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow] emkornfield commented on pull request #6985: ARROW-8413: [C++][Parquet] Refactor Generating validity bitmap for values column

2020-05-13 Thread GitBox
emkornfield commented on pull request #6985: URL: https://github.com/apache/arrow/pull/6985#issuecomment-628370216 @pitrou Doing some investigation it appears GCC 7.5 fails to auto-vectorize the comparison of levels. GCC 8.3 does autovectorize. Are we stuck with GCC 7.5 for releasing?

[GitHub] [arrow] emkornfield commented on pull request #6985: ARROW-8413: [C++][Parquet] Refactor Generating validity bitmap for values column

2020-05-13 Thread GitBox
emkornfield commented on pull request #6985: URL: https://github.com/apache/arrow/pull/6985#issuecomment-628364641 OK it seems like clang and GCC perform very differently. Clang-8 new code vs master: ![image](https://user-images.githubusercontent.com/17869838/81888336-ff86bb00-955

[GitHub] [arrow] jianxind closed pull request #7029: ARROW-8579 [C++] SIMD for spaced decoding and encoding.

2020-05-13 Thread GitBox
jianxind closed pull request #7029: URL: https://github.com/apache/arrow/pull/7029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] jianxind commented on pull request #7029: ARROW-8579 [C++] SIMD for spaced decoding and encoding.

2020-05-13 Thread GitBox
jianxind commented on pull request #7029: URL: https://github.com/apache/arrow/pull/7029#issuecomment-628354475 Close this one. Revisit later util a runtime SIMD is settled. I guess I can commit the unit test and benchmark parts firstly, then we can get some survive during revisit at least

[GitHub] [arrow] wesm commented on issue #1437: pyarrow.lib.ArrowIOError: Unable to load libjvm

2020-05-13 Thread GitBox
wesm commented on issue #1437: URL: https://github.com/apache/arrow/issues/1437#issuecomment-628347885 Please open a JIRA issue if you are having trouble and describe your environment and how to reproduce the problem, as well as providing a complete traceback

[GitHub] [arrow] eromoe commented on issue #1437: pyarrow.lib.ArrowIOError: Unable to load libjvm

2020-05-13 Thread GitBox
eromoe commented on issue #1437: URL: https://github.com/apache/arrow/issues/1437#issuecomment-628347149 There is no such file. Could you add a message to tell people how to deal this problem when raise Exception ? This i

[GitHub] [arrow] nealrichardson closed pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
nealrichardson closed pull request #7173: URL: https://github.com/apache/arrow/pull/7173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] nealrichardson commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
nealrichardson commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628341961 This is doing the right thing; `homebrew-cpp-autobrew` doesn't get run and doesn't need to pass, but the formula is building correctly. ---

[GitHub] [arrow] kiszk edited a comment on pull request #7171: ARROW-8790: [C++][CI] Enable arrow-flight-test on s390x

2020-05-13 Thread GitBox
kiszk edited a comment on pull request #7171: URL: https://github.com/apache/arrow/pull/7171#issuecomment-628322963 ~~Sure, I will remove `allow_failures` in this PR, too. ~~ This is an automated message from the Apache Git S

[GitHub] [arrow] github-actions[bot] commented on pull request #7174: ARROW-8776: [FlightRPC] Fix discrepancy between headers in Java and C++

2020-05-13 Thread GitBox
github-actions[bot] commented on pull request #7174: URL: https://github.com/apache/arrow/pull/7174#issuecomment-628328841 https://issues.apache.org/jira/browse/ARROW-8776 This is an automated message from the Apache Git Serv

[GitHub] [arrow] lidavidm opened a new pull request #7174: ARROW-8776: [FlightRPC] Fix discrepancy between headers in Java and C++

2020-05-13 Thread GitBox
lidavidm opened a new pull request #7174: URL: https://github.com/apache/arrow/pull/7174 A Java service, on a failed unary-unary call, will not send separate headers and trailers, but will instead consolidate headers into the trailers. So C++ clients should check both for headers and trail

[GitHub] [arrow] kou commented on a change in pull request #7171: ARROW-8790: [C++][CI] Enable arrow-flight-test on s390x

2020-05-13 Thread GitBox
kou commented on a change in pull request #7171: URL: https://github.com/apache/arrow/pull/7171#discussion_r424814217 ## File path: .travis.yml ## @@ -47,11 +47,14 @@ jobs: env: ARCH: s390x ARROW_CI_MODULES: "CPP" -ARROW_FLIGHT: "OFF" +A

[GitHub] [arrow] kiszk commented on pull request #7171: ARROW-8790: [C++][CI] Enable arrow-flight-test on s390x

2020-05-13 Thread GitBox
kiszk commented on pull request #7171: URL: https://github.com/apache/arrow/pull/7171#issuecomment-628322963 Sure, I will remove `allow_failures` in this PR, too. This is an automated message from the Apache Git Service. To r

[GitHub] [arrow] kiszk commented on a change in pull request #7171: ARROW-8790: [C++][CI] Enable arrow-flight-test on s390x

2020-05-13 Thread GitBox
kiszk commented on a change in pull request #7171: URL: https://github.com/apache/arrow/pull/7171#discussion_r424811290 ## File path: .travis.yml ## @@ -47,11 +47,14 @@ jobs: env: ARCH: s390x ARROW_CI_MODULES: "CPP" -ARROW_FLIGHT: "OFF" +

[GitHub] [arrow] kou commented on a change in pull request #7171: ARROW-8790: [C++][CI] Enable arrow-flight-test on s390x

2020-05-13 Thread GitBox
kou commented on a change in pull request #7171: URL: https://github.com/apache/arrow/pull/7171#discussion_r424804727 ## File path: .travis.yml ## @@ -92,6 +95,9 @@ script: -e ARROW_PARQUET=${ARROW_PARQUET:-ON} \ -e PARQUET_BUILD_EXAMPLES=${PARQUET_BUILD_EXAMPLES:

[GitHub] [arrow] github-actions[bot] commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
github-actions[bot] commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628294604 Revision: e4039bf47a0ac6b1ee21f345a616065f589940f3 Submitted crossbow builds: [ursa-labs/crossbow @ actions-257](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
nealrichardson commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628294178 @github-actions crossbow submit homebrew-cpp* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
github-actions[bot] commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628285254 Revision: 3e744877b254abd47a12a55c003e6137bf112237 Submitted crossbow builds: [ursa-labs/crossbow @ actions-256](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
nealrichardson commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628284805 @github-actions crossbow submit homebrew-cpp* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
github-actions[bot] commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628269768 Revision: 7949e198f567387dd9b071d56312ab368c8a33ff Submitted crossbow builds: [ursa-labs/crossbow @ actions-255](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
nealrichardson commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628269240 @github-actions crossbow submit homebrew-cpp* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kou commented on pull request #7170: WIP Verify 0.17.1 rc

2020-05-13 Thread GitBox
kou commented on pull request #7170: URL: https://github.com/apache/arrow/pull/7170#issuecomment-628267550 For 404 on downloading binaries: We need to remove `nuget` from `dev/release/download_rc_binaries.py: ```diff diff --git a/dev/release/download_rc_binaries.py b/dev/release/

[GitHub] [arrow] kszucs commented on pull request #7166: ARROW-8786: [Packaging][rpm] Use bundled zstd in the CentOS 8 build

2020-05-13 Thread GitBox
kszucs commented on pull request #7166: URL: https://github.com/apache/arrow/pull/7166#issuecomment-628265650 Thanks Kou! This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [arrow] kszucs commented on a change in pull request #7166: ARROW-8786: [Packaging][rpm] Use bundled zstd in the CentOS 8 build

2020-05-13 Thread GitBox
kszucs commented on a change in pull request #7166: URL: https://github.com/apache/arrow/pull/7166#discussion_r424752886 ## File path: dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in ## @@ -219,7 +222,9 @@ Requires: brotli Requires: gflags Requires: glog

[GitHub] [arrow] kou closed pull request #7166: ARROW-8786: [Packaging][rpm] Use bundled zstd in the CentOS 8 build

2020-05-13 Thread GitBox
kou closed pull request #7166: URL: https://github.com/apache/arrow/pull/7166 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] github-actions[bot] commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
github-actions[bot] commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628262899 https://issues.apache.org/jira/browse/ARROW-8717 This is an automated message from the Apache Git Serv

[GitHub] [arrow] github-actions[bot] commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
github-actions[bot] commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628259034 Revision: af1d5b61ad9ed9aa70eccc3aad28c52ef3697552 Submitted crossbow builds: [ursa-labs/crossbow @ actions-254](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] nealrichardson commented on pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
nealrichardson commented on pull request #7173: URL: https://github.com/apache/arrow/pull/7173#issuecomment-628258515 @github-actions crossbow submit homebrew-cpp* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] nealrichardson opened a new pull request #7173: ARROW-8717: [CI][Packaging] Add build dependency on boost to homebrew

2020-05-13 Thread GitBox
nealrichardson opened a new pull request #7173: URL: https://github.com/apache/arrow/pull/7173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow] nealrichardson closed pull request #7107: ARROW-8604: [R][CI] Update CI to use R 4.0

2020-05-13 Thread GitBox
nealrichardson closed pull request #7107: URL: https://github.com/apache/arrow/pull/7107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow] github-actions[bot] commented on pull request #7166: ARROW-8786: [Packaging][rpm] Use bundled zstd in the CentOS 8 build

2020-05-13 Thread GitBox
github-actions[bot] commented on pull request #7166: URL: https://github.com/apache/arrow/pull/7166#issuecomment-628231825 Revision: e4ecf59cb9221c3e2e4be605ff3f212ef5e78829 Submitted crossbow builds: [ursa-labs/crossbow @ actions-253](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] kou commented on pull request #7166: ARROW-8786: [Packaging][rpm] Use bundled zstd in the CentOS 8 build

2020-05-13 Thread GitBox
kou commented on pull request #7166: URL: https://github.com/apache/arrow/pull/7166#issuecomment-628231045 @github-actions crossbow submit centos-8-* This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] kou commented on pull request #7166: ARROW-8786: [Packaging][rpm] Use bundled zstd in the CentOS 8 build

2020-05-13 Thread GitBox
kou commented on pull request #7166: URL: https://github.com/apache/arrow/pull/7166#issuecomment-628229499 We also need to disable `Requires: libzstd`. I'll push the change. This is an automated message from the Apache Git

[GitHub] [arrow] kou commented on pull request #7166: ARROW-8786: [Packaging][rpm] Use bundled zstd in the CentOS 8 build

2020-05-13 Thread GitBox
kou commented on pull request #7166: URL: https://github.com/apache/arrow/pull/7166#issuecomment-628229213 It seems that zstd is added to the BaseOS repository and removed from EPEL: https://src.fedoraproject.org/rpms/zstd/c/2eaa0955a5176319f2a59294ee339cb2fff87bc5?branch=epel8 Bu

[GitHub] [arrow] emkornfield commented on pull request #7132: ARROW-3509: [C++] Standardize on using Field in Type/Array

2020-05-13 Thread GitBox
emkornfield commented on pull request #7132: URL: https://github.com/apache/arrow/pull/7132#issuecomment-628196883 @bkietz yeah, I just pushed what I hope will catch the rest. This is an automated message from the Apach

[GitHub] [arrow] pauldix commented on pull request #7064: ARROW-6945: [Rust] WIP: Add initial skeleton for Rust integration tests

2020-05-13 Thread GitBox
pauldix commented on pull request #7064: URL: https://github.com/apache/arrow/pull/7064#issuecomment-628194857 @nevi-me they're not compared byte for byte, the Go tester is invoked, which has its own file reader read in the file and try to marshal it and compare with the JSON representatio