[GitHub] [arrow] emkornfield commented on pull request #6985: ARROW-8413: [C++][Parquet] Refactor Generating validity bitmap for values column

2020-05-16 Thread GitBox
emkornfield commented on pull request #6985: URL: https://github.com/apache/arrow/pull/6985#issuecomment-629737181 @pitrou https://github.com/apache/arrow/pull/6985/commits/a36dc55efe3def27eef413b8e17567ec400a01ff adds a benchmark. Should be cherry-pickable to a clean branch for compariso

[GitHub] [arrow] houqp commented on a change in pull request #7133: ARROW-8744: [Rust] handle channel close in parquet batch iterator

2020-05-16 Thread GitBox
houqp commented on a change in pull request #7133: URL: https://github.com/apache/arrow/pull/7133#discussion_r426196139 ## File path: rust/arrow/src/record_batch.rs ## @@ -36,7 +36,7 @@ use crate::error::{ArrowError, Result}; /// serialization and computation functions, possib

[GitHub] [arrow] kou commented on a change in pull request #7202: ARROW-8825: [C++] Fix compilation for Wunused-paraemter flag

2020-05-16 Thread GitBox
kou commented on a change in pull request #7202: URL: https://github.com/apache/arrow/pull/7202#discussion_r426192648 ## File path: cpp/src/arrow/array.h ## @@ -798,7 +798,12 @@ class ARROW_EXPORT FixedSizeListArray : public Array { i += data_->offset; return static_c

[GitHub] [arrow] andygrove closed pull request #7200: ARROW-8821: [Rust] fix type cast for nested binary expression using Like, NotLike, Not operators

2020-05-16 Thread GitBox
andygrove closed pull request #7200: URL: https://github.com/apache/arrow/pull/7200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] andygrove commented on a change in pull request #7133: ARROW-8744: [Rust] handle channel close in parquet batch iterator

2020-05-16 Thread GitBox
andygrove commented on a change in pull request #7133: URL: https://github.com/apache/arrow/pull/7133#discussion_r426186878 ## File path: rust/arrow/src/record_batch.rs ## @@ -36,7 +36,7 @@ use crate::error::{ArrowError, Result}; /// serialization and computation functions, po

[GitHub] [arrow] github-actions[bot] commented on pull request #7206: ARROW-8827: [Rust] Add initial skeleton for Rust integration tests

2020-05-16 Thread GitBox
github-actions[bot] commented on pull request #7206: URL: https://github.com/apache/arrow/pull/7206#issuecomment-629691994 https://issues.apache.org/jira/browse/ARROW-8827 This is an automated message from the Apache Git Serv

[GitHub] [arrow] andygrove commented on pull request #7064: ARROW-6945: [Rust] WIP: Add initial skeleton for Rust integration tests

2020-05-16 Thread GitBox
andygrove commented on pull request #7064: URL: https://github.com/apache/arrow/pull/7064#issuecomment-629690900 @pauldix Never mind, I pulled your branch into mine and created a new PR here https://github.com/apache/arrow/pull/7206 which preserves your commits. --

[GitHub] [arrow] github-actions[bot] commented on pull request #7206: WIP: Add initial skeleton for Rust integration tests

2020-05-16 Thread GitBox
github-actions[bot] commented on pull request #7206: URL: https://github.com/apache/arrow/pull/7206#issuecomment-629690122 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] andygrove opened a new pull request #7206: WIP: Add initial skeleton for Rust integration tests

2020-05-16 Thread GitBox
andygrove opened a new pull request #7206: URL: https://github.com/apache/arrow/pull/7206 Created from original PR created by @pauldix * Adds Rust to Archery integration tests * arrow-json-integration-test runner with start of code to convert a JSON definition into a RecordBatch

[GitHub] [arrow] andygrove commented on pull request #7064: ARROW-6945: [Rust] WIP: Add initial skeleton for Rust integration tests

2020-05-16 Thread GitBox
andygrove commented on pull request #7064: URL: https://github.com/apache/arrow/pull/7064#issuecomment-629688732 @pauldix Any chance you could rebase this against the new `rust-integration-testing` branch, or give arrow committers permissions to push to your branch? -

[GitHub] [arrow] houqp commented on pull request #7200: ARROW-8821: [Rust] fix type cast for nexted binary expression using Like, NotLike, Not operators

2020-05-16 Thread GitBox
houqp commented on pull request #7200: URL: https://github.com/apache/arrow/pull/7200#issuecomment-629686800 @nevi-me @andygrove rebased on top of latest master, builds are passing now This is an automated message from the Ap

[GitHub] [arrow] github-actions[bot] commented on pull request #7202: ARROW-8825:[C++] fix compilation for Wunused-paraemter flag

2020-05-16 Thread GitBox
github-actions[bot] commented on pull request #7202: URL: https://github.com/apache/arrow/pull/7202#issuecomment-629680642 https://issues.apache.org/jira/browse/ARROW-8825 This is an automated message from the Apache Git Serv

[GitHub] [arrow] github-actions[bot] commented on pull request #7205: ARROW-8782: [Rust] Add benchmark crate

2020-05-16 Thread GitBox
github-actions[bot] commented on pull request #7205: URL: https://github.com/apache/arrow/pull/7205#issuecomment-629673929 https://issues.apache.org/jira/browse/ARROW-8782 This is an automated message from the Apache Git Serv

[GitHub] [arrow] github-actions[bot] commented on pull request #7204: [Rust] change simd_compare_op in comparison kernel to use bitmask SIMD operation to significantly improve performance

2020-05-16 Thread GitBox
github-actions[bot] commented on pull request #7204: URL: https://github.com/apache/arrow/pull/7204#issuecomment-629673934 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] andygrove opened a new pull request #7205: ARROW-8782: [Rust] Add benchmark crate

2020-05-16 Thread GitBox
andygrove opened a new pull request #7205: URL: https://github.com/apache/arrow/pull/7205 This PR adds a new crate for benchmarks based on the [New York Taxi and Limousine Commission](https://www1.nyc.gov/site/tlc/about/tlc-trip-record-data.page) data set. Currently, only DataFusio

[GitHub] [arrow] yordan-pavlov opened a new pull request #7204: [Rust] change simd_compare_op in comparison kernel to use bitmask SIMD operation to significantly improve performance

2020-05-16 Thread GitBox
yordan-pavlov opened a new pull request #7204: URL: https://github.com/apache/arrow/pull/7204 This pull request completes the SIMD implementation of the comparison kernel in simd_compare_op by using a bitmask SIMD operation instead of a for loop to copy the results of comparison. Pr

[GitHub] [arrow] hurricane1026 closed pull request #7202: fix compilation for Wunused-paraemter flag

2020-05-16 Thread GitBox
hurricane1026 closed pull request #7202: URL: https://github.com/apache/arrow/pull/7202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #7202: fix compilation for Wunused-paraemter flag

2020-05-16 Thread GitBox
github-actions[bot] commented on pull request #7202: URL: https://github.com/apache/arrow/pull/7202#issuecomment-629661941 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] github-actions[bot] commented on pull request #7203: ARROW-8822: [Rust] [DataFusion] Add InMemoryScan to LogicalPlan

2020-05-16 Thread GitBox
github-actions[bot] commented on pull request #7203: URL: https://github.com/apache/arrow/pull/7203#issuecomment-629661955 https://issues.apache.org/jira/browse/ARROW-8822 This is an automated message from the Apache Git Serv

[GitHub] [arrow] andygrove opened a new pull request #7203: ARROW-8822: [Rust] [DataFusion] Add InMemoryScan to LogicalPlan

2020-05-16 Thread GitBox
andygrove opened a new pull request #7203: URL: https://github.com/apache/arrow/pull/7203 Add InMemoryScan to LogicalPlan. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] hurricane1026 opened a new pull request #7202: fix compilation for Wunused-paraemter flag

2020-05-16 Thread GitBox
hurricane1026 opened a new pull request #7202: URL: https://github.com/apache/arrow/pull/7202 add a compiler hint to tell the compiler that the unused-parameter is by default. This is an automated message from the Apache Git

[GitHub] [arrow] hurricane1026 closed pull request #7201: change a useless parameter to anonymouse

2020-05-16 Thread GitBox
hurricane1026 closed pull request #7201: URL: https://github.com/apache/arrow/pull/7201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #7201: change a useless parameter to anonymouse

2020-05-16 Thread GitBox
github-actions[bot] commented on pull request #7201: URL: https://github.com/apache/arrow/pull/7201#issuecomment-629642401 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] hurricane1026 opened a new pull request #7201: change a useless parameter to anonymouse

2020-05-16 Thread GitBox
hurricane1026 opened a new pull request #7201: URL: https://github.com/apache/arrow/pull/7201 remove a useless named parameter to make -Werror -Wunsed-parameter flags passed *Otherwise* my project will not compiled done ... --

[GitHub] [arrow] paddyhoran commented on a change in pull request #6898: ARROW-8399: [Rust] Extend memory alignments to include other architectures

2020-05-16 Thread GitBox
paddyhoran commented on a change in pull request #6898: URL: https://github.com/apache/arrow/pull/6898#discussion_r426143335 ## File path: rust/arrow/src/memory.rs ## @@ -16,12 +16,125 @@ // under the License. //! Defines memory-related functions, such as allocate/deallocat

[GitHub] [arrow] nevi-me closed pull request #7186: ARROW-8808: [Rust] Fix divide by zero error in builder

2020-05-16 Thread GitBox
nevi-me closed pull request #7186: URL: https://github.com/apache/arrow/pull/7186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [arrow] nevi-me closed pull request #7198: ARROW-8818: [Rust] Failing to build on master due to Flatbuffers/Union issues

2020-05-16 Thread GitBox
nevi-me closed pull request #7198: URL: https://github.com/apache/arrow/pull/7198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th