zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429753826
##
File path:
java/dataset/src/main/java/org/apache/arrow/dataset/jni/JniLoader.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Found
kiszk commented on pull request #7266:
URL: https://github.com/apache/arrow/pull/7266#issuecomment-633398630
This change can solve the linkage issue on ARM and s390x in ARROW-8930 and
ARROW-8932.
This is an automated message
github-actions[bot] commented on pull request #7266:
URL: https://github.com/apache/arrow/pull/7266#issuecomment-633397696
https://issues.apache.org/jira/browse/ARROW-8932
This is an automated message from the Apache Git Serv
kiszk opened a new pull request #7266:
URL: https://github.com/apache/arrow/pull/7266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
maxburke commented on pull request #6935:
URL: https://github.com/apache/arrow/pull/6935#issuecomment-633363633
@rdettai / @sunchao / @andygrove Would it be possible to back this change
out? Since integrating it we have been getting crashes manifest in our
codebase. We've bisected the chan
github-actions[bot] commented on pull request #7265:
URL: https://github.com/apache/arrow/pull/7265#issuecomment-633361905
https://issues.apache.org/jira/browse/ARROW-8931
This is an automated message from the Apache Git Serv
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429553399
##
File path: cpp/src/jni/dataset/jni_wrapper.cpp
##
@@ -0,0 +1,517 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429717566
##
File path: cpp/.gitignore
##
@@ -24,6 +24,8 @@ cmake_install.cmake
build/
*-build/
Testing/
+cmake-build-debug/
Review comment:
done
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429715403
##
File path: cpp/src/arrow/dataset/discovery.h
##
@@ -238,5 +238,27 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public
DatasetFactory {
ut
github-actions[bot] commented on pull request #7265:
URL: https://github.com/apache/arrow/pull/7265#issuecomment-633352999
https://issues.apache.org/jira/browse/ARROW-8906
This is an automated message from the Apache Git Serv
houqp opened a new pull request #7265:
URL: https://github.com/apache/arrow/pull/7265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
guyuqi commented on a change in pull request #7121:
URL: https://github.com/apache/arrow/pull/7121#discussion_r429709020
##
File path: cpp/src/arrow/util/utf8.h
##
@@ -171,6 +172,99 @@ inline bool ValidateUTF8(const util::string_view& str) {
return ValidateUTF8(data, length)
wesm commented on pull request #7121:
URL: https://github.com/apache/arrow/pull/7121#issuecomment-633346288
@guyuqi thanks for this, I plan to use it to provide ASCII validation for
string kernels that can only handle ASCII inputs
--
wesm closed pull request #7121:
URL: https://github.com/apache/arrow/pull/7121
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
github-actions[bot] commented on pull request #7264:
URL: https://github.com/apache/arrow/pull/7264#issuecomment-633343370
https://issues.apache.org/jira/browse/ARROW-8926
This is an automated message from the Apache Git Serv
wesm commented on pull request #6578:
URL: https://github.com/apache/arrow/pull/6578#issuecomment-633343513
Sounds good. I am going to be mostly on vacation this week but I plan to
take up generalized array expressions and execution as a continuation of
ARROW-8792 when I return., so I hope
wesm opened a new pull request #7264:
URL: https://github.com/apache/arrow/pull/7264
I also fixed the `Arity` ctor to be explicit which I thought I'd done in
#7240 but it is taken care of here.
This is an automated message f
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429552370
##
File path: cpp/src/arrow/dataset/discovery.h
##
@@ -238,5 +238,27 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public
DatasetFactory {
ut
kiszk commented on pull request #7262:
URL: https://github.com/apache/arrow/pull/7262#issuecomment-67206
Looks good
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
mrkn commented on pull request #6578:
URL: https://github.com/apache/arrow/pull/6578#issuecomment-633324063
@wesm Thank you for informing. I will read the changes of Dataset API and
rewrite the expression part of this pull-request to fit the latest state.
-
zhouyuan commented on pull request #7260:
URL: https://github.com/apache/arrow/pull/7260#issuecomment-633320877
@kiszk thanks for fixing this!
This is an automated message from the Apache Git Service.
To respond to the messag
github-actions[bot] commented on pull request #7263:
URL: https://github.com/apache/arrow/pull/7263#issuecomment-633310179
https://issues.apache.org/jira/browse/ARROW-8927
This is an automated message from the Apache Git Serv
alexbaden opened a new pull request #7263:
URL: https://github.com/apache/arrow/pull/7263
Adds support for dictionary memo in `ReadRecordBatch` for CUDA IPC, passing
the memo directly to the `ipc::ReadRecordBatch` function. This allows one to
handle record batches with dictionaries, though
nevi-me commented on a change in pull request #7261:
URL: https://github.com/apache/arrow/pull/7261#discussion_r429678616
##
File path: rust/arrow/src/compute/kernels/comparison.rs
##
@@ -66,6 +66,31 @@ macro_rules! compare_op {
}};
}
+macro_rules! compare_op_scalar {
+
github-actions[bot] commented on pull request #7262:
URL: https://github.com/apache/arrow/pull/7262#issuecomment-633299431
https://issues.apache.org/jira/browse/ARROW-8911
This is an automated message from the Apache Git Serv
wesm opened a new pull request #7262:
URL: https://github.com/apache/arrow/pull/7262
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #7261:
URL: https://github.com/apache/arrow/pull/7261#issuecomment-633296713
https://issues.apache.org/jira/browse/ARROW-8907
This is an automated message from the Apache Git Serv
yordan-pavlov opened a new pull request #7261:
URL: https://github.com/apache/arrow/pull/7261
Currently comparing an array to a scalar / literal value using the
comparison operations defined in the comparison kernel here
https://github.com/apache/arrow/blob/master/rust/arrow/src/comput
wesm commented on a change in pull request #7121:
URL: https://github.com/apache/arrow/pull/7121#discussion_r429672945
##
File path: cpp/src/arrow/util/utf8.h
##
@@ -171,6 +172,99 @@ inline bool ValidateUTF8(const util::string_view& str) {
return ValidateUTF8(data, length);
kou closed pull request #7260:
URL: https://github.com/apache/arrow/pull/7260
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
wesm edited a comment on pull request #6578:
URL: https://github.com/apache/arrow/pull/6578#issuecomment-633293880
hello @mrkn and @kou -- since writing in
https://github.com/apache/arrow/commit/a66ab10aaf6570e2ebfe7b3e0b5ca2b5e2716cfe
the expression classes in arrow/datasets have been mad
wesm commented on pull request #6578:
URL: https://github.com/apache/arrow/pull/6578#issuecomment-633293880
hello @mrkn and @kou -- since writing in
https://github.com/apache/arrow/commit/a66ab10aaf6570e2ebfe7b3e0b5ca2b5e2716cfe#diff-a875fc42afdc43ec7979e3b49e27626d
the expression classes
wesm commented on pull request #6301:
URL: https://github.com/apache/arrow/pull/6301#issuecomment-633293198
Closing this since the work is being divided into separate PRs
This is an automated message from the Apache Git Servi
wesm closed pull request #6301:
URL: https://github.com/apache/arrow/pull/6301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on pull request #6465:
URL: https://github.com/apache/arrow/pull/6465#issuecomment-633292981
Closing since this has grown stale. Feel free to reopen again when the
issues have been addressed
This is an automat
wesm closed pull request #6465:
URL: https://github.com/apache/arrow/pull/6465
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on pull request #5880:
URL: https://github.com/apache/arrow/pull/5880#issuecomment-633292138
Closing this PR since it has grown stale. I think it would be worth defining
a public API for this, but we're going to have to take time to propose clean,
well-documented interfaces
wesm edited a comment on pull request #5880:
URL: https://github.com/apache/arrow/pull/5880#issuecomment-633292138
Closing this PR since it has grown stale. I think it would be worth defining
a public API for this, but we're going to have to take time to propose clean,
well-documented inte
wesm closed pull request #5880:
URL: https://github.com/apache/arrow/pull/5880
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm closed pull request #7216:
URL: https://github.com/apache/arrow/pull/7216
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm closed pull request #7255:
URL: https://github.com/apache/arrow/pull/7255
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm closed pull request #7244:
URL: https://github.com/apache/arrow/pull/7244
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm closed pull request #7259:
URL: https://github.com/apache/arrow/pull/7259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on pull request #7259:
URL: https://github.com/apache/arrow/pull/7259#issuecomment-633287774
+1. I'm merging this because it conflicts with
https://github.com/apache/arrow/pull/7258, and this makes `CallFunction`'s API
consistent with the other functions in `api_*.h`. If som
github-actions[bot] commented on pull request #7260:
URL: https://github.com/apache/arrow/pull/7260#issuecomment-633266180
https://issues.apache.org/jira/browse/ARROW-8924
This is an automated message from the Apache Git Serv
kiszk opened a new pull request #7260:
URL: https://github.com/apache/arrow/pull/7260
This PR avoids the potential int overflow due to int32 multiplication in
castDATE_date32().
In
https://github.com/apache/arrow/blob/master/cpp/src/gandiva/precompiled/time.cc#L461,
the following c
github-actions[bot] commented on pull request #7259:
URL: https://github.com/apache/arrow/pull/7259#issuecomment-633264321
https://issues.apache.org/jira/browse/ARROW-8923
This is an automated message from the Apache Git Serv
wesm opened a new pull request #7259:
URL: https://github.com/apache/arrow/pull/7259
This removes the burden of constructing an `ExecContext` in cases where you
are OK with the default options
This is an automated message fr
github-actions[bot] commented on pull request #7258:
URL: https://github.com/apache/arrow/pull/7258#issuecomment-633258564
https://issues.apache.org/jira/browse/ARROW-8918
This is an automated message from the Apache Git Serv
wesm opened a new pull request #7258:
URL: https://github.com/apache/arrow/pull/7258
This provides the `CAST(data AS target_type)` SQL idiom. The target_type is
provided via CastOptions. As a result we no longer need to maintain separate
binding boilerplate in Python for Array vs. ChunkedA
andygrove commented on pull request #7253:
URL: https://github.com/apache/arrow/pull/7253#issuecomment-633254544
I'm rethinking the approach here. I am fixing two things in this PR and it
might be better to attempt to address them separately. The initial goal was to
re-implement `get_super
wesm closed pull request #7257:
URL: https://github.com/apache/arrow/pull/7257
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm closed issue #7241:
URL: https://github.com/apache/arrow/issues/7241
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-633240348
The PR has been merged, but the code review feature is still available.
Please continue to leave comments and I will address them
---
wesm closed pull request #7240:
URL: https://github.com/apache/arrow/pull/7240
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-633231974
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-633229487
@jorisvandenbossche I fixed the segfault you hit and now have changed the
implementation of `Array.filter` to be
```
pc = _pc()
options = pc.FilterOptions(null_selection_
wesm commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-633218315
@jorisvandenbossche I'll take a look at that segfault
> The goal is to eventually have them all go through _pc.call_function()?
Yes. `arrow::compute::CallFunction` is gen
github-actions[bot] commented on pull request #7257:
URL: https://github.com/apache/arrow/pull/7257#issuecomment-633197970
https://issues.apache.org/jira/browse/ARROW-8915
This is an automated message from the Apache Git Serv
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r429553399
##
File path: cpp/src/jni/dataset/jni_wrapper.cpp
##
@@ -0,0 +1,517 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
kou opened a new pull request #7257:
URL: https://github.com/apache/arrow/pull/7257
The case_sensitive option requires Click 7 or later.
This is an automated message from the Apache Git Service.
To respond to the message, ple
jorisvandenbossche commented on pull request #7240:
URL: https://github.com/apache/arrow/pull/7240#issuecomment-633196165
I was playing a little bit with the python API:
- Ran into the following issue:
```python
>>> import pyarrow.compute as pc
62 matches
Mail list logo
