emkornfield commented on pull request #7288:
URL: https://github.com/apache/arrow/pull/7288#issuecomment-637320051
@hn5092 thank you for the PR. Could you add some benchmarks on your machine
that shows this improves things? I might be looking at the wrong place but it
appears memory is r
emkornfield commented on pull request #5883:
URL: https://github.com/apache/arrow/pull/5883#issuecomment-637309666
Going to close until the memory PRs are merged and we can figure out if we
want this/where we want it.
This i
emkornfield closed pull request #5883:
URL: https://github.com/apache/arrow/pull/5883
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield closed pull request #7313:
URL: https://github.com/apache/arrow/pull/7313
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield commented on pull request #7275:
URL: https://github.com/apache/arrow/pull/7275#issuecomment-637308504
@BryanCutler would you have time to review?
This is an automated message from the Apache Git Service.
To respo
emkornfield commented on pull request #7275:
URL: https://github.com/apache/arrow/pull/7275#issuecomment-637308552
@rymurr looks like this needs a rebase
This is an automated message from the Apache Git Service.
To respond to
emkornfield commented on a change in pull request #7289:
URL: https://github.com/apache/arrow/pull/7289#discussion_r433648119
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/complex/AbstractStructVector.java
##
@@ -40,11 +40,64 @@
public abstract class Abstrac
emkornfield commented on a change in pull request #7289:
URL: https://github.com/apache/arrow/pull/7289#discussion_r433647662
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/VectorSchemaRoot.java
##
@@ -54,7 +54,7 @@
private Schema schema;
private int row
emkornfield commented on a change in pull request #7289:
URL: https://github.com/apache/arrow/pull/7289#discussion_r433647053
##
File path: java/README.md
##
@@ -80,8 +80,12 @@ variable are set, the system property takes precedence.
## Java Properties
-For java 9 or later,
emkornfield commented on a change in pull request #7231:
URL: https://github.com/apache/arrow/pull/7231#discussion_r433645139
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowFooter.java
##
@@ -96,17 +126,40 @@ public Schema getSchema() {
r
emkornfield closed pull request #7317:
URL: https://github.com/apache/arrow/pull/7317
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
pprudhvi commented on pull request #7323:
URL: https://github.com/apache/arrow/pull/7323#issuecomment-637272293
Didn't we recently upgrade to llvm 9? Why jump to llvm10 so early?
This is an automated message from the Apache G
wesm commented on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637225192
> OK.
> I'll work on the GLib part as a separated pull request and add
`ARROW_DEPRECATED` in the pull request.
Perfect
wesm commented on pull request #7310:
URL: https://github.com/apache/arrow/pull/7310#issuecomment-637224951
Probably be good to merge this soon to limit rebase headaches
This is an automated message from the Apache Git Servic
wesm closed pull request #7300:
URL: https://github.com/apache/arrow/pull/7300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jianxind removed a comment on pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#issuecomment-636677517
Benchmark data:
Before:
```
SumKernelFloat/32768/0 2.96 us 2.96 us 236912
bytes_per_second=10.3227G/s null_percent=0 size=32.768k
Sum
wesm edited a comment on pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#issuecomment-637218125
I'll try to review this in the next couple days. @pitrou may be able to help
also
This is an automated messag
wesm commented on pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#issuecomment-637218125
I'll try to review this in the next couple days
This is an automated message from the Apache Git Service.
To respond
ursabot commented on pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#issuecomment-637216678
[AMD64 Ubuntu 18.04 C++ Benchmark
(#108899)](https://ci.ursalabs.org/#builders/73/builds/70) builder has been
succeeded.
Revision: d789801a5e83b9717b8f36d72189198f5527b757
wesm commented on pull request #7322:
URL: https://github.com/apache/arrow/pull/7322#issuecomment-637216454
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
wesm closed pull request #7322:
URL: https://github.com/apache/arrow/pull/7322
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
houqp edited a comment on pull request #7324:
URL: https://github.com/apache/arrow/pull/7324#issuecomment-637209800
@nevi-me do you prefer to move concat kernel logic into append_data in this
set of change or as a follow up after https://github.com/apache/arrow/pull/7306
gets merged?
---
jianxind commented on pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#issuecomment-637212463
@ursabot benchmark --suite-filter=arrow-compute-aggregate-benchmark
This is an automated message from the Apache
github-actions[bot] commented on pull request #7324:
URL: https://github.com/apache/arrow/pull/7324#issuecomment-637210669
https://issues.apache.org/jira/browse/ARROW-9005
This is an automated message from the Apache Git Serv
houqp commented on pull request #7324:
URL: https://github.com/apache/arrow/pull/7324#issuecomment-637209800
@nevi-me do you prefer to move concat kernel logic into append_data in this
set of change or as a follow up after https://github.com/apache/arrow/pull/7306
get merged?
---
houqp opened a new pull request #7324:
URL: https://github.com/apache/arrow/pull/7324
The only missing piece is updating sqlparser to parse null ordering
expression, which is going to be a rather big change due to major refactoring
from upstream sqlparer crate. So I am going to leave that
github-actions[bot] commented on pull request #7323:
URL: https://github.com/apache/arrow/pull/7323#issuecomment-637200610
Revision: 1b4fb8b0c8d18916360d9bc10b85e3762aad790f
Submitted crossbow builds: [ursa-labs/crossbow @
actions-279](https://github.com/ursa-labs/crossbow/branches/a
kou commented on pull request #7323:
URL: https://github.com/apache/arrow/pull/7323#issuecomment-637200038
@github-actions crossbow submit -g nightly
This is an automated message from the Apache Git Service.
To respond to the
mrkn commented on a change in pull request #6578:
URL: https://github.com/apache/arrow/pull/6578#discussion_r433558571
##
File path: c_glib/test/test-in-memory-scan-task.rb
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
kou commented on a change in pull request #6578:
URL: https://github.com/apache/arrow/pull/6578#discussion_r433556782
##
File path: c_glib/test/test-in-memory-scan-task.rb
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
github-actions[bot] commented on pull request #7323:
URL: https://github.com/apache/arrow/pull/7323#issuecomment-637190482
https://issues.apache.org/jira/browse/ARROW-9004
This is an automated message from the Apache Git Serv
kou opened a new pull request #7323:
URL: https://github.com/apache/arrow/pull/7323
LLVM 7 and 8 are still supported.
Clang Tools still use 8 because Clang Tools 10 reports an error for
RaipdJSON in sanitizer build. We should work on this as a separated
task.
e.g.:
emkornfield commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-637187135
As long as @pitrou is happy with my workaround to avoid inflicting pain on
AMD processor users.
I think I need to fix one signed conversion bug to make CI happy. I shou
kou commented on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637182726
OK.
I'll work on the GLib part as a separated pull request and add
`ARROW_DEPRECATED` in the pull request.
This is
wesm commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-637180635
I'll kick the tires on this re: performance. Is this ready to merge
otherwise?
This is an automated message from the
wesm commented on pull request #6590:
URL: https://github.com/apache/arrow/pull/6590#issuecomment-637180294
This has grown stale. Per @kou's comment this should be split into smaller
tasks and submitted as other PRs
This is
wesm closed pull request #6590:
URL: https://github.com/apache/arrow/pull/6590
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm closed pull request #6220:
URL: https://github.com/apache/arrow/pull/6220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on pull request #6220:
URL: https://github.com/apache/arrow/pull/6220#issuecomment-637180097
Closing this PR for now. Hopefully someone can pick up this project
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7322:
URL: https://github.com/apache/arrow/pull/7322#issuecomment-637170521
https://issues.apache.org/jira/browse/ARROW-8929
This is an automated message from the Apache Git Serv
wesm opened a new pull request #7322:
URL: https://github.com/apache/arrow/pull/7322
As Micah pointed out, 0 is a more reasonable default for the minimum number
of arguments than 1 is.
This is an automated message from the
wesm commented on pull request #7300:
URL: https://github.com/apache/arrow/pull/7300#issuecomment-637166114
The RTools 4.0 build was hanging so I triggered a new build
This is an automated message from the Apache Git Service.
github-actions[bot] commented on pull request #7321:
URL: https://github.com/apache/arrow/pull/7321#issuecomment-637164899
https://issues.apache.org/jira/browse/ARROW-8985
This is an automated message from the Apache Git Serv
wesm opened a new pull request #7321:
URL: https://github.com/apache/arrow/pull/7321
See mailing list discussion
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wesm commented on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637161793
Done. So GLib can be refactored later.
This is an automated message from the Apache Git Service.
To respond to the me
github-actions[bot] commented on pull request #7320:
URL: https://github.com/apache/arrow/pull/7320#issuecomment-637159969
https://issues.apache.org/jira/browse/ARROW-8896
This is an automated message from the Apache Git Serv
wesm opened a new pull request #7320:
URL: https://github.com/apache/arrow/pull/7320
In addition to removing duplicated logic, this decreases the size of -O3
libarrow.so about 250K on Linux.
This is an automated message fro
wesm commented on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637156379
@kou thanks. I'll try to add deprecated APIs for the functions that were
removed so that merging need not be blocked on the refactoring
-
kou commented on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637141114
I'll take a look this in a few days.
This is an automated message from the Apache Git Service.
To respond to the messa
wesm commented on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637130350
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
mrkn commented on a change in pull request #6578:
URL: https://github.com/apache/arrow/pull/6578#discussion_r433506325
##
File path: c_glib/test/test-in-memory-scan-task.rb
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
wesm edited a comment on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637112653
I figured out the R issue, I'm trying to fix. It's this hack here
https://github.com/apache/arrow/blob/master/r/src/compute.cpp#L180
---
wesm commented on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637112653
I figured out the R issue, I'm trying to fix
This is an automated message from the Apache Git Service.
To respond to
nevi-me commented on pull request #7297:
URL: https://github.com/apache/arrow/pull/7297#issuecomment-637103723
I have made progress on large arrays
(https://github.com/apache/arrow/compare/master...nevi-me:rust-large-lists),
the code is very repetitive so I still need to clean it up.
mrkn commented on a change in pull request #6578:
URL: https://github.com/apache/arrow/pull/6578#discussion_r433490389
##
File path: c_glib/arrow-dataset-glib/scanner.cpp
##
@@ -0,0 +1,524 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
nevi-me commented on pull request #4140:
URL: https://github.com/apache/arrow/pull/4140#issuecomment-637100922
There's some open comments/questions on this. I'll make time to work on them
before `1.0.0` release, so we can merge this.
---
github-actions[bot] commented on pull request #7319:
URL: https://github.com/apache/arrow/pull/7319#issuecomment-637100265
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could
github-actions[bot] commented on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637100263
https://issues.apache.org/jira/browse/ARROW-8917
This is an automated message from the Apache Git Serv
nevi-me commented on pull request #7252:
URL: https://github.com/apache/arrow/pull/7252#issuecomment-637099283
I'll merge this tomorrow evening GMT if there haven't been any further
reviews.
This is an automated message fro
nevi-me closed pull request #7265:
URL: https://github.com/apache/arrow/pull/7265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
wesm edited a comment on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637095245
@nealrichardson I will need your help on the one failing R test
@kou I removed 6 of the 8 `Take` APIs -- I think it would be better for GLib
to use the Datum/Datum or Ca
nevi-me opened a new pull request #7319:
URL: https://github.com/apache/arrow/pull/7319
**Note**: I started making changes to #6785, and ended up deviating a lot.
___
This is a draft to implement an arrow writer for parquet. It supports the
following (no complete test coverage ye
wesm commented on pull request #7318:
URL: https://github.com/apache/arrow/pull/7318#issuecomment-637095245
@nealrichardson I will need your help on the one failing R test
@kou I removed 6 of the 8 `Take` APIs -- I think it would be better for GLib
to use the Datum/Datum API if possi
wesm opened a new pull request #7318:
URL: https://github.com/apache/arrow/pull/7318
A "metafunction" is one that dispatches to other functions based on the
argument types. It does not contain any kernels.
Other stuff in this PR:
* Make "take" and "filter" metafunctions that a
wesm commented on pull request #7300:
URL: https://github.com/apache/arrow/pull/7300#issuecomment-637070516
Needs rebase
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
fsaintjacques closed pull request #7285:
URL: https://github.com/apache/arrow/pull/7285
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
houqp commented on pull request #7309:
URL: https://github.com/apache/arrow/pull/7309#issuecomment-637059093
Looks like we have to remove Seek constraints in order to support compressed
format across the board. If this is the plan here as well, then I recommend
just implement Read for json
zeapo commented on pull request #7309:
URL: https://github.com/apache/arrow/pull/7309#issuecomment-637046642
Would it make sense to implement for json reader the same interfaces that
are on csv reader, i.e. `Read + Seek` for `infer_file_schema`, and a
`json::Reader::from_buf_reader()`.
houqp commented on pull request #7309:
URL: https://github.com/apache/arrow/pull/7309#issuecomment-637040555
> One dramatic alternative would be to always require a schema, and leave
inference to the user. We could then consume the buffer reader (reader: mut
BufReader instead of reader: &m
fsaintjacques edited a comment on pull request #7285:
URL: https://github.com/apache/arrow/pull/7285#issuecomment-637034980
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
fsaintjacques commented on pull request #7285:
URL: https://github.com/apache/arrow/pull/7285#issuecomment-637034980
@cyb70289 Thank for this. For future reference, if you add a new benchmark,
do it first as a seperate commit, and then add the improvement in a following
(chronologically) s
fsaintjacques commented on pull request #7300:
URL: https://github.com/apache/arrow/pull/7300#issuecomment-637030938
once https://github.com/ursa-labs/ursabot/pull/197 is merged, we shouldn't
need to specify `origin/master` as a baseline.
--
ursabot commented on pull request #7300:
URL: https://github.com/apache/arrow/pull/7300#issuecomment-637030201
[AMD64 Ubuntu 18.04 C++ Benchmark
(#108807)](https://ci.ursalabs.org/#builders/73/builds/69) builder has been
succeeded.
Revision: be1ecf709e862a84284ed354239859a15a32d702
lidavidm commented on pull request #7224:
URL: https://github.com/apache/arrow/pull/7224#issuecomment-637026817
@pitrou following up, any other comments here? Thanks!
This is an automated message from the Apache Git Service.
lidavidm closed pull request #7270:
URL: https://github.com/apache/arrow/pull/7270
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
github-actions[bot] commented on pull request #7317:
URL: https://github.com/apache/arrow/pull/7317#issuecomment-637024588
https://issues.apache.org/jira/browse/ARROW-9000
This is an automated message from the Apache Git Serv
fsaintjacques commented on pull request #7300:
URL: https://github.com/apache/arrow/pull/7300#issuecomment-637024748
@ursabot benchmark --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=CopyBitmapWithOffset origin/master
---
fsaintjacques closed pull request #7316:
URL: https://github.com/apache/arrow/pull/7316
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
laurentgo opened a new pull request #7317:
URL: https://github.com/apache/arrow/pull/7317
Errorprone 2.3.3 is not compatible with JDK14 and crashes while building
the project.
Update to 2.4.0 version which is compatible with latest JDK.
---
bkietz closed pull request #7311:
URL: https://github.com/apache/arrow/pull/7311
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ursabot commented on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-637005626
[AMD64 Ubuntu 18.04 C++ Benchmark
(#108788)](https://ci.ursalabs.org/#builders/73/builds/68) builder has been
succeeded.
Revision: 82ebbe815f899daece4b7186197b1519f1274d4b
kszucs commented on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-63653
@ursabot benchmark --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=CopyBitmapWithOffset origin/master
T
kszucs commented on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636998101
@ursabot build
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
kszucs commented on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636997158
@ursabot benchmark --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=CopyBitmapWithOffset origin/master
T
github-actions[bot] commented on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636995741
https://issues.apache.org/jira/browse/ARROW-8997
This is an automated message from the Apache Git Serv
fsaintjacques removed a comment on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636991533
@ursabot benchmark --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=CopyBitmapWithOffset origin/master
---
fsaintjacques commented on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636993138
@ursabot benchmark --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=CopyBitmapWithOffset origin/master
---
fsaintjacques removed a comment on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636991119
@ursabot benchmark diff --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=CopyBitmapWithOffset origin/master
--
ursabot removed a comment on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636991141
```
Got unexpected extra argument (origin/master)
```
This is an automated message from the Apache G
fsaintjacques commented on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636991119
@ursabot benchmark diff --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=CopyBitmapWithOffset origin/master
--
fsaintjacques commented on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636991533
@ursabot benchmark --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=CopyBitmapWithOffset origin/master
---
ursabot commented on pull request #7316:
URL: https://github.com/apache/arrow/pull/7316#issuecomment-636991141
```
Got unexpected extra argument (origin/master)
```
This is an automated message from the Apache Git Servi
fsaintjacques opened a new pull request #7316:
URL: https://github.com/apache/arrow/pull/7316
This adds human readable values to the compare values.
This is an automated message from the Apache Git Service.
To respond to the
sonthonaxrk commented on pull request #6979:
URL: https://github.com/apache/arrow/pull/6979#issuecomment-636979018
@jorisvandenbossche yes it would affect how `read` works as it changes the
reader properties.
I'm not too fussed about adding it into read as you can use `set_batch_size
wesm commented on a change in pull request #7311:
URL: https://github.com/apache/arrow/pull/7311#discussion_r433349705
##
File path: cpp/src/arrow/array/diff.cc
##
@@ -342,106 +311,74 @@ class QuadraticSpaceMyersDiff {
{field("insert", boolean()), field("run_length", i
wesm edited a comment on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-636918597
I can help with this if needed
This is an automated message from the Apache Git Service.
To respond to the mes
bkietz commented on pull request #7181:
URL: https://github.com/apache/arrow/pull/7181#issuecomment-636937045
@emkornfield @wesm In adding a unit test I've become uncertain of the
`ColumnReader` contract and whether my solution upholds it
- [ColumnReader::NextBatch's
doccomment](htt
wesm commented on pull request #7308:
URL: https://github.com/apache/arrow/pull/7308#issuecomment-636919225
OK, we should introduce a `ScalarAggregateOptions` providing null handling
behavior, then
This is an automated messa
bkietz commented on a change in pull request #7311:
URL: https://github.com/apache/arrow/pull/7311#discussion_r433297868
##
File path: cpp/src/arrow/array/diff.cc
##
@@ -181,17 +146,37 @@ internal::LazyRange>
MakeNullOrViewRange(
/// representation is minimal in the common ca
wesm commented on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-636918597
I can help with this
This is an automated message from the Apache Git Service.
To respond to the message, please log
1 - 100 of 141 matches
Mail list logo
