nevi-me commented on a change in pull request #7324:
URL: https://github.com/apache/arrow/pull/7324#discussion_r436242734
##
File path: rust/arrow/src/compute/kernels/concat.rs
##
@@ -0,0 +1,395 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contr
github-actions[bot] commented on pull request #7365:
URL: https://github.com/apache/arrow/pull/7365#issuecomment-639990238
https://issues.apache.org/jira/browse/ARROW-9007
This is an automated message from the Apache Git Serv
nevi-me commented on pull request #7365:
URL: https://github.com/apache/arrow/pull/7365#issuecomment-639990231
@houqp I finally completed this. The lists and nested lists were quite
tricky, but I managed in the end.
This is
nevi-me opened a new pull request #7365:
URL: https://github.com/apache/arrow/pull/7365
This enables appending `ArrayDataRef` to builders, which makes it easier to
concatenate arrays
This is an automated message from the Apa
pitrou edited a comment on pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#issuecomment-63992
@nevi-me If you're confident that it works as intended by the spec, then
IMHO you can leave it in. Hopefully this will all be validated soon by
integration tests, though :-)
github-actions[bot] commented on pull request #7364:
URL: https://github.com/apache/arrow/pull/7364#issuecomment-639975189
https://issues.apache.org/jira/browse/ARROW-9052
This is an automated message from the Apache Git Serv
kou opened a new pull request #7364:
URL: https://github.com/apache/arrow/pull/7364
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou edited a comment on pull request #7363:
URL: https://github.com/apache/arrow/pull/7363#issuecomment-639960291
Sorry. This will be big to review.
This fixes recent test failure like
https://github.com/apache/arrow/runs/737152388 :
```text
2020-06-04T04:42:11.7272962Z Failur
kou commented on pull request #7363:
URL: https://github.com/apache/arrow/pull/7363#issuecomment-639960291
Sorry. This will be big to for review.
This fixes recent test failure like
https://github.com/apache/arrow/runs/737152388 :
```text
2020-06-04T04:42:11.7272962Z Failure:
github-actions[bot] commented on pull request #7363:
URL: https://github.com/apache/arrow/pull/7363#issuecomment-639958010
https://issues.apache.org/jira/browse/ARROW-9051
This is an automated message from the Apache Git Serv
kou opened a new pull request #7363:
URL: https://github.com/apache/arrow/pull/7363
It's for preventing from freeing needed data.
This is an automated message from the Apache Git Service.
To respond to the message, please log
kou closed pull request #7362:
URL: https://github.com/apache/arrow/pull/7362
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou commented on pull request #7362:
URL: https://github.com/apache/arrow/pull/7362#issuecomment-639953075
+1
All green.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kou commented on pull request #7284:
URL: https://github.com/apache/arrow/pull/7284#issuecomment-639952334
Thanks for confirming it.
Could you confirm one more thing?
Does https://github.com/apache/arrow/pull/7284#pullrequestreview-419603540
without your changes and `cmake ... -DP
wesm closed pull request #7361:
URL: https://github.com/apache/arrow/pull/7361
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on pull request #7361:
URL: https://github.com/apache/arrow/pull/7361#issuecomment-639946527
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
github-actions[bot] commented on pull request #7362:
URL: https://github.com/apache/arrow/pull/7362#issuecomment-639920452
Revision: fea4939b427e3263b6540937aab381af6384d9da
Submitted crossbow builds: [ursa-labs/crossbow @
actions-290](https://github.com/ursa-labs/crossbow/branches/a
kou commented on pull request #7362:
URL: https://github.com/apache/arrow/pull/7362#issuecomment-639919957
@github-actions crossbow submit -g linux
This is an automated message from the Apache Git Service.
To respond to the m
github-actions[bot] commented on pull request #7362:
URL: https://github.com/apache/arrow/pull/7362#issuecomment-639915909
https://issues.apache.org/jira/browse/ARROW-9050
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #7361:
URL: https://github.com/apache/arrow/pull/7361#issuecomment-639915904
https://issues.apache.org/jira/browse/ARROW-8825
This is an automated message from the Apache Git Serv
kou opened a new pull request #7362:
URL: https://github.com/apache/arrow/pull/7362
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wesm opened a new pull request #7361:
URL: https://github.com/apache/arrow/pull/7361
Supersedes #7202
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
wesm commented on pull request #7202:
URL: https://github.com/apache/arrow/pull/7202#issuecomment-639908201
This needs to rebased so I'll open a new PR
This is an automated message from the Apache Git Service.
To respond to t
wesm closed pull request #7202:
URL: https://github.com/apache/arrow/pull/7202
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
kszucs commented on pull request #7126:
URL: https://github.com/apache/arrow/pull/7126#issuecomment-639907740
I mean parquet is dependent on boost through thrift.
This is an automated message from the Apache Git Service.
To r
kszucs commented on pull request #7126:
URL: https://github.com/apache/arrow/pull/7126#issuecomment-639906493
After realizing that thrift<0.13 has a header dependency on boost we
probably should.
This is an automated message
kszucs commented on pull request #7162:
URL: https://github.com/apache/arrow/pull/7162#issuecomment-639904834
I don’t want to have more untested code in the build scripts so yes, I’d
like to have a minimal coverage there (even if it is painful to mock).
---
wesm commented on pull request #7162:
URL: https://github.com/apache/arrow/pull/7162#issuecomment-639900492
Do you still want to write unit tests or can we merge this and address the
next time we need to make a patch release?
---
wesm commented on pull request #7126:
URL: https://github.com/apache/arrow/pull/7126#issuecomment-639899976
How do you want to proceed here, should we abandon this?
This is an automated message from the Apache Git Service.
To
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639899415
I'm going to be basing some patches on top of this, I can rebase whenever
this gets reviewed/merged
This is an autom
wesm closed pull request #7334:
URL: https://github.com/apache/arrow/pull/7334
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on pull request #7334:
URL: https://github.com/apache/arrow/pull/7334#issuecomment-639898609
Merging. Thanks all.
This is an automated message from the Apache Git Service.
To respond to the message, please log
github-actions[bot] commented on pull request #7360:
URL: https://github.com/apache/arrow/pull/7360#issuecomment-639850769
https://issues.apache.org/jira/browse/ARROW-9047
This is an automated message from the Apache Git Serv
maxburke opened a new pull request #7360:
URL: https://github.com/apache/arrow/pull/7360
If the mutable bitset is allocated with zero elements it'll have an
address that, when accessed, segfaults. Even if the number of bits (n)
set is zero, it still reads from this invalid address and
nealrichardson commented on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-639827383
@github-actions rebase
This is an automated message from the Apache Git Service.
To respond to the message,
eerhardt commented on pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#issuecomment-639816442
> @eerhardt Would you like to fill in the C# columns?
Doing it now.
This is an automated message from the
github-actions[bot] commented on pull request #7359:
URL: https://github.com/apache/arrow/pull/7359#issuecomment-639768322
https://issues.apache.org/jira/browse/ARROW-8723
This is an automated message from the Apache Git Serv
paddyhoran opened a new pull request #7359:
URL: https://github.com/apache/arrow/pull/7359
The benchmarks take long enough as it is and (explicit) SIMD can now be
turned on and off via a feature flag which was not the case when these
benchmarks were added.
---
chrish42 commented on pull request #7110:
URL: https://github.com/apache/arrow/pull/7110#issuecomment-639753240
Okay, even more work-in-progress than the usual, but pushing here to ask for
some CMake advice. Basically, I've moved things to a member function of the
Schema class (that works)
kou closed pull request #7323:
URL: https://github.com/apache/arrow/pull/7323
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
wesm closed pull request #7358:
URL: https://github.com/apache/arrow/pull/7358
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
kou commented on pull request #7323:
URL: https://github.com/apache/arrow/pull/7323#issuecomment-639752639
No objections.
I'll merge this.
This is an automated message from the Apache Git Service.
To respond to the message
wesm commented on a change in pull request #7358:
URL: https://github.com/apache/arrow/pull/7358#discussion_r436103434
##
File path: cpp/src/arrow/compute/kernels/vector_selection_benchmark.cc
##
@@ -0,0 +1,291 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+
fsaintjacques commented on a change in pull request #7358:
URL: https://github.com/apache/arrow/pull/7358#discussion_r436089235
##
File path: cpp/src/arrow/compute/kernels/vector_selection_benchmark.cc
##
@@ -0,0 +1,291 @@
+// Licensed to the Apache Software Foundation (ASF) un
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639697297
OK, here are the binary benchmarks:
```
Benchmark
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639685965
I'm adding a BitmapReader-based comparison for the binary case. Stay tuned
This is an automated message from the Apac
github-actions[bot] commented on pull request #7358:
URL: https://github.com/apache/arrow/pull/7358#issuecomment-639672332
https://issues.apache.org/jira/browse/ARROW-9045
This is an automated message from the Apache Git Serv
wesm opened a new pull request #7358:
URL: https://github.com/apache/arrow/pull/7358
The idea of this patch is to provide a more comprehensive baseline for the
optimization work I'm undertaking.
Summary:
* Benchmark take when indices are monotonic and contain no nulls. Monoton
kszucs commented on pull request #7355:
URL: https://github.com/apache/arrow/pull/7355#issuecomment-639603684
I saw that renaming the top level license could work, but wasn't entirely
clear from the comments. Merged because this should work until we try out the
renaming. Created a jira to
xhochy commented on a change in pull request #7334:
URL: https://github.com/apache/arrow/pull/7334#discussion_r436015255
##
File path: dev/tasks/python-wheels/win-build.bat
##
@@ -96,9 +101,10 @@ set ARROW_TEST_DATA=%ARROW_SRC%\testing\data
%PYTHON_INTERPRETER% -c "import pyar
wesm commented on pull request #7143:
URL: https://github.com/apache/arrow/pull/7143#issuecomment-639566354
@emkornfield I can take a look at this once
https://github.com/apache/arrow/pull/7356 is merged which adds a single-word
function to `BitBlockCounter`
-
wesm commented on pull request #7355:
URL: https://github.com/apache/arrow/pull/7355#issuecomment-639560475
Hm maybe this was merged too quickly. It sounds like we can avoid the copied
license and instead rename the root LICENSE.txt to LICENSE. Can you help with
this? Many packaging script
wesm edited a comment on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639555962
OK here are the fixed benchmarks. These match my intuition now. This shows
that there is very little downside and nearly always upside to using
`BitBlockCounter` over `BitmapR
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639555962
OK here are the fixed benchmarks. These match my intuition now. This shows
that there is very little downside and nearly always upside to using
`BitBlockCounter` over `BitmapReader`.
github-actions[bot] commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639553741
https://issues.apache.org/jira/browse/ARROW-9034
This is an automated message from the Apache Git Serv
github-actions[bot] commented on pull request #7357:
URL: https://github.com/apache/arrow/pull/7357#issuecomment-639553742
https://issues.apache.org/jira/browse/ARROW-555
This is an automated message from the Apache Git Servi
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639550537
There are some issues with the benchmarks, I'll fix them and repost numbers
This is an automated message from the Apa
wesm removed a comment on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639547819
Benchmarks
```
BitBlockCounterSum/8 1687631 ns1687634 ns
407 592.545M items/s
BitBlockCounterSum/64
maartenbreddels opened a new pull request #7357:
URL: https://github.com/apache/arrow/pull/7357
First PR to test the workflow and CI.
This is an automated message from the Apache Git Service.
To respond to the message, please
wesm commented on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-639547819
Benchmarks
```
BitBlockCounterSum/8 1687631 ns1687634 ns
407 592.545M items/s
BitBlockCounterSum/64 73080
kszucs commented on pull request #7334:
URL: https://github.com/apache/arrow/pull/7334#issuecomment-639547670
@xhochy could you please give it a review?
This is an automated message from the Apache Git Service.
To respond to
kszucs closed pull request #7355:
URL: https://github.com/apache/arrow/pull/7355
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm opened a new pull request #7356:
URL: https://github.com/apache/arrow/pull/7356
BinaryBitBlockCounter computes the popcount of the bitwise-and of each
corresponding bit-run (with target of 64 bits at a time) of two bitmaps. This
permits iterating through two validity bitmaps that don'
kszucs commented on pull request #7355:
URL: https://github.com/apache/arrow/pull/7355#issuecomment-639543388
Ouch, this is annoying.
This is an automated message from the Apache Git Service.
To respond to the message, please
kszucs edited a comment on pull request #7341:
URL: https://github.com/apache/arrow/pull/7341#issuecomment-639542072
@bkietz I think it is ready for a review now, the build failures are present
on the master branch.
This is
kszucs commented on pull request #7341:
URL: https://github.com/apache/arrow/pull/7341#issuecomment-639542072
@bkietz I think it is ready for a review now.
This is an automated message from the Apache Git Service.
To respond
kszucs closed pull request #7327:
URL: https://github.com/apache/arrow/pull/7327
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jba commented on issue #7351:
URL: https://github.com/apache/arrow/issues/7351#issuecomment-639533445
golang/go#39417 was closed with an explanation of why symlinks can never
happen. It suggests one alternative to making the copy, which is renaming the
file at root to `LICENSE`.
fsaintjacques commented on a change in pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#discussion_r426085245
##
File path: python/pyarrow/_dataset.pyx
##
@@ -42,6 +43,51 @@ def _forbid_instantiation(klass, subclasses_instead=True):
raise TypeError(msg)
wesm closed pull request #7352:
URL: https://github.com/apache/arrow/pull/7352
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
wesm commented on pull request #7352:
URL: https://github.com/apache/arrow/pull/7352#issuecomment-639480440
Appveyor looks OK
https://ci.appveyor.com/project/wesm/arrow/builds/9226. Merging
This is an automated message f
github-actions[bot] commented on pull request #7355:
URL: https://github.com/apache/arrow/pull/7355#issuecomment-639473640
https://issues.apache.org/jira/browse/ARROW-9043
This is an automated message from the Apache Git Serv
wesm closed issue #7351:
URL: https://github.com/apache/arrow/issues/7351
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
wesm opened a new pull request #7355:
URL: https://github.com/apache/arrow/pull/7355
See #7351. Once `go mod` can follow symlinks this should be replaced by a
symlink.
This is an automated message from the Apache Git Servic
github-actions[bot] commented on pull request #7341:
URL: https://github.com/apache/arrow/pull/7341#issuecomment-639466642
https://issues.apache.org/jira/browse/ARROW-9042
This is an automated message from the Apache Git Serv
wesm commented on pull request #7352:
URL: https://github.com/apache/arrow/pull/7352#issuecomment-639460710
Will merge this once CI is passing
This is an automated message from the Apache Git Service.
To respond to the messag
lidavidm commented on a change in pull request #7354:
URL: https://github.com/apache/arrow/pull/7354#discussion_r435895352
##
File path: docs/source/java/vector.rst
##
@@ -118,6 +118,28 @@ Some points to note about the steps above:
no longer used, to avoid resource leak. To
jba commented on issue #7351:
URL: https://github.com/apache/arrow/issues/7351#issuecomment-639454123
It doesn't work at present. I filed the issue linked above.
Whatever the resolution of that issue, nothing will happen soon (Go is just
beginning a 6-month release cycle), so maybe y
wesm commented on a change in pull request #7352:
URL: https://github.com/apache/arrow/pull/7352#discussion_r435890909
##
File path: cpp/src/arrow/util/bitmap_ops.h
##
@@ -0,0 +1,228 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
wesm commented on a change in pull request #7352:
URL: https://github.com/apache/arrow/pull/7352#discussion_r435889032
##
File path: cpp/src/arrow/util/bitmap_ops.h
##
@@ -0,0 +1,228 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licen
pitrou commented on pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#issuecomment-639445690
Certainly someone (or several people) would have to evaluate those libraries
before deciding whether to integrate one. Preferably someone with an interest
in SIMD optimizations (fo
pitrou commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r435879355
##
File path: docs/source/status.rst
##
@@ -0,0 +1,199 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agre
rymurr commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r435826739
##
File path: docs/source/status.rst
##
@@ -0,0 +1,199 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license agre
rymurr commented on a change in pull request #7248:
URL: https://github.com/apache/arrow/pull/7248#discussion_r435819400
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/util/ValueVectorUtility.java
##
@@ -90,42 +90,59 @@ public static String getToString(ValueVe
rymurr commented on a change in pull request #7326:
URL: https://github.com/apache/arrow/pull/7326#discussion_r435803219
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/compression/CompressionCodec.java
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Softwar
85 matches
Mail list logo
